Page MenuHomePhabricator

[seeder] Add a test to check outgoing messages in response to VERACK
ClosedPublic

Authored by jasonbcox on Dec 7 2020, 23:26.

Details

Summary

This is in preparation for testing new logic related to using GETHEADERS
messages to check checkpoints. In addition, we'll be able to flesh out
the existing unit tests a bit more.

Depends on D8623

Test Plan
ninja bitcoin-seeder check-seeder

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix requested changes to this revision.Dec 7 2020, 23:43
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/seeder/bitcoin.h
57 ↗(On Diff #26258)

This is changing the layout, maybe it is preferable to make a protcted accessor.

Alternatively, make a friend class like it is done for ConnMan or avalanche::Processor.

This revision now requires changes to proceed.Dec 7 2020, 23:43
  • Improve the API for testing
  • Use NetMsgType::GETADDR in place of a hardcoded string
  • Other minor nits
This revision is now accepted and ready to land.Dec 9 2020, 21:50