[seeder] Add a test to check outgoing messages in response to VERACK
ClosedPublic
Actions

Authored by jasonbcox on Dec 7 2020, 23:26.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC6b57151f3e4d: [seeder] Add a test to check outgoing messages in response to VERACK

Summary

This is in preparation for testing new logic related to using GETHEADERS
messages to check checkpoints. In addition, we'll be able to flesh out
the existing unit tests a bit more.

Depends on D8623

Test Plan

ninja bitcoin-seeder check-seeder

Diff Detail

Repository

rABC Bitcoin ABC

Branch

recv-verack-test

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14361
Build 28697: Build Diff	lint-circular-dependencies · build-clang · build-without-wallet · build-diff · build-debug · build-clang-tidy
Build 28696: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Dec 7 2020, 23:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 7 2020, 23:26

jasonbcox requested review of this revision.Dec 7 2020, 23:26

Harbormaster completed remote builds in B14344: Diff 26258.Dec 7 2020, 23:42

deadalnix requested changes to this revision.Dec 7 2020, 23:43

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/seeder/bitcoin.h
57 ↗	(On Diff #26258)	This is changing the layout, maybe it is preferable to make a protcted accessor. Alternatively, make a friend class like it is done for ConnMan or avalanche::Processor.