HomePhabricator

Merge #13152: [rpc] Add getnodeaddresses RPC command

Description

Merge #13152: [rpc] Add getnodeaddresses RPC command

Summary:
a2eb6f5405 [rpc] Add getnodeaddresses RPC command (chris-belcher)

Pull request description:

Implements issue https://github.com/bitcoin/bitcoin/issues/9463

New getnodeaddresses call gives access via RPC to the peers known by the node. It may be useful for bitcoin wallets to broadcast their transactions over tor for improved privacy without using the centralized DNS seeds. getnodeaddresses is very similar to the getaddr p2p method.

Please advise me on the best approach for writing an automated test. By my reading the getaddr p2p method also isn't really tested.

Tree-SHA512: ad03abf518847476495b76a2f5394b8030aa86654429167fa618e21460abb505c10ef9817ec1b80472320d41d0aff5dc94a8efce023aaaaf5e81386aa92b852b

Backport of Core PR13152

Test Plan:

ninja check
ninja check-functional

./bitcoind
./bitcoin-cli help getnodeaddresses

Verify help text

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox

Subscribers: jasonbcox, markblundeberg

Differential Revision: https://reviews.bitcoinabc.org/D5214

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Sep 18 2018, 23:49
nakihitoCommitted on Feb 12 2020, 18:56
nakihitoPushed on Feb 12 2020, 21:44
Reviewer
Restricted Owners Package
Differential Revision
D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command
Parents
rSTAGINGfcf22e8fcc94: OP_REVERSEBYTES activation logic
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/16333, tag: phabricator/base/16332, tag: phabricator/base/16331