- User Since
- Jul 22 2018, 17:49 (26 w, 2 d)
Sun, Jan 20
My understanding is that the ticket is addressing a code readability issue. You want it to be easier to identify what version of Push() is being used by renaming the overloaded functions based on the argument the function takes. However, I've just been informed that there is an issue of code ownership with these types of changes so I'll close this diff.
Nov 10 2018
Removed unnecessary includes for address.h and untangled an include web.
Oct 26 2018
Removed unnecessary include statements.
Updated to latest version of master.
Sep 29 2018
Untangled a few more include trees and seperated more CChain member function implementation into chain.cpp.
Fixed accidental forward includes in a couple of .cpp files and replaced them with include statements. Also removed TODO comment in address.cpp because there was no consensus reached agreeing to the splitting of CServiceFlags.
Sep 27 2018
Sep 26 2018
Fixed missing include statement.
Sep 21 2018
Sep 19 2018
Fixed comment formatting.
Added TODO comment for CDiskBlockIndex.
Rebased diff and updated to make sure phabricator builds correctly.
Sep 17 2018
Sep 11 2018
Added comment signaling CDiskBlockIndex will be seperated in a subsequent diff.
Made change to GetCommand() to more closely resemble original.
Sep 9 2018
I don't have a way to assign this to myself, but I put up a diff for this: https://reviews.bitcoinabc.org/D1743
Removed unnecessary includes and added forward declaration as suggested.
Sep 7 2018
Fixed validation.cpp formatting error.
Sep 6 2018
Sep 4 2018
Aug 28 2018
The function uses the global variable vinfoBlockFile, however, this function is locked away in an anonymous namespace. I'm not sure this change is actually worth making at this point as it would require either naming the namespace or moving the the variable outside of the namespace.
Fixed some formatting errors and removed an unnecessary forward declaration.
Removed some unnecessary include statements and fixed some formating issues.
Work after this patch may require someone to go through some various .h files and untangle some include webs. As is, it compiles and runs through the tests fine on my computer. Update will be up after D1660's.
Removed unnecessary include statement in src/validation.h for CDiskBlockPos and replaced it with forward declaration.
Will update this patch with recommended changes as soon as soon as I can.
Aug 21 2018
Updated some unnecessary inlcudes.
Aug 20 2018
Fixed white space typo and removed unnecessary chain.h include in versionbits.h.
Added endif include guard comment for blockvalidity.h.
Fixed white spacing issue in validation.cpp.
Aug 19 2018
Inlcuded blockvalidity.h in src/Makefile.am, fixed white space issue.
Added diskblockpos.h to src/Makefile.am.
Added blockfileinfo.h to src/Makefile.am.
Aug 14 2018
Aug 11 2018
Sorry, my revisions seem to be getting uploaded in the wrong order. Will fix.