Page MenuHomePhabricator

nakihito (Nico)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2018, 17:49 (26 w, 2 d)

Recent Activity

Sun, Jan 20

nakihito abandoned D2354: Renamed TestBuilder.Push( string hex ) to .PushHex( string hex ).
Sun, Jan 20, 23:34
nakihito added a comment to D2354: Renamed TestBuilder.Push( string hex ) to .PushHex( string hex ).

My understanding is that the ticket is addressing a code readability issue. You want it to be easier to identify what version of Push() is being used by renaming the overloaded functions based on the argument the function takes. However, I've just been informed that there is an issue of code ownership with these types of changes so I'll close this diff.

Sun, Jan 20, 23:34
Herald added a reviewer for D2354: Renamed TestBuilder.Push( string hex ) to .PushHex( string hex ): Restricted Project.
Sun, Jan 20, 23:05

Nov 10 2018

nakihito updated the diff for D1795: Moved CAddress from protocol.h and protocol.cpp into its own address.h and address.cpp files..

Removed unnecessary includes for address.h and untangled an include web.

Nov 10 2018, 21:16

Oct 26 2018

nakihito updated the diff for D1795: Moved CAddress from protocol.h and protocol.cpp into its own address.h and address.cpp files..

Removed unnecessary include statements.

Oct 26 2018, 05:11
nakihito updated the diff for D1660: Seperated CBlockIndex class from chain.h into it blockindex.h and updated dependencies in other .h and .cpp files..

Updated to latest version of master.

Oct 26 2018, 04:33

Sep 29 2018

nakihito updated the diff for D1661: Seperated CDiskBlockIndex class from chain.h into its own .h file and updated other .cpp and .h file dependencies..

Untangled a few more include trees and seperated more CChain member function implementation into chain.cpp.

Sep 29 2018, 08:08
nakihito updated the diff for D1795: Moved CAddress from protocol.h and protocol.cpp into its own address.h and address.cpp files..

Fixed accidental forward includes in a couple of .cpp files and replaced them with include statements. Also removed TODO comment in address.cpp because there was no consensus reached agreeing to the splitting of CServiceFlags.

Sep 29 2018, 06:30

Sep 27 2018

nakihito committed rSTAGING13048d9dee12: Changed CMessageHeader::pchCommand to use a C++11 array and updated its various… (authored by nakihito).
Changed CMessageHeader::pchCommand to use a C++11 array and updated its various…
Sep 27 2018, 19:04
nakihito committed rSTAGING5977efad639b: Resolved forgotten chain.h merge. (authored by nakihito).
Resolved forgotten chain.h merge.
Sep 27 2018, 19:02
nakihito committed rSTAGING1846d75b46d1: Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and . (authored by nakihito).
Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and .
Sep 27 2018, 19:00
nakihito committed rSTAGINGb59151daf3ef: Seperated enum class BlockValidity from chain.h into its own .h file and… (authored by nakihito).
Seperated enum class BlockValidity from chain.h into its own .h file and…
Sep 27 2018, 19:00
nakihito committed rSTAGING62591dfadea3: Seperated BlockStatus class from chain.h file and updated .h and .cpp… (authored by nakihito).
Seperated BlockStatus class from chain.h file and updated .h and .cpp…
Sep 27 2018, 19:00
nakihito committed rSTAGINGe868c6b3f3df: Moved CBlockFileInfo class from chain.h into its own header and updated .cpp… (authored by nakihito).
Moved CBlockFileInfo class from chain.h into its own header and updated .cpp…
Sep 27 2018, 18:58

Sep 26 2018

nakihito updated the diff for D1660: Seperated CBlockIndex class from chain.h into it blockindex.h and updated dependencies in other .h and .cpp files..

Fixed missing include statement.

Sep 26 2018, 18:45

Sep 21 2018

nakihito added inline comments to D1795: Moved CAddress from protocol.h and protocol.cpp into its own address.h and address.cpp files..
Sep 21 2018, 10:37
nakihito updated the diff for D1795: Moved CAddress from protocol.h and protocol.cpp into its own address.h and address.cpp files..

Fixed typo.

Sep 21 2018, 05:01
Herald added a reviewer for D1795: Moved CAddress from protocol.h and protocol.cpp into its own address.h and address.cpp files.: Restricted Project.
Sep 21 2018, 04:24
nakihito added a revision to T407: protocol.h/cpp: Move CAddress to its own header/source files: D1795: Moved CAddress from protocol.h and protocol.cpp into its own address.h and address.cpp files..
Sep 21 2018, 04:24 · Restricted Project, Bootcamp

Sep 19 2018

nakihito closed T247: Make CMessageHeader::pchCommand a C++ array as Resolved.
Sep 19 2018, 18:31 · Bootcamp
nakihito updated the diff for D1660: Seperated CBlockIndex class from chain.h into it blockindex.h and updated dependencies in other .h and .cpp files..

Fixed comment formatting.

Sep 19 2018, 18:30
nakihito updated the diff for D1660: Seperated CBlockIndex class from chain.h into it blockindex.h and updated dependencies in other .h and .cpp files..

Added TODO comment for CDiskBlockIndex.

Sep 19 2018, 18:26
nakihito updated the diff for D1584: Updated osx and unix build docs to include out-of-tree build recommendations and instructions..

Rebased diff and updated to make sure phabricator builds correctly.

Sep 19 2018, 18:18

Sep 17 2018

nakihito added inline comments to D1660: Seperated CBlockIndex class from chain.h into it blockindex.h and updated dependencies in other .h and .cpp files..
Sep 17 2018, 18:47
nakihito committed rABC13048d9dee12: Changed CMessageHeader::pchCommand to use a C++11 array and updated its various… (authored by nakihito).
Changed CMessageHeader::pchCommand to use a C++11 array and updated its various…
Sep 17 2018, 18:43
nakihito closed D1743: Changed CMessageHeader::pchCommand to use a C++11 array and updated its various uses to reflect this..
Sep 17 2018, 18:43

Sep 11 2018

nakihito updated the diff for D1660: Seperated CBlockIndex class from chain.h into it blockindex.h and updated dependencies in other .h and .cpp files..

Added comment signaling CDiskBlockIndex will be seperated in a subsequent diff.

Sep 11 2018, 20:50
nakihito updated the diff for D1743: Changed CMessageHeader::pchCommand to use a C++11 array and updated its various uses to reflect this..

Made change to GetCommand() to more closely resemble original.

Sep 11 2018, 20:44

Sep 9 2018

nakihito added a comment to T247: Make CMessageHeader::pchCommand a C++ array.

I don't have a way to assign this to myself, but I put up a diff for this: https://reviews.bitcoinabc.org/D1743

Sep 9 2018, 19:45 · Bootcamp
Herald added a reviewer for D1743: Changed CMessageHeader::pchCommand to use a C++11 array and updated its various uses to reflect this.: Restricted Project.
Sep 9 2018, 19:43
nakihito updated the diff for D1660: Seperated CBlockIndex class from chain.h into it blockindex.h and updated dependencies in other .h and .cpp files..

Removed unnecessary includes and added forward declaration as suggested.

Sep 9 2018, 06:31

Sep 7 2018

nakihito added inline comments to D1660: Seperated CBlockIndex class from chain.h into it blockindex.h and updated dependencies in other .h and .cpp files..
Sep 7 2018, 20:43
nakihito committed rABC5977efad639b: Resolved forgotten chain.h merge. (authored by nakihito).
Resolved forgotten chain.h merge.
Sep 7 2018, 20:09
nakihito closed D1719: Resolved forgotten chain.h merge..
Sep 7 2018, 20:08
nakihito updated the diff for D1719: Resolved forgotten chain.h merge..

Fixed validation.cpp formatting error.

Sep 7 2018, 03:49

Sep 6 2018

nakihito added inline comments to D1719: Resolved forgotten chain.h merge..
Sep 6 2018, 01:03

Sep 4 2018

Herald added a reviewer for D1719: Resolved forgotten chain.h merge.: Restricted Project.
Sep 4 2018, 22:29
nakihito committed rABC62591dfadea3: Seperated BlockStatus class from chain.h file and updated .h and .cpp… (authored by nakihito).
Seperated BlockStatus class from chain.h file and updated .h and .cpp…
Sep 4 2018, 05:49
nakihito closed D1659: Seperated BlockStatus class from chain.h file and updated .h and .cpp dependencies..
Sep 4 2018, 05:48
nakihito committed rABCb59151daf3ef: Seperated enum class BlockValidity from chain.h into its own .h file and… (authored by nakihito).
Seperated enum class BlockValidity from chain.h into its own .h file and…
Sep 4 2018, 05:43
nakihito closed D1656: Seperated enum class BlockValidity from chain.h into its own .h file and updated other .h and .cpp dependencies..
Sep 4 2018, 05:43
nakihito committed rABC1846d75b46d1: Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and . (authored by nakihito).
Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and .
Sep 4 2018, 05:34
nakihito closed D1655: Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and .cpp dependencies..
Sep 4 2018, 05:34

Aug 28 2018

nakihito added a comment to T388: Clean up Zombie GetBlockFileInfo function.

The function uses the global variable vinfoBlockFile, however, this function is locked away in an anonymous namespace. I'm not sure this change is actually worth making at this point as it would require either naming the namespace or moving the the variable outside of the namespace.

Aug 28 2018, 04:14 · Bootcamp, Restricted Project
nakihito updated the diff for D1661: Seperated CDiskBlockIndex class from chain.h into its own .h file and updated other .cpp and .h file dependencies..

Fixed some formatting errors and removed an unnecessary forward declaration.

Aug 28 2018, 03:22
nakihito updated the diff for D1660: Seperated CBlockIndex class from chain.h into it blockindex.h and updated dependencies in other .h and .cpp files..

Removed some unnecessary include statements and fixed some formating issues.

Aug 28 2018, 03:20
nakihito added inline comments to D1655: Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and .cpp dependencies..
Aug 28 2018, 03:00
nakihito added a comment to D1661: Seperated CDiskBlockIndex class from chain.h into its own .h file and updated other .cpp and .h file dependencies..

Work after this patch may require someone to go through some various .h files and untangle some include webs. As is, it compiles and runs through the tests fine on my computer. Update will be up after D1660's.

Aug 28 2018, 02:13
nakihito updated the diff for D1655: Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and .cpp dependencies..

Removed unnecessary include statement in src/validation.h for CDiskBlockPos and replaced it with forward declaration.

Aug 28 2018, 01:52
nakihito added a comment to D1660: Seperated CBlockIndex class from chain.h into it blockindex.h and updated dependencies in other .h and .cpp files..

Will update this patch with recommended changes as soon as soon as I can.

Aug 28 2018, 00:16

Aug 21 2018

nakihito committed rABCe868c6b3f3df: Moved CBlockFileInfo class from chain.h into its own header and updated .cpp… (authored by nakihito).
Moved CBlockFileInfo class from chain.h into its own header and updated .cpp…
Aug 21 2018, 00:14
nakihito closed D1654: Moved CBlockFileInfo class from chain.h into its own header and updated .cpp and .h file dependencies..
Aug 21 2018, 00:14
nakihito updated the diff for D1660: Seperated CBlockIndex class from chain.h into it blockindex.h and updated dependencies in other .h and .cpp files..

Updated some unnecessary inlcudes.

Aug 21 2018, 00:10

Aug 20 2018

nakihito updated the diff for D1660: Seperated CBlockIndex class from chain.h into it blockindex.h and updated dependencies in other .h and .cpp files..

Fixed white space typo and removed unnecessary chain.h include in versionbits.h.

Aug 20 2018, 23:21
Herald added a reviewer for D1661: Seperated CDiskBlockIndex class from chain.h into its own .h file and updated other .cpp and .h file dependencies.: Restricted Project.
Aug 20 2018, 03:47
Herald added a reviewer for D1660: Seperated CBlockIndex class from chain.h into it blockindex.h and updated dependencies in other .h and .cpp files.: Restricted Project.
Aug 20 2018, 02:58
nakihito updated the diff for D1656: Seperated enum class BlockValidity from chain.h into its own .h file and updated other .h and .cpp dependencies..

Added endif include guard comment for blockvalidity.h.

Aug 20 2018, 02:29
nakihito updated the diff for D1659: Seperated BlockStatus class from chain.h file and updated .h and .cpp dependencies..

Fixed white spacing issue in validation.cpp.

Aug 20 2018, 00:54

Aug 19 2018

Herald added a reviewer for D1659: Seperated BlockStatus class from chain.h file and updated .h and .cpp dependencies.: Restricted Project.
Aug 19 2018, 23:54
nakihito updated the diff for D1656: Seperated enum class BlockValidity from chain.h into its own .h file and updated other .h and .cpp dependencies..

Inlcuded blockvalidity.h in src/Makefile.am, fixed white space issue.

Aug 19 2018, 22:50
nakihito updated the diff for D1655: Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and .cpp dependencies..

Added diskblockpos.h to src/Makefile.am.

Aug 19 2018, 22:29
nakihito updated the diff for D1654: Moved CBlockFileInfo class from chain.h into its own header and updated .cpp and .h file dependencies..

Added blockfileinfo.h to src/Makefile.am.

Aug 19 2018, 22:01

Aug 14 2018

nakihito closed T129: Add instructions for all platforms to build out-of-tree as Resolved.
Aug 14 2018, 21:31 · Bootcamp
nakihito abandoned D1629: Seperated BlockStatus class from chain.h file and updated .h and .cpp dependencies..
Aug 14 2018, 21:18
nakihito abandoned D1628: Seperated enum class BlockValidity from chain.h into its own .h file and updated other .h and .cpp dependencies..
Aug 14 2018, 21:17
nakihito planned changes to D1656: Seperated enum class BlockValidity from chain.h into its own .h file and updated other .h and .cpp dependencies..

blockvalidity.h is missing an #include "tinyformat.h" under line 8 for strprintf() which is present in D1655 (which this depends on). Will update after D1654 and D1655 are passed.

Aug 14 2018, 21:16
Herald added a reviewer for D1656: Seperated enum class BlockValidity from chain.h into its own .h file and updated other .h and .cpp dependencies.: Restricted Project.
Aug 14 2018, 20:50
Herald added a reviewer for D1655: Seperated CDiskBlockPos from Chain.h into its own .h file and updated .h and .cpp dependencies.: Restricted Project.
Aug 14 2018, 20:27
Herald added a reviewer for D1654: Moved CBlockFileInfo class from chain.h into its own header and updated .cpp and .h file dependencies.: Restricted Project.
Aug 14 2018, 20:13

Aug 11 2018

nakihito abandoned D1642: Moved CBlockFileInfo class from chain.h into its own header and updated .cpp and .h file dependencies. Fixed typo in copyright info..

Sorry, my revisions seem to be getting uploaded in the wrong order. Will fix.

Aug 11 2018, 01:14
Herald added a reviewer for D1642: Moved CBlockFileInfo class from chain.h into its own header and updated .cpp and .h file dependencies. Fixed typo in copyright info.: Restricted Project.
Aug 11 2018, 01:08

Aug 6 2018

Herald added a reviewer for D1629: Seperated BlockStatus class from chain.h file and updated .h and .cpp dependencies.: Restricted Project.
Aug 6 2018, 23:52
Herald added a reviewer for D1628: Seperated enum class BlockValidity from chain.h into its own .h file and updated other .h and .cpp dependencies.: Restricted Project.
Aug 6 2018, 23:43

Jul 22 2018

nakihito triaged T389: Replace Hungarian notation for classes that are/were in Chain.h as Low priority.
Jul 22 2018, 22:35 · Bootcamp, Restricted Project
nakihito triaged T388: Clean up Zombie GetBlockFileInfo function as Low priority.
Jul 22 2018, 22:20 · Bootcamp, Restricted Project
Herald added a reviewer for D1584: Updated osx and unix build docs to include out-of-tree build recommendations and instructions.: Restricted Project.
Jul 22 2018, 20:32