Page MenuHomePhabricator

nakihito (Nico)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2018, 17:49 (82 w, 2 d)

Recent Activity

Today

nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Changed FIXTURE test cases to AUTO, renamed some variables and constants, added testNode to the fixture setup, increased the functionality of the wrapper class.

Wed, Feb 19, 02:28

Yesterday

nakihito committed rABC1c4b1649e462: Merge #12035: [qt] change µBTC to bits (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #12035: [qt] change µBTC to bits
Tue, Feb 18, 22:51
nakihito closed D5296: Merge #12035: [qt] change µBTC to bits.
Tue, Feb 18, 22:51
nakihito committed rABCe3f2849c16f4: Merge #14307: Consolidate redundant implementations of ParseHashStr (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14307: Consolidate redundant implementations of ParseHashStr
Tue, Feb 18, 22:49
nakihito closed D5295: Merge #14307: Consolidate redundant implementations of ParseHashStr.
Tue, Feb 18, 22:49
nakihito committed rABC07cc225cf5ab: Merge #13424: Consistently validate txid / blockhash length and encoding in rpc… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13424: Consistently validate txid / blockhash length and encoding in rpc…
Tue, Feb 18, 22:21
nakihito closed D5294: Merge #13424: Consistently validate txid / blockhash length and encoding in rpc calls.
Tue, Feb 18, 22:21
nakihito updated the diff for D5296: Merge #12035: [qt] change µBTC to bits.

Removed unit change and addressed other nits.

Tue, Feb 18, 22:08
nakihito updated the test plan for D5296: Merge #12035: [qt] change µBTC to bits.
Tue, Feb 18, 22:07
nakihito updated the summary of D5296: Merge #12035: [qt] change µBTC to bits.
Tue, Feb 18, 22:01
nakihito updated the test plan for D5296: Merge #12035: [qt] change µBTC to bits.
Tue, Feb 18, 21:59
nakihito planned changes to D5296: Merge #12035: [qt] change µBTC to bits.

Changes to be made accordingly.

Tue, Feb 18, 20:20
nakihito updated the diff for D5294: Merge #13424: Consistently validate txid / blockhash length and encoding in rpc calls.

Fixed missing blockhash.

Tue, Feb 18, 16:54

Sat, Feb 15

nakihito accepted D5293: Add missing items to release-notes + formatting fixups.
Sat, Feb 15, 02:28
nakihito requested review of D5296: Merge #12035: [qt] change µBTC to bits.
Sat, Feb 15, 01:53
nakihito updated the test plan for D5296: Merge #12035: [qt] change µBTC to bits.
Sat, Feb 15, 01:52
nakihito planned changes to D5296: Merge #12035: [qt] change µBTC to bits.
Sat, Feb 15, 01:49
nakihito created D5296: Merge #12035: [qt] change µBTC to bits.
Sat, Feb 15, 01:46
nakihito committed rABC925cb24b97b1: Merge #12079: Improve prioritisetransaction test coverage (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12079: Improve prioritisetransaction test coverage
Sat, Feb 15, 00:39
nakihito closed D5292: Merge #12079: Improve prioritisetransaction test coverage.
Sat, Feb 15, 00:39
nakihito created D5295: Merge #14307: Consolidate redundant implementations of ParseHashStr.
Sat, Feb 15, 00:30

Fri, Feb 14

nakihito created D5294: Merge #13424: Consistently validate txid / blockhash length and encoding in rpc calls.
Fri, Feb 14, 23:59
nakihito created D5292: Merge #12079: Improve prioritisetransaction test coverage.
Fri, Feb 14, 22:44
nakihito committed rABCe584d180ab73: Merge #14460: tests: Improve 'CAmount' tests (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #14460: tests: Improve 'CAmount' tests
Fri, Feb 14, 18:33
nakihito closed D5277: Merge #14460: tests: Improve 'CAmount' tests.
Fri, Feb 14, 18:33
nakihito committed rABC937a91eb9ebc: Merge #14679: importmulti: Don't add internal addresses to address book (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14679: importmulti: Don't add internal addresses to address book
Fri, Feb 14, 18:24
nakihito closed D5288: Merge #14679: importmulti: Don't add internal addresses to address book.
Fri, Feb 14, 18:24
nakihito created D5288: Merge #14679: importmulti: Don't add internal addresses to address book.
Fri, Feb 14, 01:11

Thu, Feb 13

nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Changed BOOST_AUTO_TEST_SUITE to BOOST_FIXTURE_TEST_SUITE and BOOST_AUTO_TEST_CASE to BOOST_FIXTURE_TEST_CASE. Added SeederTestingSetup struct for the fixture test suite. Changed user_agent type to std::string.

Thu, Feb 13, 22:48
nakihito updated the diff for D5277: Merge #14460: tests: Improve 'CAmount' tests.

Removed type casts.

Thu, Feb 13, 20:32
nakihito committed rABC054899250f31: Merge #14720: rpc: Correctly name arguments (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14720: rpc: Correctly name arguments
Thu, Feb 13, 20:15
nakihito closed D5281: Merge #14720: rpc: Correctly name arguments.
Thu, Feb 13, 20:15
nakihito committed rABC30527d21d9fe: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC
Thu, Feb 13, 19:44
nakihito closed D5280: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC.
Thu, Feb 13, 19:44
nakihito updated the diff for D5277: Merge #14460: tests: Improve 'CAmount' tests.

Added CFeeRate changes.

Thu, Feb 13, 19:26
nakihito created D5281: Merge #14720: rpc: Correctly name arguments.
Thu, Feb 13, 01:36

Wed, Feb 12

nakihito created D5280: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC.
Wed, Feb 12, 23:24
nakihito accepted D5279: [CI] Run the functional tests when wallet is disable.
Wed, Feb 12, 23:18
nakihito created D5277: Merge #14460: tests: Improve 'CAmount' tests.
Wed, Feb 12, 21:45
nakihito committed rABC48916ac8540e: Merge #13152: [rpc] Add getnodeaddresses RPC command (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13152: [rpc] Add getnodeaddresses RPC command
Wed, Feb 12, 18:56
nakihito closed D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
Wed, Feb 12, 18:56
nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Removed excess includes and changed function name.

Wed, Feb 12, 02:11
nakihito committed rABCddcbef8bf4b3: Merge #14310: [wallet] Ensure wallet is unlocked before signing (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14310: [wallet] Ensure wallet is unlocked before signing
Wed, Feb 12, 01:21
nakihito closed D5271: Merge #14310: [wallet] Ensure wallet is unlocked before signing.
Wed, Feb 12, 01:21
nakihito created D5271: Merge #14310: [wallet] Ensure wallet is unlocked before signing.
Wed, Feb 12, 01:00
nakihito updated the diff for D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Functional style casting.

Wed, Feb 12, 00:46

Tue, Feb 11

nakihito committed rABCd2436be68d5e: Merge #14236: qa: generate --> generatetoaddress change to allow tests run… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14236: qa: generate --> generatetoaddress change to allow tests run…
Tue, Feb 11, 23:26
nakihito closed D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet.
Tue, Feb 11, 23:26
nakihito added a comment to D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet.

The code looks correct, but the test plan is inadequate.

Tue, Feb 11, 23:13
nakihito updated the test plan for D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet.
Tue, Feb 11, 23:11
nakihito created D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet.
Tue, Feb 11, 21:40
nakihito updated the diff for D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Rebased.

Tue, Feb 11, 16:51
nakihito requested review of D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
Tue, Feb 11, 02:43
nakihito planned changes to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
Tue, Feb 11, 01:38
nakihito updated the diff for D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Rebased.

Tue, Feb 11, 01:38
nakihito planned changes to D4442: Seeder bans nodes not following the correct chain.
Tue, Feb 11, 01:31
nakihito updated the diff for D4442: Seeder bans nodes not following the correct chain.

Rebased and CheckForCheckpoint() -> RequestBlocksAfterCheckpoint().

Tue, Feb 11, 01:31
nakihito retitled D4442: Seeder bans nodes not following the correct chain from Seeder filters nodes by chainparams to Seeder bans nodes not following the correct chain.
Tue, Feb 11, 01:24

Mon, Feb 10

nakihito updated the diff for D5241: Make parse_name() properly fail when the query name is longer than 255 characters.

Added clarifying comment and changed to test to check immediately beyond the character limit.

Mon, Feb 10, 23:49
nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Squashed some tests together, extracted some setup code, and fixed some comments.

Mon, Feb 10, 23:34
nakihito added inline comments to D4436: Add unit tests for CSeederNode::ProcessMessage().
Mon, Feb 10, 23:32
nakihito planned changes to D5241: Make parse_name() properly fail when the query name is longer than 255 characters.
Mon, Feb 10, 23:28
nakihito retitled D5241: Make parse_name() properly fail when the query name is longer than 255 characters from Make parse_name() fail when the query name is longer than 255 characters to Make parse_name() properly fail when the query name is longer than 255 characters.
Mon, Feb 10, 22:02
nakihito planned changes to D4439: Allow Seeder to handle receiving HEADER messages.
Mon, Feb 10, 20:40
nakihito updated the diff for D4439: Allow Seeder to handle receiving HEADER messages.

Rebased and updated to reflect changes D4436.

Mon, Feb 10, 20:40
nakihito updated the summary of D4436: Add unit tests for CSeederNode::ProcessMessage().
Mon, Feb 10, 20:33
nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Removed excess constants, extracted messge building functions from the test class, and removed unnecessary test class member variable.

Mon, Feb 10, 20:32
nakihito created D5241: Make parse_name() properly fail when the query name is longer than 255 characters.
Mon, Feb 10, 20:24
nakihito added inline comments to D4418: Add unit tests for parse_name().
Mon, Feb 10, 20:23
nakihito updated the diff for D4418: Add unit tests for parse_name().

Fixed off by one error.

Mon, Feb 10, 20:22

Sat, Feb 8

nakihito planned changes to D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.

Investigating build failures.

Sat, Feb 8, 01:24
nakihito created D5214: Merge #13152: [rpc] Add getnodeaddresses RPC command.
Sat, Feb 8, 00:05

Fri, Feb 7

nakihito committed rABCf40d38e63e1c: Update copyright for various files (authored by nakihito).
Update copyright for various files
Fri, Feb 7, 23:44
nakihito closed D5155: Update copyright for various files.
Fri, Feb 7, 23:43
nakihito updated the diff for D5155: Update copyright for various files.

Rebased.

Fri, Feb 7, 21:26
nakihito committed rABCc7af8f0ab549: Merge #13823: qa: quote path in authproxy for external multiwallets (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13823: qa: quote path in authproxy for external multiwallets
Fri, Feb 7, 18:35
nakihito closed D5187: Merge #13823: qa: quote path in authproxy for external multiwallets.
Fri, Feb 7, 18:35
nakihito committed rABCea0cb385d243: Merge #14179: qa: Fixups to "Run all tests even if wallet is not compiled" (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14179: qa: Fixups to "Run all tests even if wallet is not compiled"
Fri, Feb 7, 18:34
nakihito closed D5185: Merge #14179: qa: Fixups to "Run all tests even if wallet is not compiled".
Fri, Feb 7, 18:34
nakihito committed rABC4dfa4724abcf: Merge #14180: qa: Run all tests even if wallet is not compiled (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14180: qa: Run all tests even if wallet is not compiled
Fri, Feb 7, 18:33
nakihito closed D5184: Merge #14180: qa: Run all tests even if wallet is not compiled.
Fri, Feb 7, 18:33
nakihito committed rABC651157d3ffa6: Update copyright_header.py to not duplicate parts of the header (authored by nakihito).
Update copyright_header.py to not duplicate parts of the header
Fri, Feb 7, 18:33
nakihito closed D5157: Update copyright_header.py to not duplicate parts of the header.
Fri, Feb 7, 18:32
nakihito created D5188: Make copyright script update to current year instead of last commit year.
Fri, Feb 7, 01:49
nakihito requested review of D5187: Merge #13823: qa: quote path in authproxy for external multiwallets.
Fri, Feb 7, 01:16
nakihito planned changes to D5187: Merge #13823: qa: quote path in authproxy for external multiwallets.
Fri, Feb 7, 01:15
nakihito created D5187: Merge #13823: qa: quote path in authproxy for external multiwallets.
Fri, Feb 7, 01:15

Thu, Feb 6

nakihito requested review of D5185: Merge #14179: qa: Fixups to "Run all tests even if wallet is not compiled".
Thu, Feb 6, 22:34
nakihito requested review of D5184: Merge #14180: qa: Run all tests even if wallet is not compiled.
Thu, Feb 6, 22:34
nakihito planned changes to D5185: Merge #14179: qa: Fixups to "Run all tests even if wallet is not compiled".
Thu, Feb 6, 21:50
nakihito created D5185: Merge #14179: qa: Fixups to "Run all tests even if wallet is not compiled".
Thu, Feb 6, 21:50
nakihito planned changes to D5184: Merge #14180: qa: Run all tests even if wallet is not compiled.
Thu, Feb 6, 21:48
nakihito created D5184: Merge #14180: qa: Run all tests even if wallet is not compiled.
Thu, Feb 6, 21:48
nakihito committed rABC1b1bc9407ad7: Merge #14094: refactoring: Remove unreferenced local variables (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14094: refactoring: Remove unreferenced local variables
Thu, Feb 6, 19:42
nakihito closed D5166: Merge #14094: refactoring: Remove unreferenced local variables.
Thu, Feb 6, 19:42

Wed, Feb 5

nakihito requested review of D5166: Merge #14094: refactoring: Remove unreferenced local variables.
Wed, Feb 5, 23:31
nakihito planned changes to D5166: Merge #14094: refactoring: Remove unreferenced local variables.
Wed, Feb 5, 22:15
nakihito created D5166: Merge #14094: refactoring: Remove unreferenced local variables.
Wed, Feb 5, 22:15
nakihito updated the test plan for D5157: Update copyright_header.py to not duplicate parts of the header.
Wed, Feb 5, 00:47
nakihito updated the diff for D5157: Update copyright_header.py to not duplicate parts of the header.

Moved find_distribution_line_index() call sites to be closer to where it is actually used.

Wed, Feb 5, 00:46