Page MenuHomePhabricator

nakihito (Nico)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2018, 17:49 (68 w, 4 d)

Recent Activity

Today

nakihito updated the diff for D4449: Merge #14025: p2p: Remove dead code for nVersion=10300.

Removed some more obsolete code from the seeder.

Fri, Nov 15, 15:13
nakihito planned changes to D4439: Allow Seeder to handle receiving HEADER messages.

Investigating build failure.

Fri, Nov 15, 13:01
nakihito updated the diff for D4439: Allow Seeder to handle receiving HEADER messages.

Seeder now requests the blocks that come after the most recent checkpoint and uses that information to determine whether the peer is on the correct chain.

Fri, Nov 15, 12:25
nakihito updated the summary of D4442: Seeder filters nodes by chainparams.
Fri, Nov 15, 06:50
nakihito updated the summary of D4439: Allow Seeder to handle receiving HEADER messages.
Fri, Nov 15, 06:47
nakihito updated the summary of D4439: Allow Seeder to handle receiving HEADER messages.
Fri, Nov 15, 06:46
nakihito updated the summary of D4439: Allow Seeder to handle receiving HEADER messages.
Fri, Nov 15, 06:45
nakihito added inline comments to D4436: Add unit tests for CSeederNode::ProcessMessage().
Fri, Nov 15, 06:32
nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Rebased to included changes from D4449 which allow the removal of a test. Also renamed a test and changed addr message tests to specify how many addrs to include in the addr message among other concerns.

Fri, Nov 15, 06:29
nakihito added inline comments to D4436: Add unit tests for CSeederNode::ProcessMessage().
Fri, Nov 15, 06:29
nakihito updated the summary of D4436: Add unit tests for CSeederNode::ProcessMessage().
Fri, Nov 15, 06:25
nakihito updated the test plan for D4449: Merge #14025: p2p: Remove dead code for nVersion=10300.
Fri, Nov 15, 06:17
nakihito requested review of D4449: Merge #14025: p2p: Remove dead code for nVersion=10300.
Fri, Nov 15, 06:16
nakihito planned changes to D4449: Merge #14025: p2p: Remove dead code for nVersion=10300.
Fri, Nov 15, 06:15
nakihito created D4449: Merge #14025: p2p: Remove dead code for nVersion=10300.
Fri, Nov 15, 06:14
nakihito updated the diff for D4418: Add unit tests for parse_name().

Fixed nits.

Fri, Nov 15, 06:00

Yesterday

nakihito requested review of D4300: Replace getopts() with gArgs in the Seeder..
Thu, Nov 14, 20:57
nakihito updated the test plan for D4300: Replace getopts() with gArgs in the Seeder..
Thu, Nov 14, 20:57
nakihito planned changes to D4300: Replace getopts() with gArgs in the Seeder..
Thu, Nov 14, 20:55
nakihito updated the diff for D4300: Replace getopts() with gArgs in the Seeder..

ParseCommandLine uses SelectParams() now. Added error message for -regtest option.

Thu, Nov 14, 20:55
nakihito requested review of D4442: Seeder filters nodes by chainparams.
Thu, Nov 14, 04:42
nakihito requested review of D4439: Allow Seeder to handle receiving HEADER messages.
Thu, Nov 14, 04:41
nakihito requested review of D4436: Add unit tests for CSeederNode::ProcessMessage().
Thu, Nov 14, 04:41
nakihito requested review of D4418: Add unit tests for parse_name().
Thu, Nov 14, 04:41
nakihito planned changes to D4442: Seeder filters nodes by chainparams.
Thu, Nov 14, 04:40
nakihito created D4442: Seeder filters nodes by chainparams.
Thu, Nov 14, 04:40
nakihito planned changes to D4439: Allow Seeder to handle receiving HEADER messages.
Thu, Nov 14, 04:38
nakihito updated the diff for D4439: Allow Seeder to handle receiving HEADER messages.

Squashed some missed changed.

Thu, Nov 14, 04:37
nakihito retitled D4439: Allow Seeder to handle receiving HEADER messages from Allow Seeder to handle receiving NOTFOUND and HEADER messages to Allow Seeder to handle receiving HEADER messages.
Thu, Nov 14, 04:25
nakihito planned changes to D4439: Allow Seeder to handle receiving HEADER messages.
Thu, Nov 14, 04:24
nakihito updated the diff for D4439: Allow Seeder to handle receiving HEADER messages.

Rebase, split test into two different tests, removed NOTFOUND message functionality because it is not necessary, added differentiating logic for an empty HEADERS message and a non-empty HEADERS message. Also added some more constants.

Thu, Nov 14, 04:24
nakihito planned changes to D4436: Add unit tests for CSeederNode::ProcessMessage().
Thu, Nov 14, 04:21
nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Changed static_cast into a functional cast.

Thu, Nov 14, 04:21
nakihito planned changes to D4436: Add unit tests for CSeederNode::ProcessMessage().
Thu, Nov 14, 03:58
nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Split tests into smaller parts and added more constants.

Thu, Nov 14, 03:58
nakihito planned changes to D4418: Add unit tests for parse_name().
Thu, Nov 14, 03:11
nakihito updated the diff for D4418: Add unit tests for parse_name().

Broken tests into smaller parts, made names more explicit, added more constants.

Thu, Nov 14, 03:11
nakihito requested review of D4300: Replace getopts() with gArgs in the Seeder..
Thu, Nov 14, 01:44
nakihito planned changes to D4300: Replace getopts() with gArgs in the Seeder..
Thu, Nov 14, 01:43
nakihito updated the diff for D4300: Replace getopts() with gArgs in the Seeder..

Came up with a better solution for the return value of ParseCommandLine(). Changed handling of -testnet option to mirror bitcoin-cli.cpp.

Thu, Nov 14, 01:43
nakihito planned changes to D4300: Replace getopts() with gArgs in the Seeder..
Thu, Nov 14, 01:10
nakihito planned changes to D4418: Add unit tests for parse_name().
Thu, Nov 14, 00:56
nakihito planned changes to D4436: Add unit tests for CSeederNode::ProcessMessage().
Thu, Nov 14, 00:52

Wed, Nov 13

nakihito planned changes to D4439: Allow Seeder to handle receiving HEADER messages.
Wed, Nov 13, 20:56
nakihito created D4439: Allow Seeder to handle receiving HEADER messages.
Wed, Nov 13, 20:56
nakihito updated the diff for D4436: Add unit tests for CSeederNode::ProcessMessage().

Cleaned up TestCSeederNode and rebase.

Wed, Nov 13, 19:53
nakihito requested review of D4418: Add unit tests for parse_name().
Wed, Nov 13, 19:49
nakihito planned changes to D4418: Add unit tests for parse_name().
Wed, Nov 13, 19:13
nakihito updated the diff for D4418: Add unit tests for parse_name().

Removed code creating the DNS message header because it is unnecessary for these tests. Renamed various functions/variables. Also added some more comments.

Wed, Nov 13, 19:13
nakihito requested review of D4300: Replace getopts() with gArgs in the Seeder..
Wed, Nov 13, 18:11
nakihito requested review of D4417: Add a separate executible for seeder tests.
Wed, Nov 13, 18:05
nakihito updated the test plan for D4417: Add a separate executible for seeder tests.
Wed, Nov 13, 18:05
nakihito planned changes to D4417: Add a separate executible for seeder tests.
Wed, Nov 13, 02:19
nakihito updated the diff for D4417: Add a separate executible for seeder tests.

Added $(PIE_FLAGS) for clang.

Wed, Nov 13, 02:19
nakihito planned changes to D4417: Add a separate executible for seeder tests.
Wed, Nov 13, 02:17
nakihito abandoned D4419: Modify CSeederNode to allow more testing.

See D4436.

Wed, Nov 13, 01:14
nakihito updated the summary of D4436: Add unit tests for CSeederNode::ProcessMessage().
Wed, Nov 13, 01:13
nakihito planned changes to D4436: Add unit tests for CSeederNode::ProcessMessage().
Wed, Nov 13, 01:13
nakihito created D4436: Add unit tests for CSeederNode::ProcessMessage().
Wed, Nov 13, 01:13
nakihito updated the diff for D4417: Add a separate executible for seeder tests.

Fixed typo.

Wed, Nov 13, 01:11
nakihito planned changes to D4417: Add a separate executible for seeder tests.
Wed, Nov 13, 00:55
nakihito planned changes to D4418: Add unit tests for parse_name().
Wed, Nov 13, 00:40
nakihito updated the diff for D4418: Add unit tests for parse_name().

Fixed some variable names.

Wed, Nov 13, 00:40
nakihito planned changes to D4300: Replace getopts() with gArgs in the Seeder..
Wed, Nov 13, 00:22
nakihito updated the diff for D4300: Replace getopts() with gArgs in the Seeder..

Renamed enum class and moved it within the CSeederOpts class. Changed main() return values to use EXIT_SUCCESS and EXIT_FAILURE.

Wed, Nov 13, 00:22

Tue, Nov 12

nakihito updated the diff for D4417: Add a separate executible for seeder tests.

Rebased and adjusted some cmake names.

Tue, Nov 12, 23:17
nakihito created D4434: Add/update copyright lines to top of seeder code.
Tue, Nov 12, 21:51
nakihito updated the diff for D4432: Added CMake function to detect BOOST_TEST_DYN_LINK.

Addressed nits.

Tue, Nov 12, 21:02
nakihito updated the diff for D4432: Added CMake function to detect BOOST_TEST_DYN_LINK.

Function now also adds the unit test files to the test suite by calling add_test_to_suite.

Tue, Nov 12, 20:31
nakihito updated the diff for D4432: Added CMake function to detect BOOST_TEST_DYN_LINK.

Renamed function.

Tue, Nov 12, 19:49
nakihito planned changes to D4432: Added CMake function to detect BOOST_TEST_DYN_LINK.
Tue, Nov 12, 08:26
nakihito updated the diff for D4432: Added CMake function to detect BOOST_TEST_DYN_LINK.

Moved function to TestSuite.cmake. Function now also handles searching for the boost package and linking the library to the executable.

Tue, Nov 12, 08:26
nakihito updated the summary of D4417: Add a separate executible for seeder tests.
Tue, Nov 12, 02:16
nakihito planned changes to D4417: Add a separate executible for seeder tests.
Tue, Nov 12, 02:10
nakihito updated the diff for D4417: Add a separate executible for seeder tests.

Changed CMake names to be more descriptive, Updated copyright missing copyright lines, fixed formatting, and rebased to remove duplicate code.

Tue, Nov 12, 02:10
nakihito created D4432: Added CMake function to detect BOOST_TEST_DYN_LINK.
Tue, Nov 12, 01:05

Sat, Nov 9

nakihito updated the diff for D4417: Add a separate executible for seeder tests.

Added copyright lines and cleaned up Makefile.

Sat, Nov 9, 02:07
nakihito created D4419: Modify CSeederNode to allow more testing.
Sat, Nov 9, 01:14
nakihito abandoned D4276: Add unit tests for seeder's parse_name().

See D4418.

Sat, Nov 9, 01:01
nakihito abandoned D4413: Add a separate executible for seeder tests.

See D4417.

Sat, Nov 9, 01:01
nakihito created D4418: Add unit tests for parse_name().
Sat, Nov 9, 01:00
nakihito created D4417: Add a separate executible for seeder tests.
Sat, Nov 9, 00:59

Fri, Nov 8

nakihito planned changes to D4276: Add unit tests for seeder's parse_name().
Fri, Nov 8, 23:22
nakihito requested review of D4276: Add unit tests for seeder's parse_name().

Executable added in D4413.

Fri, Nov 8, 19:34
nakihito created D4413: Add a separate executible for seeder tests.
Fri, Nov 8, 19:34
nakihito updated the diff for D4395: Switch all RNG code to the built-in PRNG..

Rebased and added braces.

Fri, Nov 8, 16:09
nakihito updated the diff for D4394: Integrate util/system's CInit into RNGState.

Rebased.

Fri, Nov 8, 16:06
nakihito updated the diff for D4300: Replace getopts() with gArgs in the Seeder..

Added enum class and changed return value of ParseCommandLine() to make use of it.

Fri, Nov 8, 03:57

Thu, Nov 7

nakihito added a comment to D4402: Merge #15324: test: Make bloom tests deterministic.

Working on https://github.com/bitcoin/bitcoin/pull/15296 for a more comprehensive test plan.

Thu, Nov 7, 19:14
nakihito added a comment to D4395: Switch all RNG code to the built-in PRNG..

You may want to run builds (and ideally tests) on some other platforms, as this code embeds platform-dependent behavior.

Thu, Nov 7, 19:07

Wed, Nov 6

nakihito planned changes to D4402: Merge #15324: test: Make bloom tests deterministic.
Wed, Nov 6, 21:09
nakihito updated the test plan for D4398: DRY: Implement GetRand using FastRandomContext::randrange.
Wed, Nov 6, 20:09
nakihito added a comment to D4402: Merge #15324: test: Make bloom tests deterministic.

How do you test for determinism ?

Wed, Nov 6, 19:47
nakihito updated the diff for D4393: Abstract out seeding/extracting entropy into RNGState::MixExtract.

Fixed comment formatting.

Wed, Nov 6, 19:02
nakihito requested review of D4396: Sprinkle some sweet noexcepts over the RNG code.

Can you run some benchmark on this change, and add it to the test plan ?

Wed, Nov 6, 18:59
nakihito updated the test plan for D4396: Sprinkle some sweet noexcepts over the RNG code.
Wed, Nov 6, 18:56
nakihito updated the test plan for D4396: Sprinkle some sweet noexcepts over the RNG code.
Wed, Nov 6, 18:56
nakihito updated the test plan for D4396: Sprinkle some sweet noexcepts over the RNG code.
Wed, Nov 6, 17:50
nakihito updated the test plan for D4396: Sprinkle some sweet noexcepts over the RNG code.
Wed, Nov 6, 17:49
nakihito updated the test plan for D4396: Sprinkle some sweet noexcepts over the RNG code.
Wed, Nov 6, 17:49