Page MenuHomePhabricator

nakihito (Nico)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2018, 17:49 (77 w, 5 d)

Recent Activity

Today

nakihito updated the diff for D5010: Merge #9963: util: Properly handle errors during log message formatting.

Fixed comment formatting.

Sat, Jan 18, 00:58
nakihito created D5010: Merge #9963: util: Properly handle errors during log message formatting.
Sat, Jan 18, 00:46

Yesterday

nakihito updated the diff for D4418: Add unit tests for parse_name().

assert() -> BOOST_CHECK_EQUAL(). More clarification to comments. Added testing for a maximum sized label.

Fri, Jan 17, 20:31
nakihito added inline comments to D4418: Add unit tests for parse_name().
Fri, Jan 17, 20:31
nakihito committed rABC901fe9802776: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans) (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans)
Fri, Jan 17, 19:38
nakihito closed D4967: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans).
Fri, Jan 17, 19:38
nakihito committed rABCfd82b9f9f31c: Merge #13126: util: Add Clang thread safety annotations for variables guarded… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13126: util: Add Clang thread safety annotations for variables guarded…
Fri, Jan 17, 19:22
nakihito closed D4965: Merge #13126: util: Add Clang thread safety annotations for variables guarded by cs_args.
Fri, Jan 17, 19:22
nakihito requested review of D4967: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans).
Fri, Jan 17, 18:11

Thu, Jan 16

nakihito added a reviewer for D4965: Merge #13126: util: Add Clang thread safety annotations for variables guarded by cs_args: markblundeberg.
Thu, Jan 16, 23:35
nakihito requested review of D4965: Merge #13126: util: Add Clang thread safety annotations for variables guarded by cs_args.
Thu, Jan 16, 23:35
nakihito updated the test plan for D4967: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans).
Thu, Jan 16, 23:34
nakihito updated the summary of D4965: Merge #13126: util: Add Clang thread safety annotations for variables guarded by cs_args.
Thu, Jan 16, 23:27
nakihito requested review of D4967: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans).
Thu, Jan 16, 23:18
nakihito planned changes to D4967: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans).
Thu, Jan 16, 23:09
nakihito created D4967: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans).
Thu, Jan 16, 23:09
nakihito requested review of D4965: Merge #13126: util: Add Clang thread safety annotations for variables guarded by cs_args.
Thu, Jan 16, 23:06
nakihito accepted D4964: Merge #15507: test: Bump timeout on tests.
Thu, Jan 16, 22:52
nakihito planned changes to D4965: Merge #13126: util: Add Clang thread safety annotations for variables guarded by cs_args.
Thu, Jan 16, 22:49
nakihito created D4965: Merge #13126: util: Add Clang thread safety annotations for variables guarded by cs_args.
Thu, Jan 16, 22:49
nakihito committed rABC4a3dbc08a60d: Merge #13861: test: Add testing of value_ret for SelectCoinsBnB (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13861: test: Add testing of value_ret for SelectCoinsBnB
Thu, Jan 16, 21:30
nakihito closed D4963: Merge #13861: test: Add testing of value_ret for SelectCoinsBnB.
Thu, Jan 16, 21:30
nakihito committed rABC9b51434305f8: Merge #14056: Docs: Fix help message typo optiona -> optional (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14056: Docs: Fix help message typo optiona -> optional
Thu, Jan 16, 20:19
nakihito closed D4962: Merge #14056: Docs: Fix help message typo optiona -> optional.
Thu, Jan 16, 20:19
nakihito created D4963: Merge #13861: test: Add testing of value_ret for SelectCoinsBnB.
Thu, Jan 16, 19:56
nakihito created D4962: Merge #14056: Docs: Fix help message typo optiona -> optional.
Thu, Jan 16, 19:47
nakihito updated the diff for D4418: Add unit tests for parse_name().

Various variable name changes and more comments for better clarity. Removed Excess constants and variables. CreateDNSQuestion() -> CreateDNSQuestionNameField() because parse_name() finishes onces it reaches the end of the name field. First three tests collapsed into a singular test. Added assert() to check that nameFieldEndIndex is correct.

Thu, Jan 16, 01:22

Wed, Jan 15

nakihito committed rABCbb2c97c5c396: Merge #13429: Return the script type from Solver (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13429: Return the script type from Solver
Wed, Jan 15, 19:04
nakihito closed D4933: Merge #13429: Return the script type from Solver.
Wed, Jan 15, 19:04

Tue, Jan 14

nakihito abandoned D4944: Remove redundant library links for seeder.

Seems to be some sort of caching error on my machine.

Tue, Jan 14, 23:45
nakihito planned changes to D4944: Remove redundant library links for seeder.
Tue, Jan 14, 21:45
nakihito created D4944: Remove redundant library links for seeder.
Tue, Jan 14, 21:41
nakihito requested review of D4933: Merge #13429: Return the script type from Solver.

The change in src/rpc/rawtransaction.cpp is missing.

Tue, Jan 14, 19:40
nakihito requested review of D4933: Merge #13429: Return the script type from Solver.
Tue, Jan 14, 01:21
nakihito created D4933: Merge #13429: Return the script type from Solver.
Tue, Jan 14, 00:16
nakihito planned changes to D4933: Merge #13429: Return the script type from Solver.
Tue, Jan 14, 00:16
nakihito committed rABC24d55d31a9ff: Merge #12559: Avoid locking cs_main in some wallet RPC (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #12559: Avoid locking cs_main in some wallet RPC
Tue, Jan 14, 00:02
nakihito closed D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.
Tue, Jan 14, 00:02

Mon, Jan 13

nakihito committed rABC9f7d434f32ab: Add some braces to policy/policy.cpp (authored by nakihito).
Add some braces to policy/policy.cpp
Mon, Jan 13, 23:57
nakihito closed D4931: Add some braces to policy/policy.cpp.
Mon, Jan 13, 23:56
nakihito requested review of D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.
Mon, Jan 13, 22:24
nakihito created D4931: Add some braces to policy/policy.cpp.
Mon, Jan 13, 21:56
nakihito planned changes to D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.
Mon, Jan 13, 21:04
nakihito updated the diff for D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.

Rebased.

Mon, Jan 13, 21:04
nakihito planned changes to D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.
Mon, Jan 13, 21:03
nakihito created D4930: Merge #12559: Avoid locking cs_main in some wallet RPC.
Mon, Jan 13, 20:51
nakihito requested review of D4418: Add unit tests for parse_name().
Mon, Jan 13, 19:43
nakihito committed rABC5262a13f0300: Merge #13988: Add checks for settxfee reasonableness (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13988: Add checks for settxfee reasonableness
Mon, Jan 13, 18:30
nakihito closed D4894: Merge #13988: Add checks for settxfee reasonableness.
Mon, Jan 13, 18:30

Sat, Jan 11

nakihito requested review of D4894: Merge #13988: Add checks for settxfee reasonableness.
Sat, Jan 11, 02:17
nakihito updated the summary of D4894: Merge #13988: Add checks for settxfee reasonableness.
Sat, Jan 11, 02:17
nakihito planned changes to D4894: Merge #13988: Add checks for settxfee reasonableness.
Sat, Jan 11, 01:50
nakihito created D4894: Merge #13988: Add checks for settxfee reasonableness.
Sat, Jan 11, 01:50

Fri, Jan 10

nakihito accepted D4892: [CMAKE] Actually run the seeder tests.
Fri, Jan 10, 21:59
nakihito planned changes to D4418: Add unit tests for parse_name().
Fri, Jan 10, 21:21
nakihito updated the diff for D4418: Add unit tests for parse_name().

queryhex -> dnsQuestion and dnsMessage -> dnsQuestion. Removed one-time use variable labelLength. Also clarified some comments.

Fri, Jan 10, 21:21

Thu, Jan 9

nakihito updated the summary of D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).
Thu, Jan 9, 18:05
nakihito committed rABC08f879687543: Use best-fit strategy in Arena, now O(log(n)) instead O(n) (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Use best-fit strategy in Arena, now O(log(n)) instead O(n)
Thu, Jan 9, 18:04
nakihito closed D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).
Thu, Jan 9, 18:04

Tue, Jan 7

nakihito requested review of D4418: Add unit tests for parse_name().
Tue, Jan 7, 19:31
nakihito updated the diff for D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).

Rebased.

Tue, Jan 7, 19:26
nakihito committed rABC9ba3adacb152: Clean up more instances of create_transaction() (authored by nakihito).
Clean up more instances of create_transaction()
Tue, Jan 7, 19:00
nakihito closed D4849: Clean up more instances of create_transaction().
Tue, Jan 7, 19:00
nakihito created D4849: Clean up more instances of create_transaction().
Tue, Jan 7, 18:40

Mon, Jan 6

nakihito planned changes to D4418: Add unit tests for parse_name().
Mon, Jan 6, 22:10
nakihito updated the diff for D4418: Add unit tests for parse_name().

Refactored and simplified CreateDNSQuestion() to return a std::vector<uint8_t>.

Mon, Jan 6, 22:09
nakihito committed rABC8f56eb09fe22: [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput… (authored by Conor Scott <conor.r.scott.88@gmail.com>).
[Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput…
Mon, Jan 6, 17:45
nakihito closed D4822: [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object.
Mon, Jan 6, 17:45
nakihito committed rABCa719d2847528: [Tests] Cleanup extra instances of create_transaction (authored by Conor Scott <conor.r.scott.88@gmail.com>).
[Tests] Cleanup extra instances of create_transaction
Mon, Jan 6, 17:41
nakihito closed D4821: [Tests] Cleanup extra instances of create_transaction.
Mon, Jan 6, 17:41
nakihito committed rABC30f58f2909cf: [Tests] Rename create_tx and move to blocktools.py (authored by Conor Scott <conor.r.scott.88@gmail.com>).
[Tests] Rename create_tx and move to blocktools.py
Mon, Jan 6, 17:37
nakihito closed D4820: [Tests] Rename create_tx and move to blocktools.py.
Mon, Jan 6, 17:37
nakihito planned changes to D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).
Mon, Jan 6, 17:26
nakihito updated the diff for D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).

Rebased.

Mon, Jan 6, 17:26

Fri, Jan 3

nakihito planned changes to D3898: Use best-fit strategy in Arena, now O(log(n)) instead O(n).

Needs rebase.

Fri, Jan 3, 21:05
nakihito requested review of D4820: [Tests] Rename create_tx and move to blocktools.py.
Fri, Jan 3, 21:03
nakihito requested review of D4418: Add unit tests for parse_name().
Fri, Jan 3, 21:02
nakihito abandoned D3894: Merge #12737: Remove unnecessary NONNEGATIVE_SIGNED.
Fri, Jan 3, 20:45
nakihito planned changes to D4418: Add unit tests for parse_name().
Fri, Jan 3, 20:43
nakihito updated the diff for D4418: Add unit tests for parse_name().

Changed const uint8_t *messageEnd (a pointer) to const size_t messageEndIndex and removed unnecssary #include <iostream>.

Fri, Jan 3, 20:43
nakihito requested review of D4821: [Tests] Cleanup extra instances of create_transaction.
Fri, Jan 3, 20:19
nakihito updated the summary of D4821: [Tests] Cleanup extra instances of create_transaction.
Fri, Jan 3, 20:19
nakihito requested review of D4822: [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object.
Fri, Jan 3, 20:18
nakihito updated the summary of D4822: [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object.
Fri, Jan 3, 01:04
nakihito updated the summary of D4821: [Tests] Cleanup extra instances of create_transaction.
Fri, Jan 3, 01:04

Thu, Jan 2

nakihito planned changes to D4822: [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object.
Thu, Jan 2, 21:49
nakihito created D4822: [Tests] Cleanup feature_block.py, remove unnecessary PreviousSpendableOutput object.
Thu, Jan 2, 21:49
nakihito planned changes to D4821: [Tests] Cleanup extra instances of create_transaction.
Thu, Jan 2, 21:48
nakihito created D4821: [Tests] Cleanup extra instances of create_transaction.
Thu, Jan 2, 21:48
nakihito planned changes to D4820: [Tests] Rename create_tx and move to blocktools.py.
Thu, Jan 2, 21:47
nakihito created D4820: [Tests] Rename create_tx and move to blocktools.py.
Thu, Jan 2, 21:47

Tue, Dec 31

nakihito accepted D4806: Fix nits in check-keys.sh.
Tue, Dec 31, 21:09
nakihito accepted D4805: Fix missing newline at end of keys file.
Tue, Dec 31, 21:04

Mon, Dec 23

nakihito committed rABCba2504cc305f: Merge #13791: gui: Reject dialogs if key escape is pressed (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13791: gui: Reject dialogs if key escape is pressed
Mon, Dec 23, 18:59
nakihito closed D4792: Merge #13791: gui: Reject dialogs if key escape is pressed.
Mon, Dec 23, 18:58

Sat, Dec 21

nakihito accepted D4793: Bump version to 0.20.10.
Sat, Dec 21, 06:43

Fri, Dec 20

nakihito accepted D4793: Bump version to 0.20.10.
Fri, Dec 20, 20:45
nakihito committed rABCaee176d6dc2c: Merge #13844: doc: correct the help output for -prune (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13844: doc: correct the help output for -prune
Fri, Dec 20, 19:39
nakihito closed D4775: Merge #13844: doc: correct the help output for -prune.
Fri, Dec 20, 19:39
nakihito committed rABC6399a3a3fb2f: Merge #13412: Make ReceivedBlockTransactions return void (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13412: Make ReceivedBlockTransactions return void
Fri, Dec 20, 19:27