Page MenuHomePhabricator

nakihito (Nico)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2018, 17:49 (43 w, 2 d)

Recent Activity

Today

nakihito updated the diff for D3040: Merge #10431: Prevent shadowing the global dustRelayFee.

Rebased.

Tue, May 21, 00:00

Yesterday

nakihito updated the summary of D3039: Consensus: Minimal way to move dust out of consensus.
Mon, May 20, 23:52
nakihito requested review of D3049: Merge #12333: Make CWallet::ListCoins atomic.

Fixed summary to reflect Fabien's suggestion.

Mon, May 20, 17:52
nakihito updated the summary of D3049: Merge #12333: Make CWallet::ListCoins atomic.
Mon, May 20, 17:50

Fri, May 17

Herald added a reviewer for D3067: Merge #12564: [arith_uint256] Avoid unnecessary this-copy using prefix operator: Restricted Project.
Fri, May 17, 20:34
Herald added a reviewer for D3066: Merge #12182: Remove useless string initializations: Restricted Project.
Fri, May 17, 20:22
nakihito updated the diff for D3039: Consensus: Minimal way to move dust out of consensus.

Used linter to split up Dust comment.

Fri, May 17, 17:27

Wed, May 15

nakihito requested review of D3024: [tests] Remove unused variables.
Wed, May 15, 01:00
Herald added a reviewer for D3049: Merge #12333: Make CWallet::ListCoins atomic: Restricted Project.
Wed, May 15, 00:32

Tue, May 14

nakihito updated the diff for D3039: Consensus: Minimal way to move dust out of consensus.

Fixed comment formatting and removed references to segwit.

Tue, May 14, 22:32
Herald added a reviewer for D3044: Merge #11385: Remove some unused functions and methods: Restricted Project.
Tue, May 14, 18:24
nakihito added a comment to D3040: Merge #10431: Prevent shadowing the global dustRelayFee.
In D3040#71594, @Fabien wrote:

I get the warnings, which compiler do you use ?

Tue, May 14, 17:49
nakihito added a comment to D3040: Merge #10431: Prevent shadowing the global dustRelayFee.
In D3040#71594, @Fabien wrote:

I get the warnings, which compiler do you use ?

Tue, May 14, 17:44
nakihito added a comment to D3039: Consensus: Minimal way to move dust out of consensus.

This is actually 1/2 commits, but the second one doesn't seem very applicable because of changes made in the past: https://reviews.bitcoinabc.org/rABC87d967d48f2702d8f7972a1b43ddae0054640836

Tue, May 14, 01:53
nakihito updated the test plan for D3038: Merge #10280: [test] Unit test amount.h/amount.cpp.
Tue, May 14, 01:50
nakihito updated the test plan for D3039: Consensus: Minimal way to move dust out of consensus.
Tue, May 14, 01:49
nakihito added a comment to D3040: Merge #10431: Prevent shadowing the global dustRelayFee.

The issue core had doesn't actually occur in our code base because of some other changes made before, how renaming the arguments should help to prevent confusion and will hopefully keep merge conflicts in future backports to a minimum.

Tue, May 14, 01:49
nakihito updated the test plan for D3040: Merge #10431: Prevent shadowing the global dustRelayFee.
Tue, May 14, 01:47
Herald added a reviewer for D3040: Merge #10431: Prevent shadowing the global dustRelayFee: Restricted Project.
Tue, May 14, 01:46
Herald added a reviewer for D3039: Consensus: Minimal way to move dust out of consensus: Restricted Project.
Tue, May 14, 01:32
nakihito updated the diff for D3038: Merge #10280: [test] Unit test amount.h/amount.cpp.

Re-added full constructor comment.

Tue, May 14, 00:39
nakihito updated the summary of D3038: Merge #10280: [test] Unit test amount.h/amount.cpp.
Tue, May 14, 00:37

Mon, May 13

Herald added a reviewer for D3038: Merge #10280: [test] Unit test amount.h/amount.cpp: Restricted Project.
Mon, May 13, 19:38
nakihito updated the test plan for D3023: [tests] Remove unused and duplicate imports.
Mon, May 13, 17:14
nakihito updated the test plan for D3024: [tests] Remove unused variables.
Mon, May 13, 17:14
nakihito updated the diff for D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..

Added {}.

Mon, May 13, 17:11
nakihito updated the test plan for D3023: [tests] Remove unused and duplicate imports.
Mon, May 13, 17:03
nakihito added a comment to D3024: [tests] Remove unused variables.

Sorry, I must've forgotten to put the dependency in. Added now.

Mon, May 13, 00:10
nakihito updated the summary of D3024: [tests] Remove unused variables.
Mon, May 13, 00:10

Fri, May 10

Herald added a reviewer for D3024: [tests] Remove unused variables: Restricted Project.
Fri, May 10, 22:09
Herald added a reviewer for D3023: [tests] Remove unused and duplicate imports: Restricted Project.
Fri, May 10, 21:41
Herald added a reviewer for D3022: Merge #10045: [trivial] Fix typos in comments: Restricted Project.
Fri, May 10, 21:12
nakihito updated the diff for D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..

Previously mentioned issue was resolved with Fabien's suggestion of using .front().

Fri, May 10, 18:06
nakihito updated the diff for D2983: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment.

Removed changes in txdb.h.

Fri, May 10, 17:53

Wed, May 8

Herald added a reviewer for D2983: Merge #11351: Refactor: Modernize disallowed copy constructors/assignment: Restricted Project.
Wed, May 8, 02:10
Herald added a reviewer for D2982: Merge #11155: Trivial: Documentation fixes for CVectorWriter ctors: Restricted Project.
Wed, May 8, 01:15
Herald added a reviewer for D2981: Merge #12283: Fix typos: Restricted Project.
Wed, May 8, 00:11

Tue, May 7

nakihito abandoned D2975: Merge READWRITEMANY into READWRITE.

Looks like @markblundeberg got to this before me. See T634.

Tue, May 7, 22:02
Herald added a reviewer for D2975: Merge READWRITEMANY into READWRITE: Restricted Project.
Tue, May 7, 21:47
nakihito added inline comments to D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..
Tue, May 7, 20:00
nakihito requested review of D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..
Tue, May 7, 19:59
nakihito planned changes to D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead..
Tue, May 7, 03:54
Herald added a reviewer for D2964: Merge #9804: Fixes subscript 0 (&var[0]) where should use (var.data()) instead.: Restricted Project.
Tue, May 7, 03:45
nakihito updated the diff for D2950: Merge #9693: Prevent integer overflow in ReadVarInt..

Removed else.

Tue, May 7, 00:23

Mon, May 6

Herald added a reviewer for D2950: Merge #9693: Prevent integer overflow in ReadVarInt.: Restricted Project.
Mon, May 6, 23:46
nakihito added a parent task for T583: Backport Core PR 13190: T637: Backport Core PR 14168: Remove ENABLE_WALLET from libbitcoin_server.a.
Mon, May 6, 16:06 · Backport, Bootcamp, Restricted Project
nakihito added a subtask for T637: Backport Core PR 14168: Remove ENABLE_WALLET from libbitcoin_server.a: T583: Backport Core PR 13190.
Mon, May 6, 16:06 · Backport, Restricted Project
nakihito triaged T637: Backport Core PR 14168: Remove ENABLE_WALLET from libbitcoin_server.a as Normal priority.
Mon, May 6, 16:05 · Backport, Restricted Project
nakihito placed T590: Backport Core 14555: Move util files to new directory up for grabs.
Mon, May 6, 15:49 · Backport, Restricted Project
nakihito abandoned D2894: Fix memory leaks in qt/guiutil.cpp.

It does looks like @CCulianu 's patch and the patch you backport where intended to fix the same issue. The mix of both that you are proposing here makes zero sense.

Mon, May 6, 15:40

Sat, May 4

Herald added a reviewer for D2920: Incremented version number to 0.19.6.: Restricted Project.
Sat, May 4, 00:35

Fri, May 3

nakihito triaged T629: Backport Core PR 11372: Address encoding cleanup as High priority.
Fri, May 3, 19:07 · Backport, Restricted Project
nakihito updated the diff for D2894: Fix memory leaks in qt/guiutil.cpp.

Typo.

Fri, May 3, 18:18
nakihito updated the diff for D2894: Fix memory leaks in qt/guiutil.cpp.

Restored CFRetain() call.

Fri, May 3, 18:16

Thu, May 2

nakihito updated the diff for D2847: Fix typos..

Rebased.

Thu, May 2, 00:56

Wed, May 1

nakihito added a comment to D2894: Fix memory leaks in qt/guiutil.cpp.

Please investigate why the build is failing and why so much of the backport appears to already be in our codebase.

Wed, May 1, 00:00

Tue, Apr 30

Herald added a reviewer for D2894: Fix memory leaks in qt/guiutil.cpp: Restricted Project.
Tue, Apr 30, 22:56
nakihito triaged T622: Backport Core PR 11567: Fix memory leaks in qt/guiutil.cpp as Low priority.
Tue, Apr 30, 22:51 · Restricted Project, Backport
nakihito placed T619: Backport Core PR 11476: Avoid opening copied wallet databases simultaneously up for grabs.
Tue, Apr 30, 21:52 · Backport
nakihito triaged T621: Backport Core PR 9657: Improve rpc-tests.py as Normal priority.
Tue, Apr 30, 21:52 · Backport
nakihito placed T620: Backport Core PR 10849: Multiwallet: simplest endpoint support up for grabs.
Tue, Apr 30, 21:07 · Backport
nakihito triaged T620: Backport Core PR 10849: Multiwallet: simplest endpoint support as Normal priority.
Tue, Apr 30, 21:04 · Backport
nakihito triaged T619: Backport Core PR 11476: Avoid opening copied wallet databases simultaneously as Normal priority.
Tue, Apr 30, 20:49 · Backport
nakihito added a comment to T616: Backport Core PR 12477: test: Plug memory leaks and stack-use-after-scope.

The change in test_bitcoin.cpp is causing make check to fail. Specifically, it appears to be failing in avalanche_tests.cpp around lines 228 and/or 251.

Tue, Apr 30, 20:31 · Backport
nakihito updated the diff for D2846: Do not allow users to get keys from keypool without reserving them.

Forgot to squash changes.

Tue, Apr 30, 01:36
nakihito updated the diff for D2846: Do not allow users to get keys from keypool without reserving them.

Broke up long string into multiple lines.

Tue, Apr 30, 01:32

Mon, Apr 29

nakihito triaged T616: Backport Core PR 12477: test: Plug memory leaks and stack-use-after-scope as Low priority.
Mon, Apr 29, 21:55 · Backport
nakihito closed T615: Backport Core PR 10837: Fix resource leak on error in GetDevURandom as Resolved.

This was actually already completed.

Mon, Apr 29, 21:52 · Backport
nakihito triaged T615: Backport Core PR 10837: Fix resource leak on error in GetDevURandom as Low priority.
Mon, Apr 29, 21:48 · Backport
nakihito updated the task description for T610: Backport Core PR 11492: [wallet] Fix leak in CDB constructor.
Mon, Apr 29, 21:43 · Backport
nakihito updated the task description for T611: Backport Core PR 10521: Limit variable scope.
Mon, Apr 29, 21:43 · Backport
nakihito triaged T611: Backport Core PR 10521: Limit variable scope as Low priority.
Mon, Apr 29, 21:15 · Backport
nakihito triaged T610: Backport Core PR 11492: [wallet] Fix leak in CDB constructor as Low priority.
Mon, Apr 29, 18:25 · Backport
nakihito added inline comments to D2846: Do not allow users to get keys from keypool without reserving them.
Mon, Apr 29, 17:21

Fri, Apr 26

nakihito closed T524: Improve IBD script to support arbitrary params as Resolved.
Fri, Apr 26, 22:03 · Bootcamp, Restricted Project
nakihito updated the diff for D2846: Do not allow users to get keys from keypool without reserving them.

Added comment to <rpc/server> include to note it can be removed once the deprecated command is removed.

Fri, Apr 26, 18:55
nakihito updated the diff for D2846: Do not allow users to get keys from keypool without reserving them.

Added rpc deprecation check to make sure address isn't removed twice in certain situations.

Fri, Apr 26, 18:24

Tue, Apr 23

nakihito updated the diff for D2846: Do not allow users to get keys from keypool without reserving them.

typo

Tue, Apr 23, 23:04
nakihito updated the diff for D2846: Do not allow users to get keys from keypool without reserving them.

Changed location of deprecation check, removed excess deprecation checks, added new test case.

Tue, Apr 23, 22:55
nakihito added a comment to D2846: Do not allow users to get keys from keypool without reserving them.

Also making more changes as recommended by Fabien.

Tue, Apr 23, 20:15
nakihito updated the diff for D2846: Do not allow users to get keys from keypool without reserving them.

Deprecated -reserveChangeKey option rather than removing it. Changed deprecation comment to reflect next major update. Rebased.

Tue, Apr 23, 18:51

Apr 21 2019

nakihito updated the diff for D2847: Fix typos..

Fixed missed typo.

Apr 21 2019, 18:35
nakihito updated the diff for D2846: Do not allow users to get keys from keypool without reserving them.

Added release note and adjusted version number depreciation note in rpcwallet.cpp.

Apr 21 2019, 18:24

Apr 20 2019

Herald added a reviewer for D2847: Fix typos.: Restricted Project.
Apr 20 2019, 01:59
Herald added a reviewer for D2846: Do not allow users to get keys from keypool without reserving them: Restricted Project.
Apr 20 2019, 01:32

Apr 19 2019

nakihito triaged T609: Backport Core PR 10784: Do not allow users to get keys from keypool without reserving them as Low priority.
Apr 19 2019, 23:36 · Backport
nakihito triaged T608: Backport Core PR 10956: Fix typos as Low priority.
Apr 19 2019, 23:35 · Backport
nakihito added a parent task for T602: Backport Core PR 15288: Remove wallet -> node global function calls: T601: Backport Core PR 10973: Refactor: separate wallet from node.
Apr 19 2019, 21:37 · Restricted Project, Backport
nakihito added a subtask for T601: Backport Core PR 10973: Refactor: separate wallet from node: T602: Backport Core PR 15288: Remove wallet -> node global function calls.
Apr 19 2019, 21:37 · Restricted Project, Backport
nakihito added a comment to D2822: Remove direct bitcoin calls from qt/bantablemodel.cpp.

interfaces -> interfaces

Apr 19 2019, 20:23
nakihito added a parent task for T417: Backport PR10244 from core: T598: Backport Core PR 12909: wallet: Make fee settings to be non-static members.
Apr 19 2019, 18:54 · Backport
nakihito added a subtask for T598: Backport Core PR 12909: wallet: Make fee settings to be non-static members: T417: Backport PR10244 from core.
Apr 19 2019, 18:54 · Restricted Project, Backport
nakihito closed T554: Backport Core PR 11499 as Resolved.
Apr 19 2019, 18:39 · Backport, Bootcamp, Restricted Project
nakihito updated the diff for D2766: Add Sent and Received information to the debug menu peer list.

Added trailing comma to ColumnIndex enum.

Apr 19 2019, 18:11

Apr 16 2019

nakihito closed T606: Backport Core PR 11017, a subtask of T604: Backport Core PR 11904, as Resolved.
Apr 16 2019, 21:07 · Backport
nakihito closed T606: Backport Core PR 11017 as Resolved.
Apr 16 2019, 21:07 · Backport
nakihito updated the test plan for D2807: [wallet] Close DB on error..
Apr 16 2019, 19:41
nakihito updated the test plan for D2807: [wallet] Close DB on error..
Apr 16 2019, 19:38
nakihito updated the test plan for D2807: [wallet] Close DB on error..
Apr 16 2019, 19:31
Herald added a reviewer for D2807: [wallet] Close DB on error.: Restricted Project.
Apr 16 2019, 19:30