Page MenuHomePhabricator

nakihito (Nico)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 22 2018, 17:49 (89 w, 4 d)

Recent Activity

Yesterday

nakihito planned changes to D5682: Add a constant for the maximum addrs that can be received.
Thu, Apr 9, 22:35
nakihito updated the diff for D5682: Add a constant for the maximum addrs that can be received.

Use a name of the constant that is relevent to the seeder.

Thu, Apr 9, 22:35
nakihito planned changes to D5686: Implement banning logic for Seeder.
Thu, Apr 9, 22:01
nakihito updated the diff for D5686: Implement banning logic for Seeder.

Fixed text plan to include IBD, renamed some variables, and added timeFirstFound.

Thu, Apr 9, 22:01
nakihito updated the test plan for D5686: Implement banning logic for Seeder.
Thu, Apr 9, 21:58
nakihito updated the test plan for D5686: Implement banning logic for Seeder.
Thu, Apr 9, 21:52
nakihito updated the test plan for D5686: Implement banning logic for Seeder.
Thu, Apr 9, 02:33

Wed, Apr 8

nakihito added inline comments to D5686: Implement banning logic for Seeder.
Wed, Apr 8, 19:40
nakihito updated the summary of D5380: Seeder requires seeds to have block after most recent checkpoint in its chain.
Wed, Apr 8, 19:37
nakihito planned changes to D5380: Seeder requires seeds to have block after most recent checkpoint in its chain.
Wed, Apr 8, 19:36
nakihito updated the diff for D5380: Seeder requires seeds to have block after most recent checkpoint in its chain.

Addressed critiques.

Wed, Apr 8, 19:36
nakihito planned changes to D5686: Implement banning logic for Seeder.
Wed, Apr 8, 19:33
nakihito created D5686: Implement banning logic for Seeder.
Wed, Apr 8, 19:33
nakihito planned changes to D5682: Add a constant for the maximum addrs that can be received.
Wed, Apr 8, 01:40
nakihito created D5682: Add a constant for the maximum addrs that can be received.
Wed, Apr 8, 01:40

Tue, Apr 7

nakihito committed rSTAGING8d1c05b523e6: Merge #15485: add rpc_misc.py, mv test getmemoryinfo, add test mallocinfo (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15485: add rpc_misc.py, mv test getmemoryinfo, add test mallocinfo
Tue, Apr 7, 23:33
nakihito committed rSTAGINGeadcc3e772d6: Add version number to the seeder (authored by nakihito).
Add version number to the seeder
Tue, Apr 7, 23:33
nakihito committed rSTAGINGdee5e745ae59: Merge #14813: qa: Add wallet_encryption error tests (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14813: qa: Add wallet_encryption error tests
Tue, Apr 7, 23:30
nakihito committed rSTAGINGa951129beaab: Fix usehd release number errors in release notes (authored by nakihito).
Fix usehd release number errors in release notes
Tue, Apr 7, 23:29
nakihito committed rSTAGING31e56fd728b9: Remove rules argument from getblocktemplate help (authored by nakihito).
Remove rules argument from getblocktemplate help
Tue, Apr 7, 23:29
nakihito committed rSTAGING3a84ae8b0c04: Partial Merge #14726: Use RPCHelpMan for all RPCs (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Partial Merge #14726: Use RPCHelpMan for all RPCs
Tue, Apr 7, 23:27
nakihito committed rSTAGING58a87f61a851: Fix setexcessiveblock rpc help text (authored by nakihito).
Fix setexcessiveblock rpc help text
Tue, Apr 7, 23:27
nakihito committed rSTAGING50a1fbc83f20: Merge #14291: wallet: Add ListWalletDir utility function (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14291: wallet: Add ListWalletDir utility function
Tue, Apr 7, 23:25
nakihito committed rSTAGING3cac51b8198f: Add some unit tests for write_name() for seeder (authored by nakihito).
Add some unit tests for write_name() for seeder
Tue, Apr 7, 23:25
nakihito committed rSTAGING92eafd93e7af: Some left overs from PR12490 (authored by nakihito).
Some left overs from PR12490
Tue, Apr 7, 23:25
nakihito committed rSTAGING481ac5a90d78: Merge #14208: [build] Actually remove ENABLE_WALLET (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14208: [build] Actually remove ENABLE_WALLET
Tue, Apr 7, 23:25
nakihito committed rSTAGING4d562db5ae8b: Merge #14718: Remove unreferenced boost headers (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14718: Remove unreferenced boost headers
Tue, Apr 7, 23:24
nakihito committed rSTAGING9d64eabb34a7: Merge #14373: Consistency fixes for RPC descriptions (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14373: Consistency fixes for RPC descriptions
Tue, Apr 7, 23:24
nakihito committed rSTAGINGdfe55e6bcfef: Release notes for D5507 (authored by nakihito).
Release notes for D5507
Tue, Apr 7, 23:22
nakihito committed rSTAGING1d2c6a4bffa9: Merge #14411: [wallet] Restore ability to list incoming transactions by label (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14411: [wallet] Restore ability to list incoming transactions by label
Tue, Apr 7, 23:22
nakihito committed rSTAGING58be0d7ee902: Merge #14244: amount: Move CAmount CENT to unit test header (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14244: amount: Move CAmount CENT to unit test header
Tue, Apr 7, 23:21
nakihito committed rSTAGING6930534e47a3: Merge #14282: [wallet] Remove -usehd (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14282: [wallet] Remove -usehd
Tue, Apr 7, 23:21
nakihito committed rSTAGING2300ba031559: Merge #14215: [qa] Use correct python index slices in example test (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14215: [qa] Use correct python index slices in example test
Tue, Apr 7, 23:21
nakihito committed rSTAGINGc53dd703688c: Merge #14207: doc: `-help-debug` implies `-help` (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14207: doc: `-help-debug` implies `-help`
Tue, Apr 7, 23:21
nakihito committed rSTAGING9754edd01101: Merge #14013: [doc] Add new regtest ports in man following #10825 ports… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14013: [doc] Add new regtest ports in man following #10825 ports…
Tue, Apr 7, 23:21
nakihito committed rSTAGING939971dd5e02: Add enum for parse_name() return value (authored by nakihito).
Add enum for parse_name() return value
Tue, Apr 7, 23:21
nakihito committed rSTAGING0da65ecee208: Add constants to dns.h (authored by nakihito).
Add constants to dns.h
Tue, Apr 7, 23:20
nakihito committed rSTAGINGf8b0f9874998: Add << operator overload for PeerMessagingState (authored by nakihito).
Add << operator overload for PeerMessagingState
Tue, Apr 7, 23:20
nakihito committed rSTAGING411bd9b97e91: Adds PeerMessagingState enum to seeder/bitcoin.* (authored by nakihito).
Adds PeerMessagingState enum to seeder/bitcoin.*
Tue, Apr 7, 23:19
nakihito committed rSTAGING757f9f4b9cbc: Simplify max query name length check in parse_name() (authored by nakihito).
Simplify max query name length check in parse_name()
Tue, Apr 7, 23:19
nakihito committed rSTAGING69f1b72ce00d: Nits to streams.h (authored by nakihito).
Nits to streams.h
Tue, Apr 7, 23:17
nakihito committed rSTAGING23ee283f519a: [wallet] Remove CAccount and Update zapwallettxes comment (authored by nakihito).
[wallet] Remove CAccount and Update zapwallettxes comment
Tue, Apr 7, 23:17
nakihito committed rSTAGING23fe7e7d5209: [wallet] Remove strFromAccount and strSentAccount (authored by nakihito).
[wallet] Remove strFromAccount and strSentAccount
Tue, Apr 7, 23:16
nakihito committed rSTAGING43dc709045b2: [wallet] Remove fromAccount argument from CommitTransaction() (authored by nakihito).
[wallet] Remove fromAccount argument from CommitTransaction()
Tue, Apr 7, 23:16
nakihito committed rSTAGING224a4cd81747: [wallet] Delete unused account functions (authored by nakihito).
[wallet] Delete unused account functions
Tue, Apr 7, 23:16
nakihito committed rSTAGINGaf67f6702662: [wallet] Remove CAccountingEntry class (authored by nakihito).
[wallet] Remove CAccountingEntry class
Tue, Apr 7, 23:16
nakihito committed rSTAGING5ec97bc2a80f: [wallet] Remove ListAccountCreditDebit() (authored by nakihito).
[wallet] Remove ListAccountCreditDebit()
Tue, Apr 7, 23:16
nakihito committed rSTAGINGae17dc97a0a7: [wallet] Don't read acentry key-values from wallet on load. (authored by nakihito).
[wallet] Don't read acentry key-values from wallet on load.
Tue, Apr 7, 23:15
nakihito committed rSTAGINGff6fdf66f74c: [wallet] Don't rewrite accounting entries when reordering wallet transactions… (authored by nakihito).
[wallet] Don't rewrite accounting entries when reordering wallet transactions…
Tue, Apr 7, 23:15
nakihito committed rSTAGING557e4143f82f: [wallet] Remove AddAccountingEntry() (authored by nakihito).
[wallet] Remove AddAccountingEntry()
Tue, Apr 7, 23:15
nakihito committed rSTAGINGff8832ec366c: [wallet] Remove CWallet::ListAccountCreditDebit() and GetAccountCreditDebit() (authored by nakihito).
[wallet] Remove CWallet::ListAccountCreditDebit() and GetAccountCreditDebit()
Tue, Apr 7, 23:14
nakihito committed rSTAGING6c13b2f1e938: [wallet] Remove 'account' argument from GetLegacyBalance() (authored by nakihito).
[wallet] Remove 'account' argument from GetLegacyBalance()
Tue, Apr 7, 23:14
nakihito committed rSTAGING65cbc5e408c3: [wallet] Remove AccountMove() (authored by nakihito).
[wallet] Remove AccountMove()
Tue, Apr 7, 23:14
nakihito committed rSTAGING61fa035c75d7: Merge #13265: wallet: Exit SyncMetaData if there are no transactions to sync (authored by nakihito).
Merge #13265: wallet: Exit SyncMetaData if there are no transactions to sync
Tue, Apr 7, 23:14
nakihito committed rSTAGING1efbec18e07d: Merge #11269: [Mempool] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #11269: [Mempool] CTxMemPoolEntry::UpdateAncestorState: modifySiagOps…
Tue, Apr 7, 23:14
nakihito committed rSTAGING5f7aec629b38: Merge #14023: Remove accounts rpcs (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14023: Remove accounts rpcs
Tue, Apr 7, 23:14
nakihito committed rSTAGING7ff1309f12ed: Merge #13264: [qt] Satoshi unit (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #13264: [qt] Satoshi unit
Tue, Apr 7, 23:14
nakihito committed rSTAGINGe26ede2851be: Move code in seeder_test.cpp close to where it is used (authored by nakihito).
Move code in seeder_test.cpp close to where it is used
Tue, Apr 7, 23:14
nakihito committed rSTAGINGd50368de0819: Rename seeder_tests to p2p_messaging_tests (authored by nakihito).
Rename seeder_tests to p2p_messaging_tests
Tue, Apr 7, 23:13
nakihito committed rSTAGINGb9c35cfd6406: Make parse_name() fail when passed buffer size = 0 (authored by nakihito).
Make parse_name() fail when passed buffer size = 0
Tue, Apr 7, 23:13
nakihito committed rSTAGING9c34988e63da: Label length unit tests for parse_name() (authored by nakihito).
Label length unit tests for parse_name()
Tue, Apr 7, 23:12
nakihito committed rSTAGING1c0566ce001c: Enforce maximum name length for parse_name() and add unit tests (authored by nakihito).
Enforce maximum name length for parse_name() and add unit tests
Tue, Apr 7, 23:12
nakihito committed rSTAGING9fd728bbafd3: Add simple unit tests for parse_name() (authored by nakihito).
Add simple unit tests for parse_name()
Tue, Apr 7, 23:12
nakihito committed rSTAGINGd357fa5a29b3: scripted-diff: replace chainActive -> ::ChainActive() (authored by nakihito).
scripted-diff: replace chainActive -> ::ChainActive()
Tue, Apr 7, 23:12
nakihito committed rSTAGING8b0ad8e95656: refactoring: introduce unused ChainActive() (authored by James O'Beirne <james.obeirne@gmail.com>).
refactoring: introduce unused ChainActive()
Tue, Apr 7, 23:12
nakihito committed rSTAGINGf99b18b3f609: rename: CChainState.chainActive -> m_chain (authored by James O'Beirne <james.obeirne@gmail.com>).
rename: CChainState.chainActive -> m_chain
Tue, Apr 7, 23:10
nakihito committed rSTAGING0c9c1fa7b21a: Remove GotVersion() (authored by nakihito).
Remove GotVersion()
Tue, Apr 7, 23:08
nakihito committed rSTAGINGed4ca8ee11f0: Add unit tests for CSeederNode::ProcessMessage() (authored by nakihito).
Add unit tests for CSeederNode::ProcessMessage()
Tue, Apr 7, 23:07
nakihito committed rSTAGING1c4b1649e462: Merge #12035: [qt] change µBTC to bits (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
Merge #12035: [qt] change µBTC to bits
Tue, Apr 7, 23:04
nakihito committed rSTAGINGe3f2849c16f4: Merge #14307: Consolidate redundant implementations of ParseHashStr (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14307: Consolidate redundant implementations of ParseHashStr
Tue, Apr 7, 23:04
nakihito committed rSTAGING07cc225cf5ab: Merge #13424: Consistently validate txid / blockhash length and encoding in rpc… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13424: Consistently validate txid / blockhash length and encoding in rpc…
Tue, Apr 7, 23:04
nakihito committed rSTAGINGe584d180ab73: Merge #14460: tests: Improve 'CAmount' tests (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Merge #14460: tests: Improve 'CAmount' tests
Tue, Apr 7, 23:01
nakihito committed rSTAGING925cb24b97b1: Merge #12079: Improve prioritisetransaction test coverage (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12079: Improve prioritisetransaction test coverage
Tue, Apr 7, 23:01
nakihito committed rSTAGING937a91eb9ebc: Merge #14679: importmulti: Don't add internal addresses to address book (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14679: importmulti: Don't add internal addresses to address book
Tue, Apr 7, 23:01
nakihito committed rSTAGING30527d21d9fe: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC
Tue, Apr 7, 23:00
nakihito committed rSTAGING054899250f31: Merge #14720: rpc: Correctly name arguments (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14720: rpc: Correctly name arguments
Tue, Apr 7, 23:00
nakihito committed rSTAGING48916ac8540e: Merge #13152: [rpc] Add getnodeaddresses RPC command (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13152: [rpc] Add getnodeaddresses RPC command
Tue, Apr 7, 22:59
nakihito committed rSTAGINGddcbef8bf4b3: Merge #14310: [wallet] Ensure wallet is unlocked before signing (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14310: [wallet] Ensure wallet is unlocked before signing
Tue, Apr 7, 22:58
nakihito committed rSTAGINGd2436be68d5e: Merge #14236: qa: generate --> generatetoaddress change to allow tests run… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14236: qa: generate --> generatetoaddress change to allow tests run…
Tue, Apr 7, 22:58
nakihito committed rSTAGINGf40d38e63e1c: Update copyright for various files (authored by nakihito).
Update copyright for various files
Tue, Apr 7, 22:54
nakihito committed rSTAGINGc7af8f0ab549: Merge #13823: qa: quote path in authproxy for external multiwallets (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13823: qa: quote path in authproxy for external multiwallets
Tue, Apr 7, 22:54
nakihito committed rSTAGING4dfa4724abcf: Merge #14180: qa: Run all tests even if wallet is not compiled (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14180: qa: Run all tests even if wallet is not compiled
Tue, Apr 7, 22:54
nakihito committed rSTAGINGea0cb385d243: Merge #14179: qa: Fixups to "Run all tests even if wallet is not compiled" (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14179: qa: Fixups to "Run all tests even if wallet is not compiled"
Tue, Apr 7, 22:54
nakihito committed rSTAGING651157d3ffa6: Update copyright_header.py to not duplicate parts of the header (authored by nakihito).
Update copyright_header.py to not duplicate parts of the header
Tue, Apr 7, 22:54
nakihito committed rSTAGING1b1bc9407ad7: Merge #14094: refactoring: Remove unreferenced local variables (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14094: refactoring: Remove unreferenced local variables
Tue, Apr 7, 22:51
nakihito committed rSTAGING0f47175d0df5: Merge #14209/#17218: logging: Replace LogPrintf macro with regular function (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14209/#17218: logging: Replace LogPrintf macro with regular function
Tue, Apr 7, 22:47
nakihito committed rSTAGING2d094cbae708: Merge #13938: refactoring: Cleanup StartRest() (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13938: refactoring: Cleanup StartRest()
Tue, Apr 7, 22:47
nakihito requested review of D5380: Seeder requires seeds to have block after most recent checkpoint in its chain.

Updated test plan.

Tue, Apr 7, 22:45
nakihito updated the test plan for D5380: Seeder requires seeds to have block after most recent checkpoint in its chain.
Tue, Apr 7, 22:45
nakihito committed rSTAGING0ee48883f58d: Merge #13967: [walletdb] don't report minversion wallet entry as unknown (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13967: [walletdb] don't report minversion wallet entry as unknown
Tue, Apr 7, 22:44
nakihito committed rSTAGING9788c101a9c0: Merge #13913: qa: Remove redundant checkmempool/checkblockindex extra_args (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13913: qa: Remove redundant checkmempool/checkblockindex extra_args
Tue, Apr 7, 22:43
nakihito committed rSTAGINGc6c583bedc22: Merge #13948: trivial: Removes unsed `CBloomFilter` constructor. (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13948: trivial: Removes unsed `CBloomFilter` constructor.
Tue, Apr 7, 22:43
nakihito planned changes to D5380: Seeder requires seeds to have block after most recent checkpoint in its chain.
Tue, Apr 7, 22:42
nakihito updated the diff for D5380: Seeder requires seeds to have block after most recent checkpoint in its chain.

Seeder requests addrs before requesting headers from the connected node.

Tue, Apr 7, 22:42
nakihito committed rSTAGING8043115492c8: Merge #13982: refactor: use fs:: over boost::filesystem:: (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13982: refactor: use fs:: over boost::filesystem::
Tue, Apr 7, 22:38
nakihito committed rSTAGINGa5b58641cce4: Add last missing part from PR12954 (authored by Pieter Wuille <pieter.wuille@gmail.com>).
Add last missing part from PR12954
Tue, Apr 7, 22:37
nakihito committed rSTAGINGe87be9ab6925: Merge #9963: util: Properly handle errors during log message formatting (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #9963: util: Properly handle errors during log message formatting
Tue, Apr 7, 22:36
nakihito committed rSTAGING901fe9802776: Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans) (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14108: tests: Add missing locking annotations and locks (g_cs_orphans)
Tue, Apr 7, 22:33
nakihito committed rSTAGINGfd82b9f9f31c: Merge #13126: util: Add Clang thread safety annotations for variables guarded… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13126: util: Add Clang thread safety annotations for variables guarded…
Tue, Apr 7, 22:33
nakihito committed rSTAGING4a3dbc08a60d: Merge #13861: test: Add testing of value_ret for SelectCoinsBnB (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13861: test: Add testing of value_ret for SelectCoinsBnB
Tue, Apr 7, 22:29