- User Since
- Jul 22 2018, 17:49 (68 w, 4 d)
Removed some more obsolete code from the seeder.
Investigating build failure.
Seeder now requests the blocks that come after the most recent checkpoint and uses that information to determine whether the peer is on the correct chain.
Rebased to included changes from D4449 which allow the removal of a test. Also renamed a test and changed addr message tests to specify how many addrs to include in the addr message among other concerns.
ParseCommandLine uses SelectParams() now. Added error message for -regtest option.
Squashed some missed changed.
Rebase, split test into two different tests, removed NOTFOUND message functionality because it is not necessary, added differentiating logic for an empty HEADERS message and a non-empty HEADERS message. Also added some more constants.
Changed static_cast into a functional cast.
Split tests into smaller parts and added more constants.
Broken tests into smaller parts, made names more explicit, added more constants.
Came up with a better solution for the return value of ParseCommandLine(). Changed handling of -testnet option to mirror bitcoin-cli.cpp.
Wed, Nov 13
Cleaned up TestCSeederNode and rebase.
Removed code creating the DNS message header because it is unnecessary for these tests. Renamed various functions/variables. Also added some more comments.
Added $(PIE_FLAGS) for clang.
Fixed some variable names.
Renamed enum class and moved it within the CSeederOpts class. Changed main() return values to use EXIT_SUCCESS and EXIT_FAILURE.
Tue, Nov 12
Rebased and adjusted some cmake names.
Function now also adds the unit test files to the test suite by calling add_test_to_suite.
Moved function to TestSuite.cmake. Function now also handles searching for the boost package and linking the library to the executable.
Changed CMake names to be more descriptive, Updated copyright missing copyright lines, fixed formatting, and rebased to remove duplicate code.
Sat, Nov 9
Added copyright lines and cleaned up Makefile.
Fri, Nov 8
Executable added in D4413.
Rebased and added braces.
Added enum class and changed return value of ParseCommandLine() to make use of it.
Thu, Nov 7
Working on https://github.com/bitcoin/bitcoin/pull/15296 for a more comprehensive test plan.
Wed, Nov 6
Fixed comment formatting.