Page MenuHomePhabricator

Merge #16412: net: Make poll in InterruptibleRecv only filter for POLLIN events.
ClosedPublic

Authored by nakihito on Jun 17 2020, 20:58.

Details

Reviewers
majcosta
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC20d411097e02: Merge #16412: net: Make poll in InterruptibleRecv only filter for POLLIN events.
Summary

a52818cc5633494992da7d1dc8fdb04b4a1b7c29 net: Make poll in InterruptibleRecv only filter for POLLIN events. poll should block until there is data to be read or the timeout expires. (tecnovert)

Pull request description:

poll should block until there is data to be read or the timeout expires.

Filtering for the POLLOUT event causes poll to return immediately which leads to high CPU usage when trying to connect to non-responding peers through tor.

When USE_POLL is not defined select is used with the writefds parameter set to nullptr.
Removing POLLOUT causes the behavior of poll to match that of select.

Fixes: #16004.

ACKs for top commit:

laanwj:
  code review ACK a52818cc5633494992da7d1dc8fdb04b4a1b7c29
jonasschnelli:
  utACK a52818cc5633494992da7d1dc8fdb04b4a1b7c29

Tree-SHA512: 69934cc14e3327c7ff7f6c5942af8761e865220b2540d74ea1e176adad326307a73860417dddfd32d601b5c0e9e2ada1848bd7e3d27b0b7a9b42f11129af8eb1

Backport of Core PR16412

Test Plan
ninja check-all
src/bitcoind

Verify normal operation.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable