Page MenuHomePhabricator

majcosta (Marco Costa)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2018, 14:09 (51 w, 5 d)

Recent Activity

Yesterday

majcosta committed rABCd688432ba632: Sanity-check script sizes in bitcoin-tx (authored by MarcoFalke <falke.marco@gmail.com>).
Sanity-check script sizes in bitcoin-tx
Mon, Dec 9, 13:57
majcosta closed D4666: Sanity-check script sizes in bitcoin-tx.
Mon, Dec 9, 13:57
majcosta created D4666: Sanity-check script sizes in bitcoin-tx.
Mon, Dec 9, 08:07

Thu, Dec 5

majcosta committed rABCa8257058a391: refactoring: add a method for determining if a block is pruned or not (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
refactoring: add a method for determining if a block is pruned or not
Thu, Dec 5, 00:05
majcosta closed D4624: refactoring: add a method for determining if a block is pruned or not.
Thu, Dec 5, 00:05

Wed, Dec 4

majcosta added inline comments to D4624: refactoring: add a method for determining if a block is pruned or not.
Wed, Dec 4, 02:04

Tue, Dec 3

majcosta created D4624: refactoring: add a method for determining if a block is pruned or not.
Tue, Dec 3, 20:55

Sat, Nov 30

majcosta committed rABC1fd19cd4f4c0: Add const modifier to HTTPRequest methods (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Add const modifier to HTTPRequest methods
Sat, Nov 30, 00:02
majcosta closed D4590: Add const modifier to HTTPRequest methods.
Sat, Nov 30, 00:02

Fri, Nov 29

majcosta updated the summary of D4590: Add const modifier to HTTPRequest methods.
Fri, Nov 29, 23:44
majcosta created D4590: Add const modifier to HTTPRequest methods.
Fri, Nov 29, 23:29

Thu, Nov 28

majcosta committed rABCeb1893c84752: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal
Thu, Nov 28, 00:35
majcosta closed D4570: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal.
Thu, Nov 28, 00:35

Wed, Nov 27

majcosta updated the test plan for D4570: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal.
Wed, Nov 27, 23:45
majcosta updated the diff for D4570: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal.

removed declaration not in our codebase

Wed, Nov 27, 23:42
majcosta committed rABC3c897918bfc3: previous link was dead (authored by majcosta).
previous link was dead
Wed, Nov 27, 23:40
majcosta closed D4569: previous link was dead.
Wed, Nov 27, 23:39
majcosta updated the diff for D4570: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal.

reverted inline comments

Wed, Nov 27, 23:37
majcosta created D4570: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal.
Wed, Nov 27, 23:02
majcosta added a reviewer for D4569: previous link was dead: jasonbcox.
Wed, Nov 27, 21:20
majcosta created D4569: previous link was dead.
Wed, Nov 27, 20:38

Tue, Nov 26

majcosta committed rABC2b5019c182ce: Trivial: Corrected comment array name from pnSeeds6 to pnSeed6 (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Trivial: Corrected comment array name from pnSeeds6 to pnSeed6
Tue, Nov 26, 23:40
majcosta closed D4553: Trivial: Corrected comment array name from pnSeeds6 to pnSeed6.
Tue, Nov 26, 23:40
majcosta retitled D4553: Trivial: Corrected comment array name from pnSeeds6 to pnSeed6 from Backport of Bitcoin Core PR12986 https://github.com/bitcoin/bitcoin/pull/12986 to Trivial: Corrected comment array name from pnSeeds6 to pnSeed6.
Tue, Nov 26, 23:19
majcosta created D4553: Trivial: Corrected comment array name from pnSeeds6 to pnSeed6.
Tue, Nov 26, 23:18
majcosta abandoned D4544: simplified IsHexNumber function.
Tue, Nov 26, 00:56
majcosta added a comment to D4544: simplified IsHexNumber function.

I understand. Gonna look for something more useful then. Closing.

Tue, Nov 26, 00:56

Mon, Nov 25

majcosta updated the diff for D4544: simplified IsHexNumber function.

changed function declaration to noexcept

Mon, Nov 25, 23:15
majcosta updated the diff for D4544: simplified IsHexNumber function.

previous diff not clang-formatted properly. is now.

Mon, Nov 25, 23:06
majcosta created D4544: simplified IsHexNumber function.
Mon, Nov 25, 23:05

Fri, Nov 22

majcosta committed rABCc8d1fedde875: minor refactor to use ranged_for, auto and const-ness (authored by majcosta).
minor refactor to use ranged_for, auto and const-ness
Fri, Nov 22, 14:29
majcosta closed D4495: minor refactor to use ranged_for, auto and const-ness.
Fri, Nov 22, 14:28
majcosta updated the diff for D4495: minor refactor to use ranged_for, auto and const-ness.

I have run the test using const auto &fileName and it did set off the -fsanitize=address giving me a stack-use-after-scope error, so I went back to by-value semantics. address,undefined and memory sanitizer reported no problems after that (except for one use-of-uninitialized-value on Boost)

Fri, Nov 22, 06:33
majcosta updated the summary of D4495: minor refactor to use ranged_for, auto and const-ness.
Fri, Nov 22, 05:43

Thu, Nov 21

majcosta updated the diff for D4495: minor refactor to use ranged_for, auto and const-ness.

changed fileName from value to reference semantics

Thu, Nov 21, 15:31

Wed, Nov 20

majcosta added inline comments to D4495: minor refactor to use ranged_for, auto and const-ness.
Wed, Nov 20, 22:31
majcosta created D4495: minor refactor to use ranged_for, auto and const-ness.
Wed, Nov 20, 19:08

Jan 20 2019

majcosta committed rSTAGING04b7e8ba8b70: Added -Wmissing-braces to CXXFLAGS where supported by the compiler (authored by majcosta).
Added -Wmissing-braces to CXXFLAGS where supported by the compiler
Jan 20 2019, 23:52
majcosta committed rSTAGINGe63fa0268ce5: no more -Wmissing-braces warnings (authored by majcosta).
no more -Wmissing-braces warnings
Jan 20 2019, 23:52

Dec 19 2018

majcosta added a comment to T191: Fix missing-braces warnings..

D2191: no more -Wmissing-braces warnings

Dec 19 2018, 12:42 · Bootcamp

Dec 15 2018

majcosta committed rABC04b7e8ba8b70: Added -Wmissing-braces to CXXFLAGS where supported by the compiler (authored by majcosta).
Added -Wmissing-braces to CXXFLAGS where supported by the compiler
Dec 15 2018, 04:42
majcosta closed D2192: Added -Wmissing-braces to CXXFLAGS where supported by the compiler.
Dec 15 2018, 04:41

Dec 14 2018

Herald added a reviewer for D2192: Added -Wmissing-braces to CXXFLAGS where supported by the compiler: deadalnix.
Dec 14 2018, 15:00
majcosta committed rABCe63fa0268ce5: no more -Wmissing-braces warnings (authored by majcosta).
no more -Wmissing-braces warnings
Dec 14 2018, 11:49
majcosta closed D2191: no more -Wmissing-braces warnings.
Dec 14 2018, 11:48
Herald added a reviewer for D2191: no more -Wmissing-braces warnings: deadalnix.
Dec 14 2018, 09:21