User Details
User Details
- User Since
- Dec 12 2018, 14:09 (51 w, 5 d)
Yesterday
Yesterday
majcosta committed rABCd688432ba632: Sanity-check script sizes in bitcoin-tx (authored by MarcoFalke <falke.marco@gmail.com>).
Sanity-check script sizes in bitcoin-tx
Thu, Dec 5
Thu, Dec 5
majcosta committed rABCa8257058a391: refactoring: add a method for determining if a block is pruned or not (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
refactoring: add a method for determining if a block is pruned or not
Wed, Dec 4
Wed, Dec 4
majcosta added inline comments to D4624: refactoring: add a method for determining if a block is pruned or not.
Tue, Dec 3
Tue, Dec 3
Sat, Nov 30
Sat, Nov 30
majcosta committed rABC1fd19cd4f4c0: Add const modifier to HTTPRequest methods (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Add const modifier to HTTPRequest methods
Fri, Nov 29
Fri, Nov 29
majcosta updated the summary of D4590: Add const modifier to HTTPRequest methods.
Thu, Nov 28
Thu, Nov 28
majcosta committed rABCeb1893c84752: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal
Wed, Nov 27
Wed, Nov 27
majcosta updated the test plan for D4570: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal.
majcosta updated the diff for D4570: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal.
removed declaration not in our codebase
previous link was dead
majcosta updated the diff for D4570: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal.
reverted inline comments
Tue, Nov 26
Tue, Nov 26
majcosta committed rABC2b5019c182ce: Trivial: Corrected comment array name from pnSeeds6 to pnSeed6 (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Trivial: Corrected comment array name from pnSeeds6 to pnSeed6
majcosta retitled D4553: Trivial: Corrected comment array name from pnSeeds6 to pnSeed6 from Backport of Bitcoin Core PR12986 https://github.com/bitcoin/bitcoin/pull/12986 to Trivial: Corrected comment array name from pnSeeds6 to pnSeed6.
majcosta added a comment to D4544: simplified IsHexNumber function.
I understand. Gonna look for something more useful then. Closing.
Mon, Nov 25
Mon, Nov 25
majcosta updated the diff for D4544: simplified IsHexNumber function.
changed function declaration to noexcept
majcosta updated the diff for D4544: simplified IsHexNumber function.
previous diff not clang-formatted properly. is now.
Fri, Nov 22
Fri, Nov 22
majcosta committed rABCc8d1fedde875: minor refactor to use ranged_for, auto and const-ness (authored by majcosta).
minor refactor to use ranged_for, auto and const-ness
majcosta updated the diff for D4495: minor refactor to use ranged_for, auto and const-ness.
I have run the test using const auto &fileName and it did set off the -fsanitize=address giving me a stack-use-after-scope error, so I went back to by-value semantics. address,undefined and memory sanitizer reported no problems after that (except for one use-of-uninitialized-value on Boost)
majcosta updated the summary of D4495: minor refactor to use ranged_for, auto and const-ness.
Thu, Nov 21
Thu, Nov 21
majcosta updated the diff for D4495: minor refactor to use ranged_for, auto and const-ness.
changed fileName from value to reference semantics
Wed, Nov 20
Wed, Nov 20
majcosta added inline comments to D4495: minor refactor to use ranged_for, auto and const-ness.
Jan 20 2019
Jan 20 2019
majcosta committed rSTAGING04b7e8ba8b70: Added -Wmissing-braces to CXXFLAGS where supported by the compiler (authored by majcosta).
Added -Wmissing-braces to CXXFLAGS where supported by the compiler
no more -Wmissing-braces warnings
Dec 19 2018
Dec 19 2018
majcosta added a comment to T191: Fix missing-braces warnings..
Dec 15 2018
Dec 15 2018
majcosta committed rABC04b7e8ba8b70: Added -Wmissing-braces to CXXFLAGS where supported by the compiler (authored by majcosta).
Added -Wmissing-braces to CXXFLAGS where supported by the compiler
Dec 14 2018
Dec 14 2018
Herald added a reviewer for D2192: Added -Wmissing-braces to CXXFLAGS where supported by the compiler: deadalnix.
no more -Wmissing-braces warnings