Page MenuHomePhabricator

majcosta (Marco Costa)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2018, 14:09 (110 w, 1 d)

Recent Activity

Today

majcosta accepted D9009: [wallet] Update the rebroadcast frequency to be ~1/day..
Thu, Jan 21, 13:53
majcosta accepted D9012: [mempool] Persist unbroadcast set to mempool.dat.

discussed off Phab, the wait_until import should be removed in PR19752

Thu, Jan 21, 13:53
majcosta accepted D9006: [mempool] Track "unbroadcast" transactions.
Thu, Jan 21, 13:49
majcosta requested changes to D9012: [mempool] Persist unbroadcast set to mempool.dat.
Thu, Jan 21, 13:39
majcosta accepted D9011: [test] Integration tests for unbroadcast functionality.
Thu, Jan 21, 13:35
majcosta updated the summary of D9011: [test] Integration tests for unbroadcast functionality.
Thu, Jan 21, 13:20
majcosta accepted D9010: [refactor/test] Extract P2PTxInvStore into test framework.
Thu, Jan 21, 13:18
majcosta accepted D9008: [p2p] Reattempt initial send of unbroadcast transactions.
Thu, Jan 21, 13:14
majcosta accepted D9007: [util] Add method that returns random time in milliseconds.
Thu, Jan 21, 13:11
majcosta requested changes to D9006: [mempool] Track "unbroadcast" transactions.
Thu, Jan 21, 13:09
majcosta accepted D9005: tests: Add fuzzing harness for Golomb-Rice coding (GolombRiceEncode/GolombRiceDecode).
Thu, Jan 21, 13:01
majcosta accepted D9004: fuzz: fix unused variable compiler warning.
Thu, Jan 21, 12:43
majcosta accepted D9003: Add fuzzer version of randomized prevector test.
Thu, Jan 21, 12:41
majcosta closed D8992: [backport#18754] bench: add CAddrMan benchmarks.
Thu, Jan 21, 12:30
majcosta committed rABC8b0b3a190975: [backport#18754] bench: add CAddrMan benchmarks (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#18754] bench: add CAddrMan benchmarks
Thu, Jan 21, 12:30
majcosta closed D8993: [backport#18669] log: Use Join() helper when listing log categories.
Thu, Jan 21, 12:29
majcosta committed rABCf9ec355922bb: [backport#18669] log: Use Join() helper when listing log categories (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#18669] log: Use Join() helper when listing log categories
Thu, Jan 21, 12:28
majcosta closed D8994: [backport#18777] wallet: Recommend absolute path for dumpwallet.
Thu, Jan 21, 12:26
majcosta committed rABCd0fa5ad23b7c: [backport#18777] wallet: Recommend absolute path for dumpwallet (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#18777] wallet: Recommend absolute path for dumpwallet
Thu, Jan 21, 12:26
majcosta updated the diff for D8992: [backport#18754] bench: add CAddrMan benchmarks.

addressed feedback

Thu, Jan 21, 12:03
majcosta accepted D8997: [CI] Elect more builds to run on diff depending on simple heuristic.
Thu, Jan 21, 11:58
majcosta abandoned D8990: [backport#18665] Do not expose and consider -logthreadnames when it does not work.

oh, looks like this one isn't helpful then. abandoning.

Thu, Jan 21, 11:57
teamcity awarded D8992: [backport#18754] bench: add CAddrMan benchmarks a Haypence token.
Thu, Jan 21, 08:55
majcosta updated the diff for D8992: [backport#18754] bench: add CAddrMan benchmarks.

rebase

Thu, Jan 21, 00:35

Yesterday

majcosta requested review of D8994: [backport#18777] wallet: Recommend absolute path for dumpwallet.
Wed, Jan 20, 19:29
majcosta requested review of D8993: [backport#18669] log: Use Join() helper when listing log categories.
Wed, Jan 20, 19:23
majcosta requested review of D8992: [backport#18754] bench: add CAddrMan benchmarks.
Wed, Jan 20, 18:52
majcosta accepted D8988: test: use zero-argument super() shortcut (Python 3.0+).
Wed, Jan 20, 18:19
majcosta accepted D8991: test: Fix intermittent failure in wallet_importmulti.
Wed, Jan 20, 18:01
majcosta accepted D8989: test: Remove raw-tx byte juggling in mempool_reorg.
Wed, Jan 20, 17:58
majcosta accepted D8987: tests: Add fuzzing harnesses for classes/functions in policy/fees.h, checkqueue.h and cuckoocache.h. Add fuzzing coverage..
Wed, Jan 20, 17:35
majcosta requested review of D8990: [backport#18665] Do not expose and consider -logthreadnames when it does not work.
Wed, Jan 20, 16:57
majcosta accepted D8979: tests: Add fuzzing harnesses for functions/classes in chain.h and protocol.h.
Wed, Jan 20, 16:47
majcosta requested changes to D8979: tests: Add fuzzing harnesses for functions/classes in chain.h and protocol.h.
Wed, Jan 20, 15:18

Mon, Jan 18

majcosta closed D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].
Mon, Jan 18, 13:06
majcosta committed rABC7680ec0096b1: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState… (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState…
Mon, Jan 18, 13:05
teamcity awarded D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix] a Doubloon token.
Mon, Jan 18, 11:32
majcosta updated the diff for D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].

removed commented leftover debugging line and adapted the test for Coin::DynamicMemoryUsage() on 32-bit

Mon, Jan 18, 11:12
teamcity awarded D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix] a Piece of Eight token.
Mon, Jan 18, 08:54
teamcity awarded D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix] a Haypence token.
Mon, Jan 18, 08:38

Sun, Jan 17

majcosta updated the summary of D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].
Sun, Jan 17, 12:11
majcosta accepted D8937: refactor: Remove unused methods CBloomFilter::reset()/clear().
Sun, Jan 17, 10:37
majcosta accepted D8936: tests: have coins simulation test also use CCoinsViewDB.
Sun, Jan 17, 10:35
majcosta accepted D8935: script: Disallow silent bool -> CScript conversion.
Sun, Jan 17, 10:33
majcosta requested review of D8938: [backport#16945#18181] refactor: introduce CChainState::GetCoinsCacheSizeState [plus fix].
Sun, Jan 17, 10:26

Fri, Jan 15

majcosta closed D8921: [backport#16380] Remove unused bits from the service flags enum.
Fri, Jan 15, 16:23
majcosta committed rABCb051c69478dd: [backport#16380] Remove unused bits from the service flags enum (authored by fanquake <fanquake@gmail.com>).
[backport#16380] Remove unused bits from the service flags enum
Fri, Jan 15, 16:23
majcosta accepted D8932: test: Verify findCommonAncestor always initializes outputs.
Fri, Jan 15, 15:35
majcosta accepted D8929: test: Add various low-level p2p tests.
Fri, Jan 15, 14:45
majcosta accepted D8931: test: coverage improvements in interface-bitcoin_cli.py.
Fri, Jan 15, 14:43
majcosta accepted D8930: [doc] Update thread information in developer docs.
Fri, Jan 15, 14:20
majcosta requested changes to D8929: test: Add various low-level p2p tests.
Fri, Jan 15, 13:53
majcosta updated the diff for D8921: [backport#16380] Remove unused bits from the service flags enum.

corrected date of removal and removed declaration in messages.py

Fri, Jan 15, 11:31

Thu, Jan 14

majcosta accepted D8918: Deprecate the `setexcessiveblock` RPC.
Thu, Jan 14, 17:43
majcosta requested review of D8921: [backport#16380] Remove unused bits from the service flags enum.
Thu, Jan 14, 17:42
majcosta accepted D8920: test: Remove REJECT message code.
Thu, Jan 14, 17:15
majcosta accepted D8919: rpc: Remove deprecated migration code.
Thu, Jan 14, 17:13
majcosta closed D8914: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled.
Thu, Jan 14, 15:38
majcosta committed rABCfbd564ae6a78: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[backport#17453] gui: Fix intro dialog labels when the prune button is toggled
Thu, Jan 14, 15:38
majcosta closed D8916: [backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD.
Thu, Jan 14, 15:38
majcosta committed rABCfc8c7fd5b1fa: [backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD
Thu, Jan 14, 15:38
majcosta updated the diff for D8914: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled.

rebase on top of D8916 which fixes the circular dependency h/t @PiRK

Thu, Jan 14, 14:41
majcosta closed D8913: [backport#17696] qt: Force set nPruneSize in QSettings after the intro dialog.
Thu, Jan 14, 14:39
majcosta committed rABC6a7934983f7f: [backport#17696] qt: Force set nPruneSize in QSettings after the intro dialog (authored by fanquake <fanquake@gmail.com>).
[backport#17696] qt: Force set nPruneSize in QSettings after the intro dialog
Thu, Jan 14, 14:39
majcosta accepted D8915: Add a test for the banscore deprecation.
Thu, Jan 14, 14:37
majcosta requested review of D8916: [backport#15874] Resolve the qt/guiutil <-> qt/optionsmodel CD.
Thu, Jan 14, 14:37
majcosta accepted D8912: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance.
Thu, Jan 14, 14:37
majcosta added a comment to D8912: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance.

also "Backport of PR18574" is missing from summary

Thu, Jan 14, 13:54
majcosta requested changes to D8912: cli -getinfo: use getbalances instead of deprecated getwalletinfo balance.
Thu, Jan 14, 13:53
majcosta accepted D8910: Remove PID file at the very end.
Thu, Jan 14, 13:50
majcosta accepted D8911: rpc: Make verifychain default values static, not depend on global args.
Thu, Jan 14, 13:49
majcosta updated the summary of D8914: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled.
Thu, Jan 14, 13:03
majcosta requested review of D8914: [backport#17453] gui: Fix intro dialog labels when the prune button is toggled.
Thu, Jan 14, 13:03
majcosta requested review of D8913: [backport#17696] qt: Force set nPruneSize in QSettings after the intro dialog.
Thu, Jan 14, 13:02
majcosta requested changes to D8910: Remove PID file at the very end.

tests failing

Thu, Jan 14, 11:58
majcosta accepted D8908: Fix a -Wunused-variable in the locale fuzzer.
Thu, Jan 14, 11:34
majcosta accepted D8905: Moving dev dependencies to dev, removing unused deps, updates some of them.
Thu, Jan 14, 11:29
majcosta retitled D8905: Moving dev dependencies to dev, removing unused deps, updates some of them from Moving dev dependencies to dev, removing unused deps to Moving dev dependencies to dev, removing unused deps, updates some of them.
Thu, Jan 14, 11:02
majcosta requested changes to D8905: Moving dev dependencies to dev, removing unused deps, updates some of them.
Thu, Jan 14, 04:01

Wed, Jan 13

majcosta accepted D8904: [Cashtab] bump extension version to support new backend per D8885.
Wed, Jan 13, 16:06
majcosta accepted D8901: [CashTab] Update react-copy-to-clipboard.
Wed, Jan 13, 15:20
majcosta accepted D8902: rpc: Make rpc documentation not depend on rpc args.
Wed, Jan 13, 15:08
majcosta closed D8762: [backport#16658] validation: Rename CheckInputs to CheckInputScripts.
Wed, Jan 13, 14:44
majcosta committed rABC925120cac2cb: [backport#16658] validation: Rename CheckInputs to CheckInputScripts (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#16658] validation: Rename CheckInputs to CheckInputScripts
Wed, Jan 13, 14:44
majcosta requested review of D8762: [backport#16658] validation: Rename CheckInputs to CheckInputScripts.

it looks like D3878 and D3875 diverged from Core so that the tests don't rely on whether "CheckInputs" or "CheckInputScripts" gets printed to the debug log

Wed, Jan 13, 13:58

Tue, Jan 12

majcosta accepted D8884: rpc: fix broken RPCExamples for waitforblock(height).
Tue, Jan 12, 18:31
majcosta accepted D8878: Replace std::to_string with locale-independent alternative.
Tue, Jan 12, 15:18
majcosta accepted D8881: test: Fix restart node race.
Tue, Jan 12, 13:55
majcosta accepted D8872: test: add unit test for non-standard "scriptsig-not-pushonly" txs.
Tue, Jan 12, 11:16
majcosta requested changes to D8878: Replace std::to_string with locale-independent alternative.
Tue, Jan 12, 11:04
majcosta requested changes to D8872: test: add unit test for non-standard "scriptsig-not-pushonly" txs.
Tue, Jan 12, 10:32

Mon, Jan 11

majcosta accepted D8876: gui: display Mapped AS in peers info window.
Mon, Jan 11, 17:36
majcosta requested changes to D8872: test: add unit test for non-standard "scriptsig-not-pushonly" txs.

this is PR17720 right? missing in the summary

Mon, Jan 11, 17:30
majcosta accepted D8875: [CI] Add cashtab coverage report to the coverage panel.
Mon, Jan 11, 17:19
majcosta accepted D8874: [CI] Generate a CashTab coverage summary report.
Mon, Jan 11, 16:48
majcosta accepted D8873: [Cashtab] remove duplicate key from test mock.
Mon, Jan 11, 15:19
majcosta accepted D8870: [Cashtab] extension with new pkgs, version bump.
Mon, Jan 11, 15:10
majcosta accepted D8871: gui: Avoid redundant tx status updates.
Mon, Jan 11, 14:43
majcosta requested changes to D8870: [Cashtab] extension with new pkgs, version bump.

tests are failing

Mon, Jan 11, 13:21
majcosta accepted D8867: [validation] Remove NotifyEntryRemoved callback from ConnectTrace.
Mon, Jan 11, 13:20