Page MenuHomePhabricator

majcosta (Marco Costa)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2018, 14:09 (98 w, 1 d)

Recent Activity

Today

majcosta accepted D8186: Send amount shows minimum amount placeholder.
Thu, Oct 29, 22:08
majcosta closed D8179: [backport#12075] [scripts] Add missing univalue file to copyright_header.py.
Thu, Oct 29, 18:56
majcosta committed rABCf780be44599f: [backport#12075] [scripts] Add missing univalue file to copyright_header.py (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#12075] [scripts] Add missing univalue file to copyright_header.py
Thu, Oct 29, 18:56
majcosta closed D8180: [bacpkort#10677] RPC Docs: addmultisigaddress is intended for non-watchonly addresses.
Thu, Oct 29, 18:48
majcosta committed rABC1dd3de23870b: [bacpkort#10677] RPC Docs: addmultisigaddress is intended for non-watchonly… (authored by Pieter Wuille <pieter.wuille@gmail.com>).
[bacpkort#10677] RPC Docs: addmultisigaddress is intended for non-watchonly…
Thu, Oct 29, 18:48
majcosta requested review of D8180: [bacpkort#10677] RPC Docs: addmultisigaddress is intended for non-watchonly addresses.
Thu, Oct 29, 17:12
majcosta requested review of D8179: [backport#12075] [scripts] Add missing univalue file to copyright_header.py.
Thu, Oct 29, 17:04
majcosta closed D8171: [backport#11686#11706] Make ISSUE_TEMPLATE a bit shorter, mention hardware tests.
Thu, Oct 29, 16:06
majcosta committed rABCd678fee2afbb: [backport#11686#11706] Make ISSUE_TEMPLATE a bit shorter, mention hardware tests (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#11686#11706] Make ISSUE_TEMPLATE a bit shorter, mention hardware tests
Thu, Oct 29, 16:06
majcosta abandoned D8167: [backport#11448] [gui] reset addrProxy/addrSeparateProxyTor if colon char missing.

oh cool this is a skip then. abandoning

Thu, Oct 29, 15:55
majcosta closed D8166: [backport#11419] Utils: Fix launchctl not being able to stop bitcoind.
Thu, Oct 29, 15:47
majcosta committed rABCa99a884db819: [backport#11419] Utils: Fix launchctl not being able to stop bitcoind (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[backport#11419] Utils: Fix launchctl not being able to stop bitcoind
Thu, Oct 29, 15:47
majcosta closed D8168: [backport#11594] Improve -disablewallet parameter interaction.
Thu, Oct 29, 15:47
majcosta committed rABCe5c7da9fd970: [backport#11594] Improve -disablewallet parameter interaction (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#11594] Improve -disablewallet parameter interaction
Thu, Oct 29, 15:47
majcosta closed D8169: [backport#11676] contrib/init: Update openrc-run filename.
Thu, Oct 29, 15:46
majcosta committed rABC21f4914112c4: [backport#11676] contrib/init: Update openrc-run filename (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#11676] contrib/init: Update openrc-run filename
Thu, Oct 29, 15:46
majcosta closed D8170: [backport#11690] [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it.
Thu, Oct 29, 15:40
majcosta committed rABC6c82ad9ec689: [backport#11690] [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell… (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#11690] [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell…
Thu, Oct 29, 15:40
majcosta closed D8172: [backport#11140] Trivial: Improve #endif comments.
Thu, Oct 29, 15:39
majcosta committed rABC6b08ed7779e1: [backport#11140] Trivial: Improve #endif comments (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#11140] Trivial: Improve #endif comments
Thu, Oct 29, 15:39
majcosta closed D8173: [backport#11804] [docs] Fixed outdated link with archive.is.
Thu, Oct 29, 15:38
majcosta committed rABCbb727339e2de: [backport#11804] [docs] Fixed outdated link with archive.is (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#11804] [docs] Fixed outdated link with archive.is
Thu, Oct 29, 15:38
majcosta updated the diff for D8171: [backport#11686#11706] Make ISSUE_TEMPLATE a bit shorter, mention hardware tests.

addressed comments

Thu, Oct 29, 15:36
teamcity awarded D8170: [backport#11690] [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it a Haypence token.
Thu, Oct 29, 05:51
majcosta added a comment to D8170: [backport#11690] [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it.

@bot build-diff

Thu, Oct 29, 05:51
majcosta retitled D8171: [backport#11686#11706] Make ISSUE_TEMPLATE a bit shorter, mention hardware tests from [backport#11686] Make ISSUE_TEMPLATE a bit shorter, mention hardware tests to [backport#11686#11706] Make ISSUE_TEMPLATE a bit shorter, mention hardware tests.
Thu, Oct 29, 05:27
majcosta updated the diff for D8171: [backport#11686#11706] Make ISSUE_TEMPLATE a bit shorter, mention hardware tests.

also squashed PR11706 into the diff since they're about the same file

Thu, Oct 29, 05:25
majcosta requested review of D8173: [backport#11804] [docs] Fixed outdated link with archive.is.
Thu, Oct 29, 05:14
majcosta requested review of D8172: [backport#11140] Trivial: Improve #endif comments.
Thu, Oct 29, 05:03
majcosta requested review of D8171: [backport#11686#11706] Make ISSUE_TEMPLATE a bit shorter, mention hardware tests.
Thu, Oct 29, 04:27
majcosta requested review of D8170: [backport#11690] [trivial] Fix the StartupWMClass for bitoin-qt, so gnome-shell can recognize it.
Thu, Oct 29, 04:21
majcosta requested review of D8169: [backport#11676] contrib/init: Update openrc-run filename.
Thu, Oct 29, 04:14
majcosta requested review of D8168: [backport#11594] Improve -disablewallet parameter interaction.
Thu, Oct 29, 04:11
majcosta requested review of D8167: [backport#11448] [gui] reset addrProxy/addrSeparateProxyTor if colon char missing.
Thu, Oct 29, 03:02
majcosta closed D8165: [docs] use CashAddr throughout sendmany help.
Thu, Oct 29, 02:38
majcosta committed rABCceb99085cae4: [docs] use CashAddr throughout sendmany help (authored by majcosta).
[docs] use CashAddr throughout sendmany help
Thu, Oct 29, 02:38
majcosta added a comment to D8165: [docs] use CashAddr throughout sendmany help.

no reason other than those were the addresses I tested with, really

Thu, Oct 29, 02:36
majcosta requested review of D8166: [backport#11419] Utils: Fix launchctl not being able to stop bitcoind.
Thu, Oct 29, 02:32
majcosta requested review of D8165: [docs] use CashAddr throughout sendmany help.
Thu, Oct 29, 01:18
majcosta closed D8164: [backport#12077] [Docs] Correct `sendmany` curl example.
Thu, Oct 29, 00:43
majcosta committed rABCe85b7bfe5bf0: [backport#12077] [Docs] Correct `sendmany` curl example (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#12077] [Docs] Correct `sendmany` curl example
Thu, Oct 29, 00:43
majcosta requested review of D8164: [backport#12077] [Docs] Correct `sendmany` curl example.
Thu, Oct 29, 00:23

Yesterday

majcosta accepted D8161: gui: don't disable the sync overlay when wallet is disabled.
Wed, Oct 28, 22:23
majcosta accepted D8162: gui: Add placeholder text to the sign message field.
Wed, Oct 28, 20:12
majcosta requested changes to D8161: gui: don't disable the sync overlay when wallet is disabled.
Wed, Oct 28, 20:11
majcosta accepted D8160: gui: Added label & tooltip for Verify Message labels.
Wed, Oct 28, 20:07
majcosta accepted D8159: gui: Make RPCConsole::TabTypes an enum class.
Wed, Oct 28, 20:03

Mon, Oct 26

majcosta closed D8131: [backport#14741] doc: Indicate -rpcauth option password hashing alg.
Mon, Oct 26, 23:07
majcosta committed rABC99dc88273f1c: [backport#14741] doc: Indicate -rpcauth option password hashing alg (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#14741] doc: Indicate -rpcauth option password hashing alg
Mon, Oct 26, 23:07
majcosta closed D8134: [backport#14790] Tests: Allow running rpc_bind.py --nonloopback test without IPv6.
Mon, Oct 26, 22:45
majcosta committed rABC306b06263e31: [backport#14790] Tests: Allow running rpc_bind.py --nonloopback test without… (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#14790] Tests: Allow running rpc_bind.py --nonloopback test without…
Mon, Oct 26, 22:45
majcosta closed D8133: [backport#12510] test: Add rpc_bind test to default-run tests.
Mon, Oct 26, 22:30
majcosta committed rABC3a91cc08c7a8: [backport#12510] test: Add rpc_bind test to default-run tests (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#12510] test: Add rpc_bind test to default-run tests
Mon, Oct 26, 22:30
majcosta closed D8129: [backport#13339] wallet: Replace %w by wallet name in -walletnotify script.
Mon, Oct 26, 22:15
majcosta committed rABCa8eab5004820: [backport#13339] wallet: Replace %w by wallet name in -walletnotify script (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#13339] wallet: Replace %w by wallet name in -walletnotify script
Mon, Oct 26, 22:15
majcosta closed D8132: [backport#14975] qt: Refactoring with QString::toNSString().
Mon, Oct 26, 22:04
majcosta committed rABC97264f077056: [backport#14975] qt: Refactoring with QString::toNSString() (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[backport#14975] qt: Refactoring with QString::toNSString()
Mon, Oct 26, 22:03
majcosta closed D8135: [backport#14375] qt: Correct misleading "overridden options" label.
Mon, Oct 26, 21:58
majcosta committed rABC82ded1d00472: [backport#14375] qt: Correct misleading "overridden options" label (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport#14375] qt: Correct misleading "overridden options" label
Mon, Oct 26, 21:58
majcosta updated the diff for D8133: [backport#12510] test: Add rpc_bind test to default-run tests.

added all missing CLI options to the runner

Mon, Oct 26, 21:48
majcosta requested review of D8135: [backport#14375] qt: Correct misleading "overridden options" label.
Mon, Oct 26, 20:46
majcosta requested review of D8134: [backport#14790] Tests: Allow running rpc_bind.py --nonloopback test without IPv6.
Mon, Oct 26, 20:38
majcosta requested review of D8133: [backport#12510] test: Add rpc_bind test to default-run tests.
Mon, Oct 26, 20:27
majcosta requested review of D8132: [backport#14975] qt: Refactoring with QString::toNSString().
Mon, Oct 26, 19:28
majcosta requested review of D8131: [backport#14741] doc: Indicate -rpcauth option password hashing alg.
Mon, Oct 26, 19:13
majcosta requested review of D8129: [backport#13339] wallet: Replace %w by wallet name in -walletnotify script.
Mon, Oct 26, 18:33

Sun, Oct 25

majcosta accepted D8103: Clear any input_errors for an input after it is signed.
Sun, Oct 25, 00:19
majcosta accepted D8102: Move direct calls to MessageSign into new SignMessage functions in CWallet and ScriptPubKeyMan.
Sun, Oct 25, 00:18
majcosta accepted D8101: Move key and script filling and signing from CWallet::FillPSBT to ScriptPubKeyMan::FillPSBT.
Sun, Oct 25, 00:12

Sat, Oct 24

majcosta accepted D8104: rpc: set default bip32derivs to true for psbt methods.
Sat, Oct 24, 23:56
majcosta accepted D8100: Use CWallet::SignTransaction in CreateTransaction and signrawtransactionwithwallet.
Sat, Oct 24, 23:42
majcosta accepted D8099: Various nits in abc_wallet_standardness.
Sat, Oct 24, 23:26
majcosta accepted D8098: refactor: deduplicate the message sign/verify code.
Sat, Oct 24, 23:25

Fri, Oct 16

majcosta accepted D7965: Merge #13180: Fix re-declared scoped enum as unscoped (Causes issues with some compilers).
Fri, Oct 16, 22:03
majcosta closed D7962: [backport#17999 2/2] refactor: Use psbt forward declaration.
Fri, Oct 16, 20:01
majcosta committed rABCf89036cf9d57: [backport#17999 2/2] refactor: Use psbt forward declaration (authored by Russell Yanofsky <russ@yanofsky.org>).
[backport#17999 2/2] refactor: Use psbt forward declaration
Fri, Oct 16, 20:01
majcosta closed D7960: [backport#16743] refactor: move LoadChainTip/RelayBlocks under CChainState.
Fri, Oct 16, 19:54
majcosta committed rABCd44cb2f96784: [backport#16743] refactor: move LoadChainTip/RelayBlocks under CChainState (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#16743] refactor: move LoadChainTip/RelayBlocks under CChainState
Fri, Oct 16, 19:54
majcosta accepted D7959: [land-bot] Allow users to specify the branch/commit in order to determine the revision to land.
Fri, Oct 16, 18:22
majcosta accepted D7963: [land-bot] Give a reasonable error when a revision cannot be found.
Fri, Oct 16, 18:22
majcosta updated the summary of D7962: [backport#17999 2/2] refactor: Use psbt forward declaration.
Fri, Oct 16, 17:44
majcosta closed D6995: [backport#17999 1/2] Add ChainClient setMockTime, getWallets methods.
Fri, Oct 16, 17:41
majcosta committed rABCa4ab5f79f2d4: [backport#17999 1/2] Add ChainClient setMockTime, getWallets methods (authored by Russell Yanofsky <russ@yanofsky.org>).
[backport#17999 1/2] Add ChainClient setMockTime, getWallets methods
Fri, Oct 16, 17:41
majcosta requested review of D7962: [backport#17999 2/2] refactor: Use psbt forward declaration.
Fri, Oct 16, 17:31
majcosta requested review of D7960: [backport#16743] refactor: move LoadChainTip/RelayBlocks under CChainState.
Fri, Oct 16, 17:06
majcosta closed D7958: [backport#16757] doc: CChainState return values.
Fri, Oct 16, 17:05
majcosta committed rABC3ee09fbcd837: [backport#16757] doc: CChainState return values (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
[backport#16757] doc: CChainState return values
Fri, Oct 16, 17:05
majcosta requested review of D7958: [backport#16757] doc: CChainState return values.
Fri, Oct 16, 16:20
majcosta closed D7944: [backport#19202] log: remove deprecated `db` log category.
Fri, Oct 16, 01:05
majcosta committed rABCf7a31614ba34: [backport#19202] log: remove deprecated `db` log category (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#19202] log: remove deprecated `db` log category
Fri, Oct 16, 01:05
majcosta requested review of D7944: [backport#19202] log: remove deprecated `db` log category.
Fri, Oct 16, 00:29

Thu, Oct 15

majcosta closed D7582: [backport#16443 3/3] Cover UTXO set access with lock annotations.
Thu, Oct 15, 23:58
majcosta committed rABC124054fe2dc7: [backport#16443 3/3] Cover UTXO set access with lock annotations (authored by James O'Beirne <james.obeirne@gmail.com>).
[backport#16443 3/3] Cover UTXO set access with lock annotations
Thu, Oct 15, 23:58
majcosta closed D7581: [backport#16443 2/3] refactor: have CCoins* data managed under CChainState.
Thu, Oct 15, 23:58
majcosta committed rABC74ade9cfe69c: [backport#16443 2/3] refactor: have CCoins* data managed under CChainState (authored by James O'Beirne <james.obeirne@gmail.com>).
[backport#16443 2/3] refactor: have CCoins* data managed under CChainState
Thu, Oct 15, 23:58
majcosta closed D7580: [backport#16443 1/3] refactor: pcoinsTip -> CChainState::CoinsTip().
Thu, Oct 15, 23:57
majcosta committed rABC76953e642b2b: [backport#16443 1/3] refactor: pcoinsTip -> CChainState::CoinsTip() (authored by James O'Beirne <james.obeirne@gmail.com>).
[backport#16443 1/3] refactor: pcoinsTip -> CChainState::CoinsTip()
Thu, Oct 15, 23:57
majcosta closed D7579: [refactor] move ReadBlockFromDisk+ from validation.cpp.
Thu, Oct 15, 23:44
majcosta committed rABC05e860392659: [refactor] move ReadBlockFromDisk+ from validation.cpp (authored by majcosta).
[refactor] move ReadBlockFromDisk+ from validation.cpp
Thu, Oct 15, 23:44
majcosta updated the diff for D7579: [refactor] move ReadBlockFromDisk+ from validation.cpp.

oops, missing guys added

Thu, Oct 15, 23:10