Page MenuHomePhabricator

majcosta (Marco Costa)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2018, 14:09 (199 w, 1 d)

Recent Activity

Wed, Sep 7

majcosta abandoned D9975: avalanche: method to get std::vector<avalanche::Node> associated with a PeerId.
Wed, Sep 7, 18:31
majcosta abandoned D9697: make nExtraNonce static to IncrementExtraNonce.
Wed, Sep 7, 18:30

Nov 23 2021

majcosta accepted D10513: doc: Add anchors.dat to files.md.
Nov 23 2021, 23:18
majcosta accepted D10512: p2p: Try to connect to anchors once.
Nov 23 2021, 23:17
majcosta accepted D10511: p2p: Fix off-by-one error in fetching address loop.
Nov 23 2021, 23:16
majcosta accepted D10510: p2p: Integrate DumpAnchors() and ReadAnchors() into CConnman.

correct commit link is: https://github.com/bitcoin/bitcoin/pull/17428/commits/4170b46544231e7cf1d64ac3baa314083be37502

Nov 23 2021, 23:15
majcosta accepted D10509: p2p: Add CConnman::GetCurrentBlockRelayOnlyConns().
Nov 23 2021, 23:12
majcosta accepted D10508: p2p: Add ReadAnchors().
Nov 23 2021, 22:19
majcosta accepted D10507: p2p: Add DumpAnchors().
Nov 23 2021, 22:12

Nov 11 2021

majcosta accepted D10462: test: add p2p_lock acquires in p2p_leak_tx.py.
Nov 11 2021, 19:45
majcosta accepted D10461: test: use MiniWallet for p2p_leak_tx.py.
Nov 11 2021, 19:44
majcosta accepted D10460: Avoid the use of abs64 in timedata.
Nov 11 2021, 19:32
majcosta accepted D10458: test: Add tests for CNode::ConnectedThroughNetwork.
Nov 11 2021, 19:20
majcosta accepted D10457: net: Add CNode::ConnectedThroughNetwork member function.
Nov 11 2021, 19:14
majcosta accepted D10456: net: Add CNode::m_inbound_onion data member.
Nov 11 2021, 18:56

Nov 10 2021

majcosta accepted D10446: net, refactor: Refactor CBaseChainParams::RPCPort function.
Nov 10 2021, 06:47
majcosta accepted D10449: net, refactor: Move AddLocal call one level up.

tested ok locally, clang-tidy being flaky

Nov 10 2021, 06:46
majcosta accepted D10451: doc: Update onion service target port numbers in tor.md.
Nov 10 2021, 06:46
majcosta accepted D10450: net: Extend -bind config option with optional network type.
Nov 10 2021, 06:45
majcosta accepted D10448: net: Pass onion service target to Tor controller.
Nov 10 2021, 06:35
majcosta accepted D10447: refactor: Rename TorController::target to m_tor_control_center.
Nov 10 2021, 06:32
majcosta accepted D10445: net: Add alternative port for onion service.
Nov 10 2021, 06:29
majcosta accepted D10444: net: Use network byte order for in_addr.s_addr.
Nov 10 2021, 06:29

Nov 9 2021

majcosta added a comment to D10440: [avalanche] Remove getPeerId.

hm getPeerId isn't used as an accessor anywhere, so you're simplifying one function at the cost of more code everywhere else

Nov 9 2021, 00:06

Nov 2 2021

majcosta accepted D10416: ProcessOrphanTx: Remove aliases.
Nov 2 2021, 20:49
majcosta accepted D10415: ProcessOrphanTx: Remove outdated comment.
Nov 2 2021, 20:46
majcosta accepted D10414: ProcessOrphanTx: remove useless setMisbehaving set.
Nov 2 2021, 20:45
majcosta accepted D10422: test: Get rid of default wallet hacks.

feature_dbcrash won't run with ninja check-functional, test plan needs ./test/functional/test_runner.py --extended for that

Nov 2 2021, 20:14
majcosta accepted D10428: RPC: remove duplicate line in getblock help.
Nov 2 2021, 20:13
majcosta accepted D10426: net: rename CNetAddr scopeId to m_scope_id, improve code doc.
Nov 2 2021, 20:10
majcosta accepted D10425: test: add test coverage for CNetAddr ipv6 scoped addresses.
Nov 2 2021, 20:09
majcosta accepted D10423: Improve invalid vout value rpc error message.
Nov 2 2021, 20:08
majcosta accepted D10429: util: Do not use gArgs global in ArgsManager member functions.
Nov 2 2021, 20:07
majcosta accepted D10421: test, refactor: add default_wallet_name and wallet_data_filename variables.
Nov 2 2021, 19:46
majcosta accepted D10420: doc: Clarify scope of eviction protection of outbound block-relay peers.
Nov 2 2021, 19:33
majcosta accepted D10419: rpc: Set HTTP Content-Type in bitcoin-cli.
Nov 2 2021, 19:23
majcosta accepted D10418: [tests] Replace bytes literals with hex literals.
Nov 2 2021, 19:19
majcosta accepted D10417: [tests] Remove unused optional verify_checksum parameter.

I believe the link in the summary should be https://github.com/bitcoin/bitcoin/pull/19253/commits/7f639df0b8a15aaeccedab00b634925f568c2c9a ?

Nov 2 2021, 19:17
majcosta requested changes to D10416: ProcessOrphanTx: Remove aliases.

oh, these are all D10414 's fault

Nov 2 2021, 18:56
majcosta requested changes to D10415: ProcessOrphanTx: Remove outdated comment.

ci fail

Nov 2 2021, 18:50
majcosta accepted D10413: ProcessOrphanTx: remove useless done variable.
Nov 2 2021, 18:44
majcosta requested changes to D10414: ProcessOrphanTx: remove useless setMisbehaving set.

apparently MAX_NON_STANDARD_ORPHAN_PER_NODE is also unused now

Nov 2 2021, 18:16
majcosta accepted D10412: [net processing] Add doxygen comments for orphan data and function.
Nov 2 2021, 17:48
majcosta accepted D10411: Fix misleading error message: Clean stack rule.
Nov 2 2021, 17:43

Sep 10 2021

majcosta accepted D10075: remove argName nBlocks from estimatefee RPC command registration.
Sep 10 2021, 15:38
majcosta accepted D10074: rpc: document returned error fields as optional if applicable.
Sep 10 2021, 15:37

Sep 9 2021

majcosta accepted D10089: Refactor OutputGroups to handle effective values, fees, and filtering.
Sep 9 2021, 18:26
majcosta accepted D10088: Use real value when calculating OutputGroup value.
Sep 9 2021, 18:21
majcosta accepted D10085: wallet: Don't override signing errors.
Sep 9 2021, 18:20
majcosta accepted D10010: rpc: Update server to use new RPCHelpMan.
Sep 9 2021, 18:13

Sep 8 2021

majcosta requested changes to D10075: remove argName nBlocks from estimatefee RPC command registration.

linter be mad

Sep 8 2021, 15:41
majcosta requested changes to D10074: rpc: document returned error fields as optional if applicable.
Sep 8 2021, 15:40
majcosta accepted D10073: Cap listsinceblock target_confirmations param.
Sep 8 2021, 15:37
majcosta accepted D10072: rpc: Improve addnode remove command error message.
Sep 8 2021, 15:36
majcosta accepted D10071: [net] Add addpeeraddress RPC method.
Sep 8 2021, 15:31
majcosta accepted D10070: [test] Test that getnodeaddresses() can return all known addresses.

nit: link to the specific commit in the summary is wrong, points to 3/3 rather than 2/3

Sep 8 2021, 15:26
majcosta accepted D10069: [addrman] Specify max addresses and pct when calling GetAddresses().
Sep 8 2021, 15:08

Sep 7 2021

majcosta accepted D10068: refactor: test: use _ variable for unused loop counters.
Sep 7 2021, 15:56
majcosta accepted D10067: Deduplicate missing parents of orphan transactions.
Sep 7 2021, 14:12
majcosta accepted D10066: Rewrite parent txid loop of requested transactions.
Sep 7 2021, 13:55
majcosta accepted D10065: test: Wait for 'cmpctblock' in p2p_compactblocks when it is expected.
Sep 7 2021, 13:48
majcosta accepted D10063: test: Wait until is_connected in add_p2p_connection.
Sep 7 2021, 13:44
majcosta accepted D10064: test: use the correct DISCOURAGEMENT_THRESHOLD.

cool

Sep 7 2021, 13:41
majcosta accepted D10062: doc: Replace `hidden service` with `onion service`.
Sep 7 2021, 13:38
majcosta accepted D10060: util: use HAVE_FDATASYNC to determine fdatasync() use.
Sep 7 2021, 13:31
majcosta accepted D10059: Preserve the LockData initial state if "potential deadlock detected" exception thrown.
Sep 7 2021, 13:27
majcosta accepted D10058: rpc: Document getwalletinfo's unlocked_until field as optional.
Sep 7 2021, 13:22

Sep 6 2021

majcosta accepted D10053: Move filtering banned addrs inside GetAddresses().
Sep 6 2021, 21:36
majcosta accepted D10057: Test addr response caching.
Sep 6 2021, 17:15
majcosta accepted D10056: Add addr permission flag enabling non-cached addr sharing.
Sep 6 2021, 17:12
majcosta accepted D10055: Cache responses to addr requests.
Sep 6 2021, 17:06
majcosta accepted D10054: Remove useless 2500 limit on AddrMan queries.
Sep 6 2021, 17:01
majcosta requested changes to D10053: Move filtering banned addrs inside GetAddresses().
Sep 6 2021, 16:59
majcosta accepted D10052: Remove Reference Links.
Sep 6 2021, 15:24
majcosta accepted D10051: rpc: RPCResult Type of MempoolEntryDescription should be OBJ..
Sep 6 2021, 15:21
majcosta accepted D10050: walletdb: Ensure that having no database handle is a failure.
Sep 6 2021, 15:19
majcosta accepted D10049: Remove BDB dummy databases.
Sep 6 2021, 15:19
majcosta accepted D10048: Introduce DummyDatabase and use it in the tests.
Sep 6 2021, 15:16
majcosta accepted D10036: walletdb: Move Db->open to BerkeleyDatabase::Open.
Sep 6 2021, 15:14
majcosta accepted D10047: Clean message_count and last_message.
Sep 6 2021, 15:10

Sep 3 2021

majcosta accepted D10035: walletdb: track database file use as m_refcount within BerkeleyDatabase.
Sep 3 2021, 18:11
majcosta accepted D10034: Combine BerkeleyEnvironment::Verify into BerkeleyDatabase::Verify.
Sep 3 2021, 18:08

Sep 2 2021

majcosta accepted D10026: [avalanche] Make gen_proof facility return the key object.
Sep 2 2021, 13:33
majcosta accepted D10025: walletdb: Introduce WalletDatabase abstract class.
Sep 2 2021, 13:29
majcosta accepted D10024: walletdb: Add BerkeleyDatabase::Open dummy function.
Sep 2 2021, 13:22
majcosta accepted D10023: walletdb: Introduce AddRef and RemoveRef functions.
Sep 2 2021, 13:21
majcosta accepted D10022: walletdb: Move BerkeleyDatabase::Flush(true) to Close().
Sep 2 2021, 13:16
majcosta accepted D10021: log: Avoid treating remote misbehvior as local system error.
Sep 2 2021, 13:08
majcosta accepted D10018: test: fix intermittent p2p_ibd_txrelay race, add test_framework.py#wait_until.
Sep 2 2021, 13:05

Sep 1 2021

majcosta accepted D10012: rename movie folder to animation.
Sep 1 2021, 12:37
majcosta accepted D10011: gui: Show permissions instead of whitelisted.
Sep 1 2021, 12:26
majcosta requested changes to D10010: rpc: Update server to use new RPCHelpMan.

tests

Sep 1 2021, 12:25
majcosta accepted D10009: rpc: Add option to hide RPCArg.
Sep 1 2021, 12:20
majcosta accepted D10008: rpc: Assert that passed arg names are equal to hardcoded ones.
Sep 1 2021, 12:18
majcosta accepted D10007: rpc: Add CRPCCommand constructor which takes RPCHelpMan.
Sep 1 2021, 12:18
majcosta accepted D10006: rpc: Check that left section is not multiline.
Sep 1 2021, 12:11
majcosta accepted D10005: qt: Get rid of cursor in out-of-focus labels.
Sep 1 2021, 10:46
majcosta accepted D10004: Call SHA256AutoDetect in benchmark setup.
Sep 1 2021, 10:45

Aug 31 2021

majcosta accepted D10000: [Website] Improved cashtab logos.
Aug 31 2021, 21:28
majcosta accepted D9998: [LINTER] Replace unsigned short with uint16_t.

tested, worked

Aug 31 2021, 18:22