Page MenuHomePhabricator

majcosta (Marco Costa)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2018, 14:09 (123 w, 2 d)

Recent Activity

Today

majcosta accepted D9345: [avalanche] set a minimum amount for a proof.
Fri, Apr 23, 10:17

Tue, Apr 20

majcosta accepted D9439: [Cashtab] Re-enable send for 9-decimal tokens.
Tue, Apr 20, 19:28
majcosta accepted D9438: Make sure unconfirmed parents are requestable.
Tue, Apr 20, 17:43
majcosta accepted D9437: Drop setInventoryTxToSend based filtering.
Tue, Apr 20, 17:39
majcosta added a comment to D9437: Drop setInventoryTxToSend based filtering.

wrong summary link, this is the right one: https://github.com/bitcoin/bitcoin/pull/19109/commits/c4626bcd211af08c85b6567ef07eeae333edba47

Tue, Apr 20, 17:39
majcosta accepted D9436: Only respond to requests for recently announced transactions.
Tue, Apr 20, 17:38
majcosta accepted D9435: Introduce constant for mempool-based relay separate from mapRelay caching.

built and tested locally ok

Tue, Apr 20, 17:05
majcosta accepted D9434: Swap relay pool and mempool lookup.
Tue, Apr 20, 16:52
majcosta accepted D9432: test: refactor functional tests to use restart_node.
Tue, Apr 20, 16:51
majcosta accepted D9431: test: move sync_blocks and sync_mempool functions to test_framework.py.
Tue, Apr 20, 16:44

Fri, Apr 16

majcosta accepted D9427: Add some release notes for 0.23.2.
Fri, Apr 16, 20:03
majcosta accepted D9426: Bump version to 0.23.2.
Fri, Apr 16, 18:01

Wed, Apr 14

majcosta accepted D9415: [SECP256K1] Fix CI builds and badge links.
Wed, Apr 14, 07:52
majcosta accepted D9408: [SECP256K1] Remove num/gmp support.

got it

Wed, Apr 14, 07:51
majcosta accepted D9412: [SECP256K1] Make scalar_inverse{,_var} benchmark scale with SECP256K1_BENCH_ITERS.
Wed, Apr 14, 00:09
majcosta accepted D9411: [SECP256K1] Optimization: track f,g limb count and pass to new variable-time update_fg_var.
Wed, Apr 14, 00:08
majcosta accepted D9410: [SECP256K1] Optimization: use formulas instead of lookup tables for cancelling g bits.
Wed, Apr 14, 00:01

Tue, Apr 13

majcosta accepted D9409: [SECP256K1] Optimization: special-case zero modulus limbs in modinv64.
Tue, Apr 13, 23:58
majcosta added inline comments to D9408: [SECP256K1] Remove num/gmp support.
Tue, Apr 13, 23:53
majcosta requested changes to D9408: [SECP256K1] Remove num/gmp support.

the commit in the summary does not match the description in the summary. I assume https://github.com/bitcoin-core/secp256k1/pull/831/commits/1f233b3fa05eb29a744487e0682d925055fb0d4c is missing from the summary?

Tue, Apr 13, 23:33
majcosta accepted D9407: [SECP256K1] Remove unused scalar_sqr.
Tue, Apr 13, 23:29
majcosta accepted D9406: [SECP256K1] Improve field/scalar inverse tests.
Tue, Apr 13, 23:25
majcosta accepted D9405: [SECP256K1] Make field/scalar code use the new modinv modules for inverses.
Tue, Apr 13, 23:09
majcosta accepted D9404: [SECP256K1] Move secp256k1_scalar_{inverse{_var},is_even} and secp256k1_fe_inverse{_var} to per-impl files.
Tue, Apr 13, 22:37
majcosta accepted D9403: [SECP256K1] Improve bounds checks in modinv modules.
Tue, Apr 13, 21:23
majcosta accepted D9402: [SECP256K1] Add safegcd based modular inverse modules.
Tue, Apr 13, 21:11
majcosta accepted D9401: [SECP256K1] Add secp256k1_ctz{32,64}_var functions.
Tue, Apr 13, 19:10

Thu, Apr 8

majcosta accepted D9389: [SECP256K1] ctime_test: move context randomization test to the end.
Thu, Apr 8, 16:10
majcosta accepted D9388: [SECP256K1] Use bit ops instead of int mult for constant-time logic in gej_add_ge.
Thu, Apr 8, 16:05
majcosta closed D9371: [avalanche] delay executing avalanche event loop until IBD is done.
Thu, Apr 8, 16:03
majcosta committed rABCa5c12c9a2c57: [avalanche] delay executing avalanche event loop until IBD is done (authored by majcosta).
[avalanche] delay executing avalanche event loop until IBD is done
Thu, Apr 8, 16:03

Wed, Apr 7

majcosta updated the diff for D9371: [avalanche] delay executing avalanche event loop until IBD is done.

went with simpler

Wed, Apr 7, 15:35

Tue, Apr 6

majcosta requested review of D9371: [avalanche] delay executing avalanche event loop until IBD is done.
Tue, Apr 6, 18:49

Fri, Apr 2

majcosta accepted D9366: Add some release notes for 0.23.1.
Fri, Apr 2, 13:58
majcosta accepted D9367: Add a checkpoint at block height 680140.

double checked hash, ok

Fri, Apr 2, 13:58

Fri, Mar 26

majcosta accepted D9354: [website] Add OKEX to list of exchanges.
Fri, Mar 26, 17:25
majcosta requested changes to D9345: [avalanche] set a minimum amount for a proof.
Fri, Mar 26, 14:17

Mar 19 2021

majcosta accepted D9334: Add -netinfo peer connections dashboard.
Mar 19 2021, 19:12
majcosta accepted D9335: Cleanup the seeder list.
Mar 19 2021, 14:55

Mar 17 2021

majcosta accepted D9326: net: Extract download permission from noban.
Mar 17 2021, 14:20
majcosta accepted D9325: doc: Extract net permissions doc.
Mar 17 2021, 13:41
majcosta accepted D9324: Prepare docs for the next minor version bump.
Mar 17 2021, 13:32

Mar 11 2021

majcosta accepted D9316: Signal the avalanche service if avalanche is enabled.
Mar 11 2021, 13:18

Mar 10 2021

majcosta accepted D9290: [avalanche] implement getavalanchepeerinfo.

lgtm, just a few suggestions for conciseness

Mar 10 2021, 14:43
majcosta accepted D9312: [Cashtab] Form elements to themed styled components.
Mar 10 2021, 09:25

Mar 9 2021

majcosta requested changes to D9290: [avalanche] implement getavalanchepeerinfo.
Mar 9 2021, 22:48
majcosta accepted D9311: refactor: Replace RecursiveMutex with Mutex in warnings.cpp.
Mar 9 2021, 19:23
majcosta added a comment to D9311: refactor: Replace RecursiveMutex with Mutex in warnings.cpp.

@bot build-tsan

Mar 9 2021, 17:25
majcosta accepted D9310: refactor: Replace RecursiveMutex with Mutex in timedata.cpp.
Mar 9 2021, 15:38
majcosta accepted D9309: refactor: Replace RecursiveMutex with Mutex in netbase.cpp.
Mar 9 2021, 15:35

Mar 4 2021

majcosta accepted D9297: add "unofficial" to the image link for the BCHA telegram group.
Mar 4 2021, 19:30

Mar 3 2021

majcosta accepted D9285: [Cashtab] Migrate some css to styled components.
Mar 3 2021, 16:06
majcosta accepted D9295: [QT] Undim the validation button as the user updates the validated field.
Mar 3 2021, 15:52
majcosta requested changes to D9294: [QT] Improve validated fields responsiveness.
Mar 3 2021, 13:21
majcosta requested changes to D9290: [avalanche] implement getavalanchepeerinfo.
Mar 3 2021, 11:11

Mar 1 2021

majcosta accepted D9277: doc: noban precludes maxuploadtarget disconnects.
Mar 1 2021, 15:49
majcosta accepted D9284: Increase timeout for abc_p2p_fullblocktest.
Mar 1 2021, 11:47

Feb 28 2021

majcosta accepted D9283: [Cashtab] Add commas to formatted displays of large numbers.
Feb 28 2021, 14:20
majcosta accepted D9282: [Cashtab] Improve nav buttons.

Macro likestamp:

Feb 28 2021, 14:13
majcosta accepted D9281: [Cashtab] Move toSmallestDenomination function to utils.
Feb 28 2021, 14:07

Feb 25 2021

majcosta accepted D9279: refactor: Replace RecursiveMutex with Mutex in Shutdown().
Feb 25 2021, 20:12
majcosta accepted D9278: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC call.
Feb 25 2021, 19:58
majcosta requested changes to D9277: doc: noban precludes maxuploadtarget disconnects.
Feb 25 2021, 19:55
majcosta accepted D9276: [test] CScriptNum Decode Check as Unit Tests.
Feb 25 2021, 19:51
majcosta accepted D9275: validation: delay flushing undo files in syncing node case.
Feb 25 2021, 13:39

Feb 24 2021

majcosta accepted D9274: [website] Add Kucoin back to list of exchanges.
Feb 24 2021, 23:42
majcosta accepted D9273: test: type hints in Python tests.
Feb 24 2021, 20:23
majcosta accepted D9269: validation: Make VerifyDB level 4 interruptible.
Feb 24 2021, 11:54
majcosta accepted D9268: validation: use std::chrono in CChainState::FlushStateToDisk().
Feb 24 2021, 11:53
majcosta accepted D9267: [WEBSITE] Fix fetching the latest release notes.
Feb 24 2021, 03:04
majcosta accepted D9266: Bump version to 0.22.15.
Feb 24 2021, 00:08

Feb 23 2021

majcosta accepted D9265: test: Add missing sync_blocks to wallet_hd.
Feb 23 2021, 18:31
majcosta accepted D9264: Limit scope of all global std::once_flag.
Feb 23 2021, 18:30
majcosta accepted D9260: qt: Fix shutdown when waitfor* cmds are called from RPC console.
Feb 23 2021, 17:14
majcosta accepted D9261: test: Explain that a bug should be filed when the test fail.
Feb 23 2021, 17:08
majcosta accepted D9262: tests: implement base58_decode.
Feb 23 2021, 17:06
majcosta accepted D9263: Update links in CONTRIBUTE.md.
Feb 23 2021, 17:05
majcosta closed D9259: [backport#18637] coins: allow cache resize after init.
Feb 23 2021, 15:18
majcosta committed rABC8af6d9df957b: [backport#18637] coins: allow cache resize after init (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#18637] coins: allow cache resize after init
Feb 23 2021, 15:18
majcosta updated the test plan for D9259: [backport#18637] coins: allow cache resize after init.
Feb 23 2021, 15:04
majcosta updated the diff for D9259: [backport#18637] coins: allow cache resize after init.

modified comments pertaining to function arguments to not be reliant on a particular formatting (// to /* */)

Feb 23 2021, 14:58
majcosta updated the summary of D9259: [backport#18637] coins: allow cache resize after init.
Feb 23 2021, 13:50
majcosta updated the diff for D9259: [backport#18637] coins: allow cache resize after init.

fix -Werror=ignored-qualifiers

Feb 23 2021, 13:49
majcosta requested review of D9259: [backport#18637] coins: allow cache resize after init.
Feb 23 2021, 10:46
majcosta closed D9258: [buildbot] make bot link to backports of core-gui repo.
Feb 23 2021, 10:45
majcosta committed rABC5c69fab896b6: [buildbot] make bot link to backports of core-gui repo (authored by majcosta).
[buildbot] make bot link to backports of core-gui repo
Feb 23 2021, 10:45
majcosta accepted D9257: qt: Fix regression in TransactionTableModel.
Feb 23 2021, 09:40
majcosta accepted D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..
Feb 23 2021, 09:40
majcosta requested changes to D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..

now you reverted PR19132's changes completely

Feb 23 2021, 08:10
majcosta updated the test plan for D9258: [buildbot] make bot link to backports of core-gui repo.
Feb 23 2021, 00:45
majcosta updated the diff for D9258: [buildbot] make bot link to backports of core-gui repo.

updated backporting.md

Feb 23 2021, 00:04

Feb 22 2021

majcosta planned changes to D9258: [buildbot] make bot link to backports of core-gui repo.

fixing docs

Feb 22 2021, 23:35
majcosta updated the diff for D9258: [buildbot] make bot link to backports of core-gui repo.

added test cases and removed test cases that no longer apply (the number of digits in PRs are no longer in the code)

Feb 22 2021, 23:34
majcosta planned changes to D9258: [buildbot] make bot link to backports of core-gui repo.

making the tests happy

Feb 22 2021, 22:42
majcosta updated the summary of D9258: [buildbot] make bot link to backports of core-gui repo.
Feb 22 2021, 22:41
majcosta requested review of D9258: [buildbot] make bot link to backports of core-gui repo.
Feb 22 2021, 22:39
majcosta added a comment to D9257: qt: Fix regression in TransactionTableModel.
In D9257#210616, @PiRK wrote:

Ok wigh core-gui. But something need to be done about the automatic " PRxxxx to URL" conversion.

Feb 22 2021, 20:59
majcosta accepted D9250: [Cashtab] Enable special features if wallet has specific eToken.
Feb 22 2021, 20:22
majcosta abandoned D8633: [refactor] use compile time string_view for DBKeys.

yea this ain't worth it

Feb 22 2021, 20:02
majcosta requested changes to D9250: [Cashtab] Enable special features if wallet has specific eToken.
Feb 22 2021, 19:50