Page MenuHomePhabricator

majcosta (Marco Costa)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2018, 14:09 (271 w, 4 d)

Recent Activity

Aug 24 2023

majcosta closed D14404: refactor: remove c-string interfaces for DecodeBase58{Check}.
Aug 24 2023, 12:11
majcosta committed rABC257c857d0321: refactor: remove c-string interfaces for DecodeBase58{Check} (authored by Wladimir J. van der Laan <laanwj@protonmail.com>).
refactor: remove c-string interfaces for DecodeBase58{Check}
Aug 24 2023, 12:11
majcosta requested review of D14404: refactor: remove c-string interfaces for DecodeBase58{Check}.
Aug 24 2023, 11:15

May 4 2023

majcosta closed D13861: add missing #include <cstdint> where needed.
May 4 2023, 15:39
majcosta committed rABC8896bdccea9e: add missing #include <cstdint> where needed (authored by majcosta).
add missing #include <cstdint> where needed
May 4 2023, 15:39
majcosta closed D13860: [backport#26924] refactor: Add missing includes to fix gcc-13 compile error.
May 4 2023, 15:39
majcosta committed rABCb2d05c54b699: [backport#26924] refactor: Add missing includes to fix gcc-13 compile error (authored by fanquake <fanquake@gmail.com>).
[backport#26924] refactor: Add missing includes to fix gcc-13 compile error
May 4 2023, 15:39
majcosta updated the summary of D13861: add missing #include <cstdint> where needed.
May 4 2023, 15:19
majcosta updated the summary of D13861: add missing #include <cstdint> where needed.
May 4 2023, 15:19
majcosta updated the summary of D13860: [backport#26924] refactor: Add missing includes to fix gcc-13 compile error.
May 4 2023, 15:17
majcosta updated the test plan for D13860: [backport#26924] refactor: Add missing includes to fix gcc-13 compile error.
May 4 2023, 15:14
majcosta requested review of D13861: add missing #include <cstdint> where needed.
May 4 2023, 15:14
majcosta requested review of D13860: [backport#26924] refactor: Add missing includes to fix gcc-13 compile error.
May 4 2023, 15:13

Apr 21 2023

majcosta closed D13752: [docs] fix broken link in CONTRIBUTING.md file.
Apr 21 2023, 20:01
majcosta committed rABC6955f9382501: [docs] fix broken link in CONTRIBUTING.md file (authored by majcosta).
[docs] fix broken link in CONTRIBUTING.md file
Apr 21 2023, 20:01
majcosta requested review of D13752: [docs] fix broken link in CONTRIBUTING.md file.
Apr 21 2023, 05:07

Jan 4 2023

majcosta accepted D12946: [cmake] Fix a potential version mismatch in BerkeleyDB.
Jan 4 2023, 14:53

Dec 15 2022

majcosta closed D12897: [backport#19379] tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...).
Dec 15 2022, 00:29
majcosta committed rABC312733002f4a: [backport#19379] tests: Add fuzzing harness for SigHasLowR(...) and… (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#19379] tests: Add fuzzing harness for SigHasLowR(...) and…
Dec 15 2022, 00:29

Dec 14 2022

majcosta abandoned D9887: tests: consistently use underscores for functional tests.
Dec 14 2022, 21:38
majcosta abandoned D9463: [cashtab] add arcanist linter support for eslint.
Dec 14 2022, 21:38
majcosta added a comment to D12891: Streamline contributor instructions for Rust stuff.

This doesn't really work, I can pin the correct nightly rustfmt to the project but no without also pinning the rest of the nightly toolchain, which isn't necessarily desirable. Just gotta wait for stable rustfmt to catch up in features.

Dec 14 2022, 21:28
majcosta planned changes to D12891: Streamline contributor instructions for Rust stuff.
Dec 14 2022, 20:54
majcosta requested review of D12897: [backport#19379] tests: Add fuzzing harness for SigHasLowR(...) and ecdsa_signature_parse_der_lax(...).
Dec 14 2022, 20:12
majcosta accepted D12892: [doc] Fix incorrect argument syntax for --timeout-factor.
Dec 14 2022, 19:59
majcosta updated the diff for D12891: Streamline contributor instructions for Rust stuff.

rebase

Dec 14 2022, 19:50
majcosta updated the diff for D12891: Streamline contributor instructions for Rust stuff.

use what rustup does, $HOME is more reliable than ~ anyway

Dec 14 2022, 19:10
majcosta planned changes to D12891: Streamline contributor instructions for Rust stuff.

one sec

Dec 14 2022, 18:36
majcosta requested review of D12891: Streamline contributor instructions for Rust stuff.
Dec 14 2022, 18:12

Dec 13 2022

majcosta abandoned D8693: [CashTab] Expo - Initial setup with loading and webview. Working only on Android.
Dec 13 2022, 23:13

Dec 10 2022

majcosta added inline comments to D12839: [Cashtab] Better code comments in parseChronikTx.
Dec 10 2022, 16:23

Nov 2 2022

majcosta abandoned D12405: avalanche: add 'finalized' field to getblockstats.

Yea, after pushing this, "blockstats" does not seem to be the right place to get Avalanche finalization status as well. Abandoning.

Nov 2 2022, 00:06

Nov 1 2022

majcosta requested review of D12405: avalanche: add 'finalized' field to getblockstats.
Nov 1 2022, 02:40

Sep 7 2022

majcosta abandoned D9975: avalanche: method to get std::vector<avalanche::Node> associated with a PeerId.
Sep 7 2022, 18:31
majcosta abandoned D9697: make nExtraNonce static to IncrementExtraNonce.
Sep 7 2022, 18:30

Nov 23 2021

majcosta accepted D10513: doc: Add anchors.dat to files.md.
Nov 23 2021, 23:18
majcosta accepted D10512: p2p: Try to connect to anchors once.
Nov 23 2021, 23:17
majcosta accepted D10511: p2p: Fix off-by-one error in fetching address loop.
Nov 23 2021, 23:16
majcosta accepted D10510: p2p: Integrate DumpAnchors() and ReadAnchors() into CConnman.

correct commit link is: https://github.com/bitcoin/bitcoin/pull/17428/commits/4170b46544231e7cf1d64ac3baa314083be37502

Nov 23 2021, 23:15
majcosta accepted D10509: p2p: Add CConnman::GetCurrentBlockRelayOnlyConns().
Nov 23 2021, 23:12
majcosta accepted D10508: p2p: Add ReadAnchors().
Nov 23 2021, 22:19
majcosta accepted D10507: p2p: Add DumpAnchors().
Nov 23 2021, 22:12

Nov 11 2021

majcosta accepted D10462: test: add p2p_lock acquires in p2p_leak_tx.py.
Nov 11 2021, 19:45
majcosta accepted D10461: test: use MiniWallet for p2p_leak_tx.py.
Nov 11 2021, 19:44
majcosta accepted D10460: Avoid the use of abs64 in timedata.
Nov 11 2021, 19:32
majcosta accepted D10458: test: Add tests for CNode::ConnectedThroughNetwork.
Nov 11 2021, 19:20
majcosta accepted D10457: net: Add CNode::ConnectedThroughNetwork member function.
Nov 11 2021, 19:14
majcosta accepted D10456: net: Add CNode::m_inbound_onion data member.
Nov 11 2021, 18:56

Nov 10 2021

majcosta accepted D10446: net, refactor: Refactor CBaseChainParams::RPCPort function.
Nov 10 2021, 06:47
majcosta accepted D10449: net, refactor: Move AddLocal call one level up.

tested ok locally, clang-tidy being flaky

Nov 10 2021, 06:46
majcosta accepted D10451: doc: Update onion service target port numbers in tor.md.
Nov 10 2021, 06:46
majcosta accepted D10450: net: Extend -bind config option with optional network type.
Nov 10 2021, 06:45
majcosta accepted D10448: net: Pass onion service target to Tor controller.
Nov 10 2021, 06:35
majcosta accepted D10447: refactor: Rename TorController::target to m_tor_control_center.
Nov 10 2021, 06:32
majcosta accepted D10445: net: Add alternative port for onion service.
Nov 10 2021, 06:29
majcosta accepted D10444: net: Use network byte order for in_addr.s_addr.
Nov 10 2021, 06:29

Nov 9 2021

majcosta added a comment to D10440: [avalanche] Remove getPeerId.

hm getPeerId isn't used as an accessor anywhere, so you're simplifying one function at the cost of more code everywhere else

Nov 9 2021, 00:06

Nov 2 2021

majcosta accepted D10416: ProcessOrphanTx: Remove aliases.
Nov 2 2021, 20:49
majcosta accepted D10415: ProcessOrphanTx: Remove outdated comment.
Nov 2 2021, 20:46
majcosta accepted D10414: ProcessOrphanTx: remove useless setMisbehaving set.
Nov 2 2021, 20:45
majcosta accepted D10422: test: Get rid of default wallet hacks.

feature_dbcrash won't run with ninja check-functional, test plan needs ./test/functional/test_runner.py --extended for that

Nov 2 2021, 20:14
majcosta accepted D10428: RPC: remove duplicate line in getblock help.
Nov 2 2021, 20:13
majcosta accepted D10426: net: rename CNetAddr scopeId to m_scope_id, improve code doc.
Nov 2 2021, 20:10
majcosta accepted D10425: test: add test coverage for CNetAddr ipv6 scoped addresses.
Nov 2 2021, 20:09
majcosta accepted D10423: Improve invalid vout value rpc error message.
Nov 2 2021, 20:08
majcosta accepted D10429: util: Do not use gArgs global in ArgsManager member functions.
Nov 2 2021, 20:07
majcosta accepted D10421: test, refactor: add default_wallet_name and wallet_data_filename variables.
Nov 2 2021, 19:46
majcosta accepted D10420: doc: Clarify scope of eviction protection of outbound block-relay peers.
Nov 2 2021, 19:33
majcosta accepted D10419: rpc: Set HTTP Content-Type in bitcoin-cli.
Nov 2 2021, 19:23
majcosta accepted D10418: [tests] Replace bytes literals with hex literals.
Nov 2 2021, 19:19
majcosta accepted D10417: [tests] Remove unused optional verify_checksum parameter.

I believe the link in the summary should be https://github.com/bitcoin/bitcoin/pull/19253/commits/7f639df0b8a15aaeccedab00b634925f568c2c9a ?

Nov 2 2021, 19:17
majcosta requested changes to D10416: ProcessOrphanTx: Remove aliases.

oh, these are all D10414 's fault

Nov 2 2021, 18:56
majcosta requested changes to D10415: ProcessOrphanTx: Remove outdated comment.

ci fail

Nov 2 2021, 18:50
majcosta accepted D10413: ProcessOrphanTx: remove useless done variable.
Nov 2 2021, 18:44
majcosta requested changes to D10414: ProcessOrphanTx: remove useless setMisbehaving set.

apparently MAX_NON_STANDARD_ORPHAN_PER_NODE is also unused now

Nov 2 2021, 18:16
majcosta accepted D10412: [net processing] Add doxygen comments for orphan data and function.
Nov 2 2021, 17:48
majcosta accepted D10411: Fix misleading error message: Clean stack rule.
Nov 2 2021, 17:43

Sep 10 2021

majcosta accepted D10075: remove argName nBlocks from estimatefee RPC command registration.
Sep 10 2021, 15:38
majcosta accepted D10074: rpc: document returned error fields as optional if applicable.
Sep 10 2021, 15:37

Sep 9 2021

majcosta accepted D10089: Refactor OutputGroups to handle effective values, fees, and filtering.
Sep 9 2021, 18:26
majcosta accepted D10088: Use real value when calculating OutputGroup value.
Sep 9 2021, 18:21
majcosta accepted D10085: wallet: Don't override signing errors.
Sep 9 2021, 18:20
majcosta accepted D10010: rpc: Update server to use new RPCHelpMan.
Sep 9 2021, 18:13

Sep 8 2021

majcosta requested changes to D10075: remove argName nBlocks from estimatefee RPC command registration.

linter be mad

Sep 8 2021, 15:41
majcosta requested changes to D10074: rpc: document returned error fields as optional if applicable.
Sep 8 2021, 15:40
majcosta accepted D10073: Cap listsinceblock target_confirmations param.
Sep 8 2021, 15:37
majcosta accepted D10072: rpc: Improve addnode remove command error message.
Sep 8 2021, 15:36
majcosta accepted D10071: [net] Add addpeeraddress RPC method.
Sep 8 2021, 15:31
majcosta accepted D10070: [test] Test that getnodeaddresses() can return all known addresses.

nit: link to the specific commit in the summary is wrong, points to 3/3 rather than 2/3

Sep 8 2021, 15:26
majcosta accepted D10069: [addrman] Specify max addresses and pct when calling GetAddresses().
Sep 8 2021, 15:08

Sep 7 2021

majcosta accepted D10068: refactor: test: use _ variable for unused loop counters.
Sep 7 2021, 15:56
majcosta accepted D10067: Deduplicate missing parents of orphan transactions.
Sep 7 2021, 14:12
majcosta accepted D10066: Rewrite parent txid loop of requested transactions.
Sep 7 2021, 13:55
majcosta accepted D10065: test: Wait for 'cmpctblock' in p2p_compactblocks when it is expected.
Sep 7 2021, 13:48
majcosta accepted D10063: test: Wait until is_connected in add_p2p_connection.
Sep 7 2021, 13:44
majcosta accepted D10064: test: use the correct DISCOURAGEMENT_THRESHOLD.

cool

Sep 7 2021, 13:41
majcosta accepted D10062: doc: Replace `hidden service` with `onion service`.
Sep 7 2021, 13:38
majcosta accepted D10060: util: use HAVE_FDATASYNC to determine fdatasync() use.
Sep 7 2021, 13:31
majcosta accepted D10059: Preserve the LockData initial state if "potential deadlock detected" exception thrown.
Sep 7 2021, 13:27
majcosta accepted D10058: rpc: Document getwalletinfo's unlocked_until field as optional.
Sep 7 2021, 13:22