Page MenuHomePhabricator

majcosta (Marco Costa)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2018, 14:09 (137 w, 6 d)

Recent Activity

Tue, Jul 27

majcosta accepted D9837: [doc] start a developer documentation for avalanche.
Tue, Jul 27, 15:05
majcosta accepted D9841: [avalanche] Fix the getavalanchepeerinfo help.
Tue, Jul 27, 15:05

Mon, Jul 26

majcosta accepted D9838: [LINTER] Handle errors from the Prettier linter.
Mon, Jul 26, 19:29

Fri, Jul 23

majcosta closed D9835: add some release notes for 0.23.9.
Fri, Jul 23, 17:42
majcosta committed rABC471fa6e36e42: add some release notes for 0.23.9 (authored by majcosta).
add some release notes for 0.23.9
Fri, Jul 23, 17:42
majcosta requested review of D9835: add some release notes for 0.23.9.
Fri, Jul 23, 17:29

Wed, Jul 21

majcosta accepted D9827: rpc_net.py: sync blocks before mining a new block on node1.
Wed, Jul 21, 10:54

Tue, Jul 20

majcosta accepted D9826: [website] Add missing div tag on ecash page.
Tue, Jul 20, 21:04
majcosta accepted D9825: validation: Remove review-only comments + assertions.
Tue, Jul 20, 19:11
majcosta accepted D9824: docs: Move FindFilesToPrune{,Manual} doxygen comment.
Tue, Jul 20, 19:11
majcosta accepted D9823: validation: Move FindFilesToPrune{,Manual} to BlockManager.
Tue, Jul 20, 18:57
majcosta accepted D9822: validation: Move PruneOneBlockFile to BlockManager.
Tue, Jul 20, 18:47
majcosta accepted D9821: validation: Pass in chainman to UnloadBlockIndex.
Tue, Jul 20, 18:14
majcosta accepted D9820: validation: Move ~CMainCleanup logic to ~BlockManager.
Tue, Jul 20, 18:09
majcosta accepted D9816: make copyright headers more consistent.
Tue, Jul 20, 18:05
majcosta accepted D9804: Rebrand comments from C++ source files.
Tue, Jul 20, 14:47
majcosta accepted D9805: Rebrand the comments in wallet_avoidreuse.py.
Tue, Jul 20, 14:46

Mon, Jul 19

majcosta requested changes to D9805: Rebrand the comments in wallet_avoidreuse.py.

what about abbreviating the million? I read that 'MM' is most common than 'm' or 'mil' so, use 1MM XEC instead of 1,000,000 seems to nicely avoid unnecessary zeroes

Mon, Jul 19, 18:37
majcosta requested changes to D9804: Rebrand comments from C++ source files.
Mon, Jul 19, 18:17

Fri, Jul 16

majcosta closed D9781: [avalanche] create an avalanche log category and use it.
Fri, Jul 16, 18:37
majcosta committed rABC8918cb8d71c4: [avalanche] create an avalanche log category and use it (authored by majcosta).
[avalanche] create an avalanche log category and use it
Fri, Jul 16, 18:37
majcosta requested changes to D9760: [cashtab] Internationalization: Switch from fbt to react-intl.
Fri, Jul 16, 18:15
majcosta added a comment to D9760: [cashtab] Internationalization: Switch from fbt to react-intl.

looks like something broke the tests, back to your queue

Fri, Jul 16, 18:14
majcosta closed D9795: Bump version to 0.23.9.
Fri, Jul 16, 18:05
majcosta committed rABC865eae92881f: Bump version to 0.23.9 (authored by majcosta).
Bump version to 0.23.9
Fri, Jul 16, 18:05

Thu, Jul 15

majcosta requested review of D9795: Bump version to 0.23.9.
Thu, Jul 15, 15:49

Tue, Jul 13

majcosta updated the test plan for D9781: [avalanche] create an avalanche log category and use it.
Tue, Jul 13, 22:07
majcosta requested review of D9781: [avalanche] create an avalanche log category and use it.
Tue, Jul 13, 21:22
majcosta accepted D9779: [avalanche] Improve the delegateavalancheproof error messages.
Tue, Jul 13, 15:42
majcosta accepted D9775: [core#19724 6/9][refactor] Simplify check for block-relay-only connection..
Tue, Jul 13, 14:17

Mon, Jul 12

majcosta accepted D9778: [core#19724 9/9][doc] Follow developer notes, add comment about missing default..
Mon, Jul 12, 21:24
majcosta accepted D9777: [core#19724 8/9][doc] Describe connection types in more depth..
Mon, Jul 12, 21:24
majcosta accepted D9776: [core#19724 7/9][refactor] Simplify connection type logic in ThreadOpenConnections.
Mon, Jul 12, 21:21
majcosta requested changes to D9775: [core#19724 6/9][refactor] Simplify check for block-relay-only connection..

tests broke

Mon, Jul 12, 21:19
majcosta accepted D9774: [core#19724 5/9][test] Add explicit tests that connection types get set correctly.
Mon, Jul 12, 21:14
majcosta accepted D9773: [core#19724 4/9][doc] Explain address handling logic in process messages.
Mon, Jul 12, 19:14
majcosta accepted D9772: [core#19724 3/9][refactor] Restructure logic to check for addr relay..
Mon, Jul 12, 18:17
majcosta accepted D9771: [core#19724 2/9][net] Remove unnecessary default args on OpenNetworkConnection.
Mon, Jul 12, 17:52
majcosta accepted D9770: [core#19724 1/9] scripted-diff: Rename OUTBOUND ConnectionType to OUTBOUND_FULL_RELAY.
Mon, Jul 12, 17:41
majcosta accepted D9768: [avalanche] Do not bucket brigade proof registration.
Mon, Jul 12, 17:29
majcosta accepted D9767: [avalanche] Move the proof accessor tests to the peer manager tests.
Mon, Jul 12, 13:50

Sat, Jul 10

majcosta accepted D9763: [avalanche] Do not bucket brigade broadcast handling.
Sat, Jul 10, 14:33
majcosta accepted D9764: Remove Processor::forNode.
Sat, Jul 10, 14:22

Fri, Jul 9

majcosta requested changes to D9760: [cashtab] Internationalization: Switch from fbt to react-intl.
  • extension/src/components/App.js still has fbt imports and tags
  • .gitignore still has an fbt related file section
  • test plan doesn't test all changes
Fri, Jul 9, 12:40

Thu, Jul 8

majcosta accepted D9759: functional tests: Remove portseed_offset from test runner.
Thu, Jul 8, 15:21
majcosta accepted D9758: Pass mempool pointer to GetCoinsCacheSizeState.
Thu, Jul 8, 14:32
majcosta accepted D9757: Pass mempool pointer to UnloadBlockIndex.
Thu, Jul 8, 13:57

Wed, Jul 7

majcosta accepted D9746: [avalanche] Use proof registration time instead of "proof time".
Wed, Jul 7, 18:48
majcosta closed D9743: remove boost::noncopyable dependency.
Wed, Jul 7, 13:53
majcosta committed rABC40cbef2d958e: remove boost::noncopyable dependency (authored by majcosta).
remove boost::noncopyable dependency
Wed, Jul 7, 13:53
majcosta accepted D9745: Remove the deprecated setexcessiveblock RPC.
Wed, Jul 7, 12:22
majcosta accepted D9744: Prevent setting -blockmaxsize and -excessiveblocksize <= 0.
Wed, Jul 7, 12:00

Tue, Jul 6

majcosta requested review of D9743: remove boost::noncopyable dependency.
Tue, Jul 6, 17:22
majcosta accepted D9741: [LINTER] Switch to clang-format 10.
Tue, Jul 6, 11:39

Mon, Jul 5

majcosta accepted D9736: [core#19011 3/3] Reduce cs_main lock accumulation during GUI startup.
Mon, Jul 5, 19:02
majcosta accepted D9737: [core#19104] gui, refactor: Register Qt meta types in application constructor.
Mon, Jul 5, 16:07
majcosta requested changes to D9737: [core#19104] gui, refactor: Register Qt meta types in application constructor.
Mon, Jul 5, 13:28

Jul 3 2021

majcosta accepted D9733: [Cashtab] Get change address from sending utxo.
Jul 3 2021, 17:46
majcosta accepted D9732: reduce size of bg file for better load times.
Jul 3 2021, 11:42

Jul 2 2021

majcosta accepted D9731: Fix mistakenly swapped lock orders in logging.
Jul 2 2021, 11:37

Jul 1 2021

majcosta accepted D9730: Fix dead link to Schnorr spec.
Jul 1 2021, 20:15
majcosta accepted D9729: Update Bitcoin Cash to eCash in secp256k1 README.
Jul 1 2021, 20:14
majcosta closed D9722: [website] Update mailing list signup to eCash.
Jul 1 2021, 11:18
majcosta committed rABCWEB7d88bb0a5ff1: [website] Update mailing list signup to eCash (authored by Mengerian).
[website] Update mailing list signup to eCash
Jul 1 2021, 11:18
majcosta closed D9726: [website] Update project description to eCash.
Jul 1 2021, 11:14
majcosta committed rABCWEB40c1aeaa187d: [website] Update project description to eCash (authored by Mengerian).
[website] Update project description to eCash
Jul 1 2021, 11:14
majcosta closed D9725: [website] Update header to point to ecash page.
Jul 1 2021, 11:13
majcosta committed rABCWEBe0691c401fae: [website] Update header to point to ecash page (authored by Mengerian).
[website] Update header to point to ecash page
Jul 1 2021, 11:13
majcosta closed D9724: [website] Add deprecation notice to BCHA page.
Jul 1 2021, 11:13
majcosta committed rABCWEBd9885c6fbb8c: [website] Add deprecation notice to BCHA page (authored by Mengerian).
[website] Add deprecation notice to BCHA page
Jul 1 2021, 11:13
majcosta closed D9723: [website] Add more info to eCash page.
Jul 1 2021, 11:08
majcosta committed rABCWEB2129330a93c0: [website] Add more info to eCash page (authored by Mengerian).
[website] Add more info to eCash page
Jul 1 2021, 11:08
majcosta closed D9721: [website] Change donation address to eCash.
Jul 1 2021, 11:02
majcosta committed rABCWEBe7d9ff290a24: [website] Change donation address to eCash (authored by Mengerian).
[website] Change donation address to eCash
Jul 1 2021, 11:02
majcosta accepted D9718: [Cashtab] Support for eCash rebrand.

tested ok

Jul 1 2021, 00:17

Jun 30 2021

majcosta accepted D9717: Bring README logo graphic into repo.
Jun 30 2021, 18:41
majcosta accepted D9716: Update README from BCHA to eCash.
Jun 30 2021, 16:50
majcosta accepted D9714: Work around memory-aliasing in descriptor ParsePubkey.
Jun 30 2021, 14:01
majcosta accepted D9713: net: Add -networkactive option.
Jun 30 2021, 13:46
majcosta accepted D9712: update /electrum page to eCash.
Jun 30 2021, 10:54

Jun 29 2021

majcosta accepted D9710: Fix the fuzzer for FormatVersion and FormatUserAgent.
Jun 29 2021, 08:51

Jun 24 2021

majcosta updated the diff for D9697: make nExtraNonce static to IncrementExtraNonce.

use uint32_t instead and use default std::memory_order_seq_cst for atomic increment

Jun 24 2021, 17:48
majcosta updated the diff for D9697: make nExtraNonce static to IncrementExtraNonce.

synchronize static variable, remove static uint256 hashPrevBlock which is now dead code

Jun 24 2021, 15:12
majcosta updated the diff for D9697: make nExtraNonce static to IncrementExtraNonce.

... do it consistently

Jun 24 2021, 09:37
majcosta updated the diff for D9697: make nExtraNonce static to IncrementExtraNonce.

use a smaller integer

Jun 24 2021, 09:10
majcosta updated the test plan for D9697: make nExtraNonce static to IncrementExtraNonce.
Jun 24 2021, 09:00
majcosta updated the diff for D9697: make nExtraNonce static to IncrementExtraNonce.

ensure nExtraNonce is changed in exactly one place, fix expected block hashes in rpc_dumptxoutset

Jun 24 2021, 08:59
majcosta planned changes to D9697: make nExtraNonce static to IncrementExtraNonce.

forgot the most important line

Jun 24 2021, 08:45
majcosta requested review of D9697: make nExtraNonce static to IncrementExtraNonce.
Jun 24 2021, 08:40

Jun 16 2021

majcosta requested changes to D9686: [avalanche] add a lock to CNode::AvalancheState.
Jun 16 2021, 19:40
majcosta accepted D9689: [tests] Remove unnecessary cs_mains in denialofservice_tests.
Jun 16 2021, 17:41

Jun 15 2021

majcosta abandoned D9020: [CashAddr] deprecate legacy prefixes maintaining backwards compatibility.

with the -ecash prefix, this seems less relevant. abandoning for now.

Jun 15 2021, 17:51

Jun 14 2021

majcosta accepted D9678: [test refactoring] move AvaP2PInterface to avatools.py.
Jun 14 2021, 21:47
majcosta closed D9674: refactor: consolidate both ecash CLI options under "-ecash".
Jun 14 2021, 00:02
majcosta committed rABC8cdc87e4fc85: refactor: consolidate both ecash CLI options under "-ecash" (authored by majcosta).
refactor: consolidate both ecash CLI options under "-ecash"
Jun 14 2021, 00:02
majcosta closed D9673: ecash: add XEC option to the GUI.
Jun 14 2021, 00:02
majcosta committed rABCa166d02a1fe2: ecash: add XEC option to the GUI (authored by majcosta).
ecash: add XEC option to the GUI
Jun 14 2021, 00:02

Jun 13 2021

majcosta closed D9672: use XEC or BCH for bitcoin-qt depending on CLI setting.
Jun 13 2021, 23:56
majcosta committed rABC97d936920f75: use XEC or BCH for bitcoin-qt depending on CLI setting (authored by majcosta).
use XEC or BCH for bitcoin-qt depending on CLI setting
Jun 13 2021, 23:56
majcosta updated the diff for D9674: refactor: consolidate both ecash CLI options under "-ecash".

remove now unnecessary DEFAULT_XEC constant

Jun 13 2021, 04:00