Page MenuHomePhabricator
People majcosta

majcosta (Marco Costa)
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 12 2018, 14:09 (58 w, 3 d)

Recent Activity
View All

Dec 19 2019

majcosta committed rABCf4ccfea4ad20: [backport] net: Allow connections from misbehavior banned peers (authored by Jonas Schnelli <dev@jonasschnelli.ch>).
[backport] net: Allow connections from misbehavior banned peers
Dec 19 2019, 21:59
majcosta closed D4759: [backport] net: Allow connections from misbehavior banned peers.
Dec 19 2019, 21:59
majcosta updated the diff for D4759: [backport] net: Allow connections from misbehavior banned peers.

Changed the if statement to obey coding style and removed spurious comment whitespace

Dec 19 2019, 20:10

Dec 18 2019

majcosta committed rABC3a6fe217920a: [backport] gui: Show messages as text not html (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
[backport] gui: Show messages as text not html
Dec 18 2019, 21:28
majcosta closed D4761: [backport] gui: Show messages as text not html.
Dec 18 2019, 21:28
majcosta created D4761: [backport] gui: Show messages as text not html.
Dec 18 2019, 20:25
majcosta created D4759: [backport] net: Allow connections from misbehavior banned peers.
Dec 18 2019, 19:00

Dec 13 2019

majcosta committed rABC826e21daed54: refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound (authored by fanquake <fanquake@gmail.com>).
refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound
Dec 13 2019, 23:54
majcosta closed D4722: refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound.
Dec 13 2019, 23:54
majcosta updated the diff for D4722: refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound.

included missing brackets around single line if statement

Dec 13 2019, 18:08
majcosta updated the summary of D4722: refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound.
Dec 13 2019, 18:04
majcosta updated the summary of D4722: refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound.
Dec 13 2019, 16:44
majcosta updated the diff for D4722: refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound.

accidentally removed brackets from single line if statement. corrected.

Dec 13 2019, 16:40
majcosta updated the diff for D4722: refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound.

added commits fea33cbbdfb4673033f3414bf1613591ff654aac and 59373e3e94015316bcaa03a7b9c2e6f442641720

Dec 13 2019, 16:35
majcosta planned changes to D4722: refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound.

going to add the other two commits to this revision

Dec 13 2019, 16:15
majcosta created D4722: refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound.
Dec 13 2019, 16:09

Dec 10 2019

majcosta committed rABC81c6819f381f: Log debug build status and warn when running benchmarks (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Log debug build status and warn when running benchmarks
Dec 10 2019, 22:04
majcosta closed D4687: Log debug build status and warn when running benchmarks.
Dec 10 2019, 22:04
majcosta updated the diff for D4687: Log debug build status and warn when running benchmarks.

removed spurious newlines

Dec 10 2019, 21:33
majcosta updated the test plan for D4687: Log debug build status and warn when running benchmarks.
Dec 10 2019, 21:00
majcosta updated the diff for D4687: Log debug build status and warn when running benchmarks.

reverting previous code to keep divergence from Core code to a minimum

Dec 10 2019, 20:59
majcosta created D4687: Log debug build status and warn when running benchmarks.
Dec 10 2019, 19:33

Dec 9 2019

majcosta committed rABCd688432ba632: Sanity-check script sizes in bitcoin-tx (authored by MarcoFalke <falke.marco@gmail.com>).
Sanity-check script sizes in bitcoin-tx
Dec 9 2019, 13:57
majcosta closed D4666: Sanity-check script sizes in bitcoin-tx.
Dec 9 2019, 13:57
majcosta created D4666: Sanity-check script sizes in bitcoin-tx.
Dec 9 2019, 08:07

Dec 5 2019

majcosta committed rABCa8257058a391: refactoring: add a method for determining if a block is pruned or not (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
refactoring: add a method for determining if a block is pruned or not
Dec 5 2019, 00:05
majcosta closed D4624: refactoring: add a method for determining if a block is pruned or not.
Dec 5 2019, 00:05

Dec 4 2019

majcosta added inline comments to D4624: refactoring: add a method for determining if a block is pruned or not.
Dec 4 2019, 02:04

Dec 3 2019

majcosta created D4624: refactoring: add a method for determining if a block is pruned or not.
Dec 3 2019, 20:55

Nov 30 2019

majcosta committed rABC1fd19cd4f4c0: Add const modifier to HTTPRequest methods (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Add const modifier to HTTPRequest methods
Nov 30 2019, 00:02
majcosta closed D4590: Add const modifier to HTTPRequest methods.
Nov 30 2019, 00:02

Nov 29 2019

majcosta updated the summary of D4590: Add const modifier to HTTPRequest methods.
Nov 29 2019, 23:44
majcosta created D4590: Add const modifier to HTTPRequest methods.
Nov 29 2019, 23:29

Nov 28 2019

majcosta committed rABCeb1893c84752: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal
Nov 28 2019, 00:35
majcosta closed D4570: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal.
Nov 28 2019, 00:35

Nov 27 2019

majcosta updated the test plan for D4570: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal.
Nov 27 2019, 23:45
majcosta updated the diff for D4570: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal.

removed declaration not in our codebase

Nov 27 2019, 23:42
majcosta committed rABC3c897918bfc3: previous link was dead (authored by majcosta).
previous link was dead
Nov 27 2019, 23:40
majcosta closed D4569: previous link was dead.
Nov 27 2019, 23:39
majcosta updated the diff for D4570: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal.

reverted inline comments

Nov 27 2019, 23:37
majcosta created D4570: Backport of Core PR14728: fix uninitialized read when stringifying an addrLocal.
Nov 27 2019, 23:02
majcosta added a reviewer for D4569: previous link was dead: jasonbcox.
Nov 27 2019, 21:20
majcosta created D4569: previous link was dead.
Nov 27 2019, 20:38

Nov 26 2019

majcosta committed rABC2b5019c182ce: Trivial: Corrected comment array name from pnSeeds6 to pnSeed6 (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Trivial: Corrected comment array name from pnSeeds6 to pnSeed6
Nov 26 2019, 23:40
majcosta closed D4553: Trivial: Corrected comment array name from pnSeeds6 to pnSeed6.
Nov 26 2019, 23:40
majcosta retitled D4553: Trivial: Corrected comment array name from pnSeeds6 to pnSeed6 from Backport of Bitcoin Core PR12986 https://github.com/bitcoin/bitcoin/pull/12986 to Trivial: Corrected comment array name from pnSeeds6 to pnSeed6.
Nov 26 2019, 23:19
majcosta created D4553: Trivial: Corrected comment array name from pnSeeds6 to pnSeed6.
Nov 26 2019, 23:18
majcosta abandoned D4544: simplified IsHexNumber function.
Nov 26 2019, 00:56
majcosta added a comment to D4544: simplified IsHexNumber function.

I understand. Gonna look for something more useful then. Closing.

Nov 26 2019, 00:56

Nov 25 2019

majcosta updated the diff for D4544: simplified IsHexNumber function.

changed function declaration to noexcept

Nov 25 2019, 23:15
majcosta updated the diff for D4544: simplified IsHexNumber function.

previous diff not clang-formatted properly. is now.

Nov 25 2019, 23:06
majcosta created D4544: simplified IsHexNumber function.
Nov 25 2019, 23:05

Nov 22 2019

majcosta committed rABCc8d1fedde875: minor refactor to use ranged_for, auto and const-ness (authored by majcosta).
minor refactor to use ranged_for, auto and const-ness
Nov 22 2019, 14:29
majcosta closed D4495: minor refactor to use ranged_for, auto and const-ness.
Nov 22 2019, 14:28
majcosta updated the diff for D4495: minor refactor to use ranged_for, auto and const-ness.

I have run the test using const auto &fileName and it did set off the -fsanitize=address giving me a stack-use-after-scope error, so I went back to by-value semantics. address,undefined and memory sanitizer reported no problems after that (except for one use-of-uninitialized-value on Boost)

Nov 22 2019, 06:33
majcosta updated the summary of D4495: minor refactor to use ranged_for, auto and const-ness.
Nov 22 2019, 05:43

Nov 21 2019

majcosta updated the diff for D4495: minor refactor to use ranged_for, auto and const-ness.

changed fileName from value to reference semantics

Nov 21 2019, 15:31

Nov 20 2019

majcosta added inline comments to D4495: minor refactor to use ranged_for, auto and const-ness.
Nov 20 2019, 22:31
majcosta created D4495: minor refactor to use ranged_for, auto and const-ness.
Nov 20 2019, 19:08

Jan 20 2019

majcosta committed rSTAGING04b7e8ba8b70: Added -Wmissing-braces to CXXFLAGS where supported by the compiler (authored by majcosta).
Added -Wmissing-braces to CXXFLAGS where supported by the compiler
Jan 20 2019, 23:52
majcosta committed rSTAGINGe63fa0268ce5: no more -Wmissing-braces warnings (authored by majcosta).
no more -Wmissing-braces warnings
Jan 20 2019, 23:52

Dec 19 2018

majcosta added a comment to T191: Fix missing-braces warnings..

D2191: no more -Wmissing-braces warnings

Dec 19 2018, 12:42 · Bootcamp

Dec 15 2018

majcosta committed rABC04b7e8ba8b70: Added -Wmissing-braces to CXXFLAGS where supported by the compiler (authored by majcosta).
Added -Wmissing-braces to CXXFLAGS where supported by the compiler
Dec 15 2018, 04:42
majcosta closed D2192: Added -Wmissing-braces to CXXFLAGS where supported by the compiler.
Dec 15 2018, 04:41

Dec 14 2018

Herald added a reviewer for D2192: Added -Wmissing-braces to CXXFLAGS where supported by the compiler: deadalnix.
Dec 14 2018, 15:00
majcosta committed rABCe63fa0268ce5: no more -Wmissing-braces warnings (authored by majcosta).
no more -Wmissing-braces warnings
Dec 14 2018, 11:49
majcosta closed D2191: no more -Wmissing-braces warnings.
Dec 14 2018, 11:48
Herald added a reviewer for D2191: no more -Wmissing-braces warnings: deadalnix.
Dec 14 2018, 09:21