Page MenuHomePhabricator

[tests] Remove unused optional verify_checksum parameter
ClosedPublic

Authored by PiRK on Nov 2 2021, 11:04.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABCe875608a68c0: [tests] Remove unused optional verify_checksum parameter
Summary

Commit description:

This optional parameter is never used, so remove it.

PR description:

Lots of small fixes:

moving unit tests to test_framework implementation files
renaming functions to be clearer
removing multiple imports
removing unreadable byte literals from the code
fixing pep8 violations
correcting out-of-date docstring

Most of the PR is related to segwit or code style, so only 2 out of 7 commits are relevant.

This is a backport of core#19253 [1/2]
https://github.com/bitcoin/bitcoin/pull/19253/commits/7f639df0b8a15aaeccedab00b634925f568c2c9a

Test Plan

ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable