Page MenuHomePhabricator
Differential D12839

[Cashtab] Better code comments in parseChronikTx
ClosedPublic
Actions

Authored by bytesofman on Dec 10 2022, 13:57.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCf535c6613afe: [Cashtab] Better code comments in parseChronikTx
Summary

T2853

Remove artifact comments related to now-defunct useBCH.js

Test Plan

Confirm this only impacts comments
npm start
tx history parses
Send an encrypted msg
Receive an encrypted msg

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Dec 10 2022, 13:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2022, 13:57
bytesofman requested review of this revision.Dec 10 2022, 13:57
Harbormaster completed remote builds in B21504: Diff 37176.Dec 10 2022, 13:59
majcosta added a subscriber: majcosta.Dec 10 2022, 16:23
majcosta added inline comments.
web/cashtab/src/utils/chronik.js
622 ↗(On Diff #37176)

typo

bytesofman updated this revision to Diff 37179.Dec 10 2022, 17:40

typo fix per feedback

bytesofman marked an inline comment as done.Dec 10 2022, 17:40
bytesofman added inline comments.
web/cashtab/src/utils/chronik.js
622 ↗(On Diff #37176)

good catch, fixed

Harbormaster completed remote builds in B21507: Diff 37179.Dec 10 2022, 17:42
emack accepted this revision.Dec 11 2022, 02:53
This revision is now accepted and ready to land.Dec 11 2022, 02:53
Closed by commit rABCf535c6613afe: [Cashtab] Better code comments in parseChronikTx (authored by bytesofman). · Explain WhyDec 11 2022, 06:21
This revision was automatically updated to reflect the committed changes.
bytesofman marked an inline comment as done.
bytesofman added a commit: rABCf535c6613afe: [Cashtab] Better code comments in parseChronikTx.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
utils/
12 lines

Diff 37207

View Options

web/cashtab/src/utils/chronik.js

Loading...