Page MenuHomePhabricator
Differential D10415

ProcessOrphanTx: Remove outdated comment
ClosedPublic
Actions

Authored by PiRK on Nov 2 2021, 10:45.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC062d88d5fea4: ProcessOrphanTx: Remove outdated comment
Summary

Also rename orphan_state to state. Both the comment and the variable
name are leftover from when this logic was part of ProcessMessage().

This is a backport of core#19498 [4/5]
https://github.com/bitcoin/bitcoin/pull/19498/commits/e07c5d94231cefb748f9534ab8ff0b3e2b04c4d8

Depends on D10414

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 2 2021, 10:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 2 2021, 10:45
PiRK requested review of this revision.Nov 2 2021, 10:45
teamcity edited the summary of this revision. (Show Details)Nov 2 2021, 10:45
PiRK added a child revision: D10416: ProcessOrphanTx: Remove aliases.Nov 2 2021, 10:48
Harbormaster completed remote builds in B17159: Diff 30729.Nov 2 2021, 11:11
teamcity added a comment.Nov 2 2021, 11:11
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[333/510] Building CXX object src/CMakeFiles/util.dir/util/error.cpp.o
[334/510] Building CXX object src/CMakeFiles/util.dir/util/message.cpp.o
[335/510] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[336/510] Building CXX object src/CMakeFiles/util.dir/util/settings.cpp.o
[337/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[338/510] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[339/510] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[340/510] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[341/510] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[342/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[343/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[344/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[345/510] Building CXX object src/CMakeFiles/util.dir/util/time.cpp.o
[346/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[347/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[348/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[349/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[350/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[351/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[352/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[353/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[354/510] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[355/510] Linking CXX static library src/libutil.a
[356/510] Linking CXX static library src/librpcclient.a
[357/510] Linking CXX static library src/libbitcoinconsensus.a
[358/510] Linking CXX static library src/libscript.a
[359/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[360/510] Linking CXX static library src/libcommon.a
[361/510] Linking CXX shared library src/libbitcoinconsensus.so.0.24.5
[362/510] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[363/510] Linking CXX executable src/bitcoin-cli
[364/510] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[365/510] Linking CXX executable src/bitcoin-tx
[366/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[367/510] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[368/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[369/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[370/510] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqutil.cpp.o
[371/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[372/510] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[373/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[374/510] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[375/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[376/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[377/510] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[378/510] Linking CXX static library src/zmq/libzmq.a
[379/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[380/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[381/510] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[382/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[383/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[384/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[385/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[386/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[387/510] Linking CXX static library src/wallet/libwallet.a
[388/510] Linking CXX static library src/wallet/libwallet-tool.a
[389/510] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
majcosta requested changes to this revision.Nov 2 2021, 18:50
majcosta added a subscriber: majcosta.

ci fail

This revision now requires changes to proceed.Nov 2 2021, 18:50
PiRK updated this revision to Diff 30756.Nov 2 2021, 20:18

rebase

Harbormaster completed remote builds in B17184: Diff 30756.Nov 2 2021, 20:38
majcosta accepted this revision.Nov 2 2021, 20:46
This revision is now accepted and ready to land.Nov 2 2021, 20:46
Closed by commit rABC062d88d5fea4: ProcessOrphanTx: Remove outdated comment (authored by John Newbery <john@johnnewbery.com>, committed by PiRK). · Explain WhyNov 3 2021, 07:09
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC062d88d5fea4: ProcessOrphanTx: Remove outdated comment.

Revision Contents
Changeset List

PathSize
src/
18 lines

Diff 30763

View Options

src/net_processing.cpp

Loading...