Page MenuHomePhabricator

rpc: document returned error fields as optional if applicable
ClosedPublic

Authored by PiRK on Wed, Sep 8, 14:13.

Details

Summary

Affects the following RPCs:

  • analyzepsbt
  • signrawtransactionwithkey
  • signrawtransactionwithwallet

We do not have the estimate(smart|raw)fee RPCs to update.

This is a backport of core#19644

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Wed, Sep 8, 14:13
majcosta requested changes to this revision.Wed, Sep 8, 15:40
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/rpc/rawtransaction.cpp
2068 ↗(On Diff #29855)
This revision now requires changes to proceed.Wed, Sep 8, 15:40
This revision is now accepted and ready to land.Fri, Sep 10, 15:37