This doesn't really work, I can pin the correct nightly rustfmt to the project but no without also pinning the rest of the nightly toolchain, which isn't necessarily desirable. Just gotta wait for stable rustfmt to catch up in features.

rebase

use what rustup does, $HOME is more reliable than ~ anyway

one sec

Yea, after pushing this, "blockstats" does not seem to be the right place to get Avalanche finalization status as well. Abandoning.

correct commit link is: https://github.com/bitcoin/bitcoin/pull/17428/commits/4170b46544231e7cf1d64ac3baa314083be37502

tested ok locally, clang-tidy being flaky

hm getPeerId isn't used as an accessor anywhere, so you're simplifying one function at the cost of more code everywhere else

feature_dbcrash won't run with ninja check-functional, test plan needs ./test/functional/test_runner.py --extended for that

I believe the link in the summary should be https://github.com/bitcoin/bitcoin/pull/19253/commits/7f639df0b8a15aaeccedab00b634925f568c2c9a ?

oh, these are all D10414 's fault

ci fail

apparently MAX_NON_STANDARD_ORPHAN_PER_NODE is also unused now

linter be mad

nit: link to the specific commit in the summary is wrong, points to 3/3 rather than 2/3

cool