Page MenuHomePhabricator
Feed Advanced Search

Thu, Feb 25

majcosta accepted D9279: refactor: Replace RecursiveMutex with Mutex in Shutdown().
Thu, Feb 25, 20:12
majcosta accepted D9278: doc: Add documentation for 'checklevel' argument in 'verifychain' RPC call.
Thu, Feb 25, 19:58
majcosta requested changes to D9277: doc: noban precludes maxuploadtarget disconnects.
Thu, Feb 25, 19:55
majcosta accepted D9276: [test] CScriptNum Decode Check as Unit Tests.
Thu, Feb 25, 19:51
majcosta accepted D9275: validation: delay flushing undo files in syncing node case.
Thu, Feb 25, 13:39

Wed, Feb 24

majcosta accepted D9274: [website] Add Kucoin back to list of exchanges.
Wed, Feb 24, 23:42
majcosta accepted D9273: test: type hints in Python tests.
Wed, Feb 24, 20:23
majcosta accepted D9269: validation: Make VerifyDB level 4 interruptible.
Wed, Feb 24, 11:54
majcosta accepted D9268: validation: use std::chrono in CChainState::FlushStateToDisk().
Wed, Feb 24, 11:53
majcosta accepted D9267: [WEBSITE] Fix fetching the latest release notes.
Wed, Feb 24, 03:04
majcosta accepted D9266: Bump version to 0.22.15.
Wed, Feb 24, 00:08

Tue, Feb 23

majcosta accepted D9265: test: Add missing sync_blocks to wallet_hd.
Tue, Feb 23, 18:31
majcosta accepted D9264: Limit scope of all global std::once_flag.
Tue, Feb 23, 18:30
majcosta accepted D9260: qt: Fix shutdown when waitfor* cmds are called from RPC console.
Tue, Feb 23, 17:14
majcosta accepted D9261: test: Explain that a bug should be filed when the test fail.
Tue, Feb 23, 17:08
majcosta accepted D9262: tests: implement base58_decode.
Tue, Feb 23, 17:06
majcosta accepted D9263: Update links in CONTRIBUTE.md.
Tue, Feb 23, 17:05
majcosta closed D9259: [backport#18637] coins: allow cache resize after init.
Tue, Feb 23, 15:18
majcosta committed rABC8af6d9df957b: [backport#18637] coins: allow cache resize after init (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#18637] coins: allow cache resize after init
Tue, Feb 23, 15:18
majcosta updated the test plan for D9259: [backport#18637] coins: allow cache resize after init.
Tue, Feb 23, 15:04
majcosta updated the diff for D9259: [backport#18637] coins: allow cache resize after init.

modified comments pertaining to function arguments to not be reliant on a particular formatting (// to /* */)

Tue, Feb 23, 14:58
majcosta updated the summary of D9259: [backport#18637] coins: allow cache resize after init.
Tue, Feb 23, 13:50
majcosta updated the diff for D9259: [backport#18637] coins: allow cache resize after init.

fix -Werror=ignored-qualifiers

Tue, Feb 23, 13:49
majcosta requested review of D9259: [backport#18637] coins: allow cache resize after init.
Tue, Feb 23, 10:46
majcosta closed D9258: [buildbot] make bot link to backports of core-gui repo.
Tue, Feb 23, 10:45
majcosta committed rABC5c69fab896b6: [buildbot] make bot link to backports of core-gui repo (authored by majcosta).
[buildbot] make bot link to backports of core-gui repo
Tue, Feb 23, 10:45
majcosta closed T640: Backport Core PR 9856 as Resolved.
Tue, Feb 23, 09:58 · Bootcamp, Restricted Project
majcosta accepted D9257: qt: Fix regression in TransactionTableModel.
Tue, Feb 23, 09:40
majcosta accepted D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..
Tue, Feb 23, 09:40
majcosta requested changes to D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..

now you reverted PR19132's changes completely

Tue, Feb 23, 08:10
majcosta updated the test plan for D9258: [buildbot] make bot link to backports of core-gui repo.
Tue, Feb 23, 00:45
majcosta updated the diff for D9258: [buildbot] make bot link to backports of core-gui repo.

updated backporting.md

Tue, Feb 23, 00:04

Mon, Feb 22

majcosta planned changes to D9258: [buildbot] make bot link to backports of core-gui repo.

fixing docs

Mon, Feb 22, 23:35
majcosta updated the diff for D9258: [buildbot] make bot link to backports of core-gui repo.

added test cases and removed test cases that no longer apply (the number of digits in PRs are no longer in the code)

Mon, Feb 22, 23:34
majcosta planned changes to D9258: [buildbot] make bot link to backports of core-gui repo.

making the tests happy

Mon, Feb 22, 22:42
majcosta updated the summary of D9258: [buildbot] make bot link to backports of core-gui repo.
Mon, Feb 22, 22:41
majcosta requested review of D9258: [buildbot] make bot link to backports of core-gui repo.
Mon, Feb 22, 22:39
majcosta added a comment to D9257: qt: Fix regression in TransactionTableModel.
In D9257#210616, @PiRK wrote:

Ok wigh core-gui. But something need to be done about the automatic " PRxxxx to URL" conversion.

Mon, Feb 22, 20:59
majcosta accepted D9250: [Cashtab] Enable special features if wallet has specific eToken.
Mon, Feb 22, 20:22
majcosta abandoned D8633: [refactor] use compile time string_view for DBKeys.

yea this ain't worth it

Mon, Feb 22, 20:02
majcosta requested changes to D9250: [Cashtab] Enable special features if wallet has specific eToken.
Mon, Feb 22, 19:50
majcosta requested changes to D9257: qt: Fix regression in TransactionTableModel.

we need to come up with a standard notation to ease automation of tagging the done backports in the bitcoin-core/gui repo, what about using Backport of core-gui PRxxxxxx?

Mon, Feb 22, 18:53
majcosta accepted D9255: qt: Use parent-child relation to manage lifetime of OptionsModel object.
Mon, Feb 22, 18:49
majcosta accepted D9254: BlockTip struct created and connected to notifyHeaderTip and notifyBlockTip signals..
Mon, Feb 22, 18:41
majcosta closed D9251: [refactor] add alias for Schnorr signatures and remove size magic number.
Mon, Feb 22, 18:38
majcosta committed rABCdf89383bb6ed: [refactor] add alias for Schnorr signatures and remove size magic number (authored by majcosta).
[refactor] add alias for Schnorr signatures and remove size magic number
Mon, Feb 22, 18:38
majcosta accepted D9236: wallet: descriptor wallet cleanups.
Mon, Feb 22, 18:36
majcosta requested changes to D9253: Added best block hash to the NotifyHeaderTip and NotifyBlockTip signals..
Mon, Feb 22, 18:33

Sun, Feb 21

majcosta updated the diff for D9251: [refactor] add alias for Schnorr signatures and remove size magic number.

couldn't reproduce with for i in {1..100}; do ninja check-bitcoin-coinselector_tests; done, rebasing

Sun, Feb 21, 11:05
majcosta planned changes to D9251: [refactor] add alias for Schnorr signatures and remove size magic number.
Sun, Feb 21, 10:49
majcosta requested review of D9251: [refactor] add alias for Schnorr signatures and remove size magic number.
Sun, Feb 21, 10:13

Fri, Feb 19

majcosta requested changes to D9236: wallet: descriptor wallet cleanups.
Fri, Feb 19, 17:30
majcosta accepted D9249: Update version to 0.22.14.
Fri, Feb 19, 16:36

Thu, Feb 18

majcosta accepted D9239: cli: create GetWalletBalances() to fetch multiwallet balances.
Thu, Feb 18, 11:48

Wed, Feb 17

majcosta accepted D9242: test: add -getinfo multiwallet functional tests.
Wed, Feb 17, 19:21
majcosta accepted D9241: rpc: drop unused JSONRPCProcessBatchReply size arg, refactor.
Wed, Feb 17, 19:18
majcosta accepted D9240: cli: use GetWalletBalances() functionality for -getinfo.
Wed, Feb 17, 19:14
majcosta requested changes to D9239: cli: create GetWalletBalances() to fetch multiwallet balances.
Wed, Feb 17, 19:13
majcosta accepted D9238: cli: lift -rpcwallet logic up to CommandLineRPC().
Wed, Feb 17, 18:32
majcosta accepted D9237: cli: extract connection exception handler, -rpcwait logic to ConnectAndCallRPC().
Wed, Feb 17, 18:09

Mon, Feb 15

majcosta accepted D9225: Move replay protection activation to Nov. 15, 2021.
Mon, Feb 15, 15:44

Fri, Feb 12

majcosta accepted D9221: [Cashtab] Update cashtab docs links to point to web wallet docs.
Fri, Feb 12, 23:22

Thu, Feb 11

majcosta accepted D9213: [Cashtab] Clean up onboarding page + docs link.
Thu, Feb 11, 15:56
majcosta accepted D9212: Faster sigcache nonce.
Thu, Feb 11, 15:00

Wed, Feb 10

majcosta accepted D9209: [cashtab-docs] remove BCH logo from twitter card.
Wed, Feb 10, 23:03
majcosta accepted D9200: net: advertise support for ADDRv2 via new message.
Wed, Feb 10, 21:36
majcosta planned changes to D8693: [CashTab] Expo - Initial setup with loading and webview. Working only on Android.

this should probably be the last step once all of cashtab is proper React'd

Wed, Feb 10, 21:02
majcosta commandeered D8693: [CashTab] Expo - Initial setup with loading and webview. Working only on Android.
Wed, Feb 10, 21:01
majcosta accepted D9208: [cashtab-docs] Add google analytics.
Wed, Feb 10, 20:28
majcosta accepted D9207: [Cashtab] Add missing meta field per errors reported by Twitter card validator.
Wed, Feb 10, 20:16
majcosta closed D9196: [backport#17681] wallet: Keep inactive seeds after sethdseed and derive keys from them as needed.
Wed, Feb 10, 19:26
majcosta committed rABC3e3efbd77fa7: [backport#17681] wallet: Keep inactive seeds after sethdseed and derive keys… (authored by Samuel Dobson <dobsonsa68@gmail.com>).
[backport#17681] wallet: Keep inactive seeds after sethdseed and derive keys…
Wed, Feb 10, 19:26
majcosta requested changes to D9207: [Cashtab] Add missing meta field per errors reported by Twitter card validator.
Wed, Feb 10, 19:25
majcosta accepted D9202: addrman: ensure old versions don't parse peers.dat.
Wed, Feb 10, 18:43
majcosta accepted D9201: tor: make a TORv3 hidden service instead of TORv2.
Wed, Feb 10, 18:34
majcosta requested changes to D9200: net: advertise support for ADDRv2 via new message.
Wed, Feb 10, 18:31
majcosta accepted D9199: net: CAddress & CAddrMan: (un)serialize as ADDRv2.
Wed, Feb 10, 17:48
majcosta updated the diff for D9196: [backport#17681] wallet: Keep inactive seeds after sethdseed and derive keys from them as needed.

addressed comments

Wed, Feb 10, 17:29

Tue, Feb 9

majcosta requested review of D9196: [backport#17681] wallet: Keep inactive seeds after sethdseed and derive keys from them as needed.
Tue, Feb 9, 19:35
majcosta accepted D9195: p2p: Unify Send and Receive protocol versions.
Tue, Feb 9, 17:20
majcosta closed D9066: [backport#18727] test: Add CreateWalletFromFile test.
Tue, Feb 9, 16:42
majcosta committed rABCa8ce4f8ed85e: [backport#18727] test: Add CreateWalletFromFile test (authored by MarcoFalke <falke.marco@gmail.com>).
[backport#18727] test: Add CreateWalletFromFile test
Tue, Feb 9, 16:42
majcosta accepted D9193: tests: Add fuzzing harness for CNode.
Tue, Feb 9, 16:40
majcosta accepted D9192: [net] split PushInventory().
Tue, Feb 9, 16:29
majcosta accepted D9190: net: Use C++11 member initialization in protocol.
Tue, Feb 9, 16:24
majcosta accepted D9189: net: recognize TORv3/I2P/CJDNS networks.
Tue, Feb 9, 16:17
majcosta closed D9191: [backport#19164] ci: tsan with wallet.
Tue, Feb 9, 16:00
majcosta committed rABCde9e50126c34: [backport#19164] ci: tsan with wallet (authored by fanquake <fanquake@gmail.com>).
[backport#19164] ci: tsan with wallet
Tue, Feb 9, 16:00
majcosta accepted D9188: net: CNetAddr: add support to (un)serialize as ADDRv2.
Tue, Feb 9, 15:39
majcosta accepted D9187: test: move HasReason so it can be reused.
Tue, Feb 9, 15:33
majcosta updated the summary of D9187: test: move HasReason so it can be reused.
Tue, Feb 9, 15:32
teamcity awarded D9066: [backport#18727] test: Add CreateWalletFromFile test a Haypence token.
Tue, Feb 9, 15:31
majcosta accepted D9186: util: move HasPrefix() so it can be reused.
Tue, Feb 9, 15:30
majcosta added a comment to D9066: [backport#18727] test: Add CreateWalletFromFile test.

@bot build-tsan

Tue, Feb 9, 15:29
teamcity awarded D9191: [backport#19164] ci: tsan with wallet a Haypence token.
Tue, Feb 9, 15:27
majcosta updated the diff for D9066: [backport#18727] test: Add CreateWalletFromFile test.

rebase on top of D9191

Tue, Feb 9, 15:25
majcosta requested review of D9191: [backport#19164] ci: tsan with wallet.
Tue, Feb 9, 15:24
majcosta accepted D9185: Implement Keccak and SHA3_256.
Tue, Feb 9, 15:19

Mon, Feb 8

majcosta accepted D9182: Bump version to 0.23.0.
Mon, Feb 8, 15:52

Sat, Feb 6

majcosta updated the summary of D8692: [CashAddr] replace bitcoincash: prefix with ecash: in the node.
Sat, Feb 6, 01:31