Page MenuHomePhabricator

remove argName nBlocks from estimatefee RPC command registration
ClosedPublic

Authored by PiRK on Wed, Sep 8, 14:19.

Details

Summary

Our version of estimatefee does not take a number of blocks as an
argument. It just returns a constant value, and the transaction is
always expected to be in the next block.

Test Plan

ninja all check-all

$ ./src/bitcoin-cli estimatefee 6
error code: -1
error message:
estimatefee

Estimates the approximate fee per kilobyte needed for a transaction

Result:
n    (numeric) estimated fee-per-kilobyte

Examples:
> bitcoin-cli estimatefee

../test/lint/check-rpc-mappings.py ..

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Wed, Sep 8, 14:19
majcosta requested changes to this revision.Wed, Sep 8, 15:41
majcosta added a subscriber: majcosta.

linter be mad

This revision now requires changes to proceed.Wed, Sep 8, 15:41

remove the arg also from vRPCConvertParams

This revision is now accepted and ready to land.Fri, Sep 10, 15:38