Page MenuHomePhabricator
Differential D10458

test: Add tests for CNode::ConnectedThroughNetwork
ClosedPublic
Actions

Authored by PiRK on Nov 10 2021, 16:57.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC84b18a9f09ec: test: Add tests for CNode::ConnectedThroughNetwork
Summary

Note: I didn't backport the inline comments for argument names, because I don't think it is an improvement (my IDE already show the parameter names for literal parameters) and it will not help avoiding future merge conflicts (coding style incompatible with our linter and different signature for the CNode constructor)

This is a backport of core#19998 [3/3]
https://github.com/bitcoin/bitcoin/pull/19998/commits/3984b78cd7f49e409377f2175a56e8e4bd71d1d8

Depends on D10457

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 10 2021, 16:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 10 2021, 16:57
PiRK requested review of this revision.Nov 10 2021, 16:57
teamcity edited the summary of this revision. (Show Details)Nov 10 2021, 16:58
PiRK edited the summary of this revision. (Show Details)Nov 10 2021, 16:59
Harbormaster completed remote builds in B17224: Diff 30829.Nov 10 2021, 17:20
majcosta accepted this revision.Nov 11 2021, 19:20
majcosta added a subscriber: majcosta.
majcosta added inline comments.
src/test/net_tests.cpp
230 ↗(On Diff #30829)

well, if you're gonna deduce pnode3's type, might as well do it for pnode4 too

This revision is now accepted and ready to land.Nov 11 2021, 19:20
PiRK updated this revision to Diff 30848.Nov 12 2021, 06:59

use auto for pnode4 too

Harbormaster completed remote builds in B17242: Diff 30848.Nov 12 2021, 07:15
Closed by commit rABC84b18a9f09ec: test: Add tests for CNode::ConnectedThroughNetwork (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyNov 12 2021, 07:53
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC84b18a9f09ec: test: Add tests for CNode::ConnectedThroughNetwork.

Revision Contents
Changeset List

PathSize
src/
test/
fuzz/
4 lines
26 lines

Diff 30854

View Options

src/test/fuzz/net.cpp

Loading...
View Options

src/test/net_tests.cpp

Loading...