HomePhabricator

refactor: remove c-string interfaces for DecodeBase58{Check}

Description

refactor: remove c-string interfaces for DecodeBase58{Check}

Summary:
This micro-PR gets rid of base58 function interfaces that are redundant in terms of c-string / std::string variants; the c-string interface for DecodeBase58Check is completely unused outside the base58 module, while the c-string interface for DecodeBase58 is only used in unit tests, where an implicit conversion to std::string is not problematic.

This is a backport of core#19739

Test Plan:

ninja check-all

Reviewers: #bitcoin_abc, Fabien, PiRK

Reviewed By: #bitcoin_abc, Fabien, PiRK

Differential Revision: https://reviews.bitcoinabc.org/D14404

Details

Provenance
Wladimir J. van der Laan <laanwj@protonmail.com>Authored on Aug 28 2020, 14:44
majcostaCommitted on Aug 24 2023, 12:11
majcostaPushed on Aug 24 2023, 12:11
Reviewer
Restricted Project
Differential Revision
D14404: refactor: remove c-string interfaces for DecodeBase58{Check}
Parents
rABCcce7c4ac48bf: Bump version to 0.27.13
Branches
Unknown
Tags
Unknown