Page MenuHomePhabricator
Differential D6526

Merge #14719: qa: Check specific reject reasons in feature_block
ClosedPublic
Actions

Authored by nakihito on Jun 11 2020, 02:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCbbe97bafe5d5: Merge #14719: qa: Check specific reject reasons in feature_block
Summary

fa7da0617c814aeb06d5c70c4bb8e18c79fb8725 qa: Check specific reject reasons in feature_block (MarcoFalke)

Pull request description:

There are some consensus checks that are essentially turned off because we never send the block, but only the header. It happens that the header was sufficient to determine the invalidity of the block according to our consensus rules in those cases. Fix that by forcing the full block on the node unsolicited.

Tree-SHA512: a5534318370367ea8de07d853de7e845c8f5637cd6d5457e932a9555af26cc212625e443c00c93586d556cc770f301248e7cabd68131a37791ae91706e7e40b2

Backport of Core PR14719

Test Plan
ninja check-extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jun 11 2020, 02:20
Owners added a reviewer: Restricted Owners Package.Jun 11 2020, 02:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 11 2020, 02:20
nakihito requested review of this revision.Jun 11 2020, 02:20
teamcity edited the summary of this revision. (Show Details)Jun 11 2020, 02:20

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11415: Diff 21270.Jun 11 2020, 02:34
Fabien requested changes to this revision.Jun 11 2020, 07:28
Fabien added a subscriber: Fabien.

This is broken. You didn't notice it because the test plan is inadequate.

This revision now requires changes to proceed.Jun 11 2020, 07:28
nakihito updated this revision to Diff 21299.EditedJun 11 2020, 17:23

Fixed test and text plan.

nakihito edited the test plan for this revision. (Show Details)Jun 11 2020, 17:24
Harbormaster completed remote builds in B11431: Diff 21299.Jun 11 2020, 17:36
Fabien requested changes to this revision.Jun 12 2020, 06:37

The test plan is still wrong

This revision now requires changes to proceed.Jun 12 2020, 06:37
nakihito edited the test plan for this revision. (Show Details)Jun 12 2020, 17:38
nakihito requested review of this revision.Jun 12 2020, 20:47

Actually fixed test plan.

Fabien accepted this revision.Jun 15 2020, 09:09
This revision is now accepted and ready to land.Jun 15 2020, 09:09
Closed by commit rABCbbe97bafe5d5: Merge #14719: qa: Check specific reject reasons in feature_block (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyJun 15 2020, 18:02
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCbbe97bafe5d5: Merge #14719: qa: Check specific reject reasons in feature_block.

Revision Contents
Changeset List

PathSize
test/
functional/
8 lines
33 lines
test_framework/
14 lines

Diff 21408

View Options

test/functional/abc-invalid-chains.py

Loading...
View Options

test/functional/feature_block.py

Loading...
View Options

test/functional/test_framework/mininode.py

Loading...