HomePhabricator

Merge #14719: qa: Check specific reject reasons in feature_block

Description

Merge #14719: qa: Check specific reject reasons in feature_block

Summary:
fa7da0617c814aeb06d5c70c4bb8e18c79fb8725 qa: Check specific reject reasons in feature_block (MarcoFalke)

Pull request description:

There are some consensus checks that are essentially turned off because we never send the block, but only the header. It happens that the header was sufficient to determine the invalidity of the block according to our consensus rules in those cases. Fix that by forcing the full block on the node unsolicited.

Tree-SHA512: a5534318370367ea8de07d853de7e845c8f5637cd6d5457e932a9555af26cc212625e443c00c93586d556cc770f301248e7cabd68131a37791ae91706e7e40b2

Backport of Core PR14719

Test Plan:

ninja check-extended

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Subscribers: Fabien

Differential Revision: https://reviews.bitcoinabc.org/D6526

Details

Provenance
Wladimir J. van der Laan <laanwj@gmail.com>Authored on Nov 21 2018, 13:29
nakihitoCommitted on Jun 15 2020, 18:02
nakihitoPushed on Jun 15 2020, 18:02
Reviewer
Restricted Owners Package
Differential Revision
D6526: Merge #14719: qa: Check specific reject reasons in feature_block
Parents
rABC269eeb6c89b4: Use Check facility is ZeroMQ RPC
Branches
Unknown
Tags
Unknown