Page MenuHomePhabricator
Differential D6583

Use the new Check facility in rpc/misc.cpp
ClosedPublic
Actions

Authored by deadalnix on Jun 15 2020, 17:23.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Commits
rABCc981efd379e4: Use the new Check facility in rpc/misc.cpp
Summary

As per title.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jun 15 2020, 17:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 15 2020, 17:23
deadalnix requested review of this revision.Jun 15 2020, 17:23
teamcity added a comment.Jun 15 2020, 17:27
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Snippet of first build failure:

[17:26:54] :	 [Step 1/2]  [0m [1;30mp2p_leak_tx.py                                | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mrpc_createmultisig.py                         | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mrpc_deprecated.py                             | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mrpc_estimatefee.py                            | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mrpc_psbt.py                                   | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mrpc_scantxoutset.py                           | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mrpc_signmessage.py                            | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mrpc_signrawtransaction.py                     | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mrpc_txoutproof.py                             | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mtool_wallet.py                                | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_abandonconflict.py                     | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_address_types.py                       | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_avoidreuse.py                          | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_balance.py                             | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_basic.py                               | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_create_tx.py                           | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_createwallet.py                        | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_createwallet.py --usecli               | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_dump.py                                | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_encryption.py                          | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_groups.py                              | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_hd.py                                  | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_import_rescan.py                       | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_import_with_label.py                   | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_importmulti.py                         | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_importprunedfunds.py                   | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_keypool.py                             | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_keypool_topup.py                       | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_labels.py                              | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_listreceivedby.py                      | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_listsinceblock.py                      | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_listtransactions.py                    | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_multiwallet.py                         | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_multiwallet.py --usecli                | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_resendwallettransactions.py            | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_txn_clone.py                           | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_txn_clone.py --mineblock               | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_txn_doublespend.py                     | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_txn_doublespend.py --mineblock         | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [1;30mwallet_zapwallettxes.py                       | ○ Skipped | 0 s
[17:26:54] :	 [Step 1/2]  [0m [0;31minterface_bitcoin_cli.py                      | ✖ Failed  | 0 s
[17:26:54] :	 [Step 1/2]  [0m [0;31mrpc_misc.py                                   | ✖ Failed  | 0 s
[17:26:54] :	 [Step 1/2]  [0m [0;31mrpc_named_arguments.py                        | ✖ Failed  | 0 s
[17:26:54] :	 [Step 1/2]  [0m [0;31m [1m
[17:26:54] :	 [Step 1/2] ALL                                           | ✖ Failed  | 206 s (accumulated) 
[17:26:54] :	 [Step 1/2]  [0m [0mRuntime: 51 s
[17:26:54] :	 [Step 1/2] 
[17:26:54] :	 [Step 1/2] FAILED: test/CMakeFiles/check-functional 
[17:26:54] :	 [Step 1/2] cd /work/build-without-wallet/test && /usr/bin/cmake -E env /usr/bin/python3.7 ./functional/test_runner.py
[17:26:54] :	 [Step 1/2] ninja: build stopped: subcommand failed.
[17:26:54]W:	 [Step 1/2] ++ print_sanitizers_log
[17:26:54]W:	 [Step 1/2] ++ for log in "${SAN_LOG_DIR}"/*.log.*
[17:26:54]W:	 [Step 1/2] ++ echo '*** Output of /tmp/sanitizer_logs/*.log.* ***'
[17:26:54]W:	 [Step 1/2] ++ cat '/tmp/sanitizer_logs/*.log.*'
[17:26:54] :	 [Step 1/2] *** Output of /tmp/sanitizer_logs/*.log.* ***
[17:26:54]W:	 [Step 1/2] cat: '/tmp/sanitizer_logs/*.log.*': No such file or directory
[17:26:54]W:	 [Step 1/2] cp: cannot stat '/work/build': No such file or directory
[17:26:54]W:	 [Step 1/2] cp: cannot stat '/work/ibd/debug.log': No such file or directory
[17:26:58]W:	 [Step 1/2] Process exited with code 1
[17:26:58]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)
Harbormaster completed remote builds in B11493: Diff 21403.Jun 15 2020, 17:27
deadalnix planned changes to this revision.Jun 15 2020, 17:29

This needs more work.

deadalnix updated this revision to Diff 21404.Jun 15 2020, 17:35

Fix the echo RPC

teamcity added a comment.Jun 15 2020, 17:35
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Snippet of first build failure:

[17:34:56] :	 [Step 1/2]  [0m [0;32mrpc_scantxoutset.py                           | ✓ Passed  | 4 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mrpc_setban.py                                 | ✓ Passed  | 2 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mrpc_signmessage.py                            | ✓ Passed  | 0 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mrpc_signrawtransaction.py                     | ✓ Passed  | 1 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mrpc_txoutproof.py                             | ✓ Passed  | 2 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mrpc_uptime.py                                 | ✓ Passed  | 0 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mrpc_users.py                                  | ✓ Passed  | 2 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mrpc_whitelist.py                              | ✓ Passed  | 0 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mtool_wallet.py                                | ✓ Passed  | 3 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_abandonconflict.py                     | ✓ Passed  | 14 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_address_types.py                       | ✓ Passed  | 13 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_avoidreuse.py                          | ✓ Passed  | 12 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_balance.py                             | ✓ Passed  | 11 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_basic.py                               | ✓ Passed  | 28 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_create_tx.py                           | ✓ Passed  | 0 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_createwallet.py                        | ✓ Passed  | 2 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_createwallet.py --usecli               | ✓ Passed  | 2 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_disable.py                             | ✓ Passed  | 0 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_dump.py                                | ✓ Passed  | 2 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_encryption.py                          | ✓ Passed  | 5 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_groups.py                              | ✓ Passed  | 13 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_hd.py                                  | ✓ Passed  | 4 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_import_rescan.py                       | ✓ Passed  | 6 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_import_with_label.py                   | ✓ Passed  | 0 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_importmulti.py                         | ✓ Passed  | 2 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_importprunedfunds.py                   | ✓ Passed  | 1 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_keypool.py                             | ✓ Passed  | 2 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_keypool_topup.py                       | ✓ Passed  | 2 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_labels.py                              | ✓ Passed  | 1 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_listreceivedby.py                      | ✓ Passed  | 32 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_listsinceblock.py                      | ✓ Passed  | 4 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_listtransactions.py                    | ✓ Passed  | 16 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_multiwallet.py                         | ✓ Passed  | 13 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_multiwallet.py --usecli                | ✓ Passed  | 15 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_resendwallettransactions.py            | ✓ Passed  | 4 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_txn_clone.py                           | ✓ Passed  | 2 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_txn_clone.py --mineblock               | ✓ Passed  | 3 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_txn_doublespend.py                     | ✓ Passed  | 1 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_txn_doublespend.py --mineblock         | ✓ Passed  | 3 s
[17:34:56] :	 [Step 1/2]  [0m [0;32mwallet_zapwallettxes.py                       | ✓ Passed  | 4 s
[17:34:56] :	 [Step 1/2]  [0m [0;31minterface_bitcoin_cli.py                      | ✖ Failed  | 0 s
[17:34:56] :	 [Step 1/2]  [0m [0;31mrpc_misc.py                                   | ✖ Failed  | 0 s
[17:34:56] :	 [Step 1/2]  [0m [0;31mrpc_named_arguments.py                        | ✖ Failed  | 0 s
[17:34:56] :	 [Step 1/2]  [0m [0;31m [1m
[17:34:56] :	 [Step 1/2] ALL                                           | ✖ Failed  | 621 s (accumulated) 
[17:34:56] :	 [Step 1/2]  [0m [0mRuntime: 137 s
[17:34:56] :	 [Step 1/2] 
[17:34:56] :	 [Step 1/2] FAILED: test/CMakeFiles/check-functional 
[17:34:56] :	 [Step 1/2] cd /work/build-diff/test && /usr/bin/cmake -E env /usr/bin/python3.7 ./functional/test_runner.py
[17:34:56] :	 [Step 1/2] ninja: build stopped: subcommand failed.
[17:34:56]W:	 [Step 1/2] ++ print_sanitizers_log
[17:34:56]W:	 [Step 1/2] ++ for log in "${SAN_LOG_DIR}"/*.log.*
[17:34:56]W:	 [Step 1/2] ++ echo '*** Output of /tmp/sanitizer_logs/*.log.* ***'
[17:34:56]W:	 [Step 1/2] ++ cat '/tmp/sanitizer_logs/*.log.*'
[17:34:56] :	 [Step 1/2] *** Output of /tmp/sanitizer_logs/*.log.* ***
[17:34:56]W:	 [Step 1/2] cat: '/tmp/sanitizer_logs/*.log.*': No such file or directory
[17:34:56]W:	 [Step 1/2] cp: cannot stat '/work/build': No such file or directory
[17:34:56]W:	 [Step 1/2] cp: cannot stat '/work/ibd/debug.log': No such file or directory
[17:35:00]W:	 [Step 1/2] Process exited with code 1
[17:35:00]E:	 [Step 1/2] Process exited with code 1 (Step: Command Line)
Harbormaster completed remote builds in B11494: Diff 21404.Jun 15 2020, 17:45
nakihito accepted this revision.Jun 15 2020, 18:27
This revision is now accepted and ready to land.Jun 15 2020, 18:27
Closed by commit rABCc981efd379e4: Use the new Check facility in rpc/misc.cpp (authored by deadalnix). · Explain WhyJun 15 2020, 20:17
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCc981efd379e4: Use the new Check facility in rpc/misc.cpp.

Revision Contents
Changeset List

PathSize
src/
rpc/
521 lines

Diff 21425

View Options

src/rpc/misc.cpp

Loading...