Page MenuHomePhabricator
Differential D6625

Merge #16188: net: Document what happens to getdata of unknown type
ClosedPublic
Actions

Authored by nakihito on Jun 17 2020, 18:02.

Details

Reviewers
majcosta
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCd022eaaeacfd: Merge #16188: net: Document what happens to getdata of unknown type
Summary

dddd9270f85bd2e71fd281a0c6b4053e02fce93c net: Document what happens to getdata of unknonw type (MarcoFalke)

Pull request description:

Any getdata of unknown type will never be processed and blocks all future messages from a peer. This isn't obviously clear from reading the code, so document it.

Top commit has no ACKs.

Tree-SHA512: 4f8e43bbe6534242facfcfffae28b7a6aa2d228841fa2146a87d494e69f614b0da23cf7a5f3d4367358a7c1981fe2ec196a21c437ae1653f1c7e0351be22598a

Backport of Core PR16188

Adjusted the second comment to actually make sense.

Test Plan
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jun 17 2020, 18:02
Owners added a reviewer: Restricted Owners Package.Jun 17 2020, 18:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 17 2020, 18:02
nakihito requested review of this revision.Jun 17 2020, 18:02
teamcity edited the summary of this revision. (Show Details)Jun 17 2020, 18:03

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Harbormaster completed remote builds in B11547: Diff 21500.Jun 17 2020, 18:16
majcosta accepted this revision.Jun 17 2020, 18:21
This revision is now accepted and ready to land.Jun 17 2020, 18:21
Closed by commit rABCd022eaaeacfd: Merge #16188: net: Document what happens to getdata of unknown type (authored by fanquake <fanquake@gmail.com>, committed by nakihito). · Explain WhyJun 17 2020, 23:12
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCd022eaaeacfd: Merge #16188: net: Document what happens to getdata of unknown type.

Revision Contents
Changeset List

PathSize
src/
8 lines

Diff 21508

View Options

src/net_processing.cpp

Loading...