net_processing: drop MaybePunishNodeForTx
DraftPublic
Actions

Authored by PiRK on Fri, Nov 14, 12:18.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

Do not discourage nodes even when they send us consensus invalid
transactions.

Because we do not discourage nodes for transactions we consider
non-standard, we don't get any DoS protection from this check in
adversarial scenarios, so remove the check entirely both to simplify the
code and reduce the risk of splitting the network due to changes in tx
relay policy.

This is a partial backport of core#33050
https://github.com/bitcoin/bitcoin/pull/33050/commits/266dd0e10d08c0bfde63205db15d6c210a021b90
https://github.com/bitcoin/bitcoin/pull/33050/commits/876dbdfb4702410dfd4037614dc9298a0c09c63e

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35066
Build 69592: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 69591: arc lint + arc unit

Event Timeline

PiRK created this revision.Fri, Nov 14, 12:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 14, 12:18

teamcity edited the summary of this revision. (Show Details)Fri, Nov 14, 12:18

PiRK added a child revision: D18934: validation: only check input scripts once.Fri, Nov 14, 12:22

fix a few nits

rebase

Harbormaster completed remote builds in B35061: Diff 56597.Fri, Nov 14, 12:44

Harbormaster completed remote builds in B35063: Diff 56600.Fri, Nov 14, 13:07

revert accidental squash

@bot build-chronik chronik-client-integration-tests

teamcity awarded a token.Fri, Nov 14, 13:18

Harbormaster completed remote builds in B35064: Diff 56601.Fri, Nov 14, 13:33

Build Bitcoin ABC Diffs / Diff Testing (ecash-agora-integration-tests) failed.

Failed tests logs:

====== AgoraPartial enforcedLockTime: AgoraPartial enforcedLockTime AgoraPartial enforcedLockTime ======
AssertionError: expected promise to be rejected with an error including 'Failed getting /broadcast-tx: 400: Br…' but got 'Failed getting /broadcast-tx: 400: Br…'

      + expected - actual

      -Failed getting /broadcast-tx: 400: Broadcast failed: Transaction rejected by mempool: mempool-script-verify-flag-failed (Script failed an OP_EQUALVERIFY operation), input 2 of f9844a277cfe190f3bc9abe30921d6b1e80f6748249e4c3cc342902f0280df23, spending f7a455f0d2cc521ce071223e7f219155f5c4029ef8a11d1c93128ac6a82bff72:1
      +Failed getting /broadcast-tx: 400: Broadcast failed: Transaction rejected by mempool: mandatory-script-verify-flag-failed (Script failed an OP_EQUALVERIFY operation)

Each failure log is accessible here:
AgoraPartial enforcedLockTime: AgoraPartial enforcedLockTime AgoraPartial enforcedLockTime

Harbormaster completed remote builds in B35066: Diff 56603.Fri, Nov 14, 13:46

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.