Page MenuHomePhabricator

[backport#16227 6/8] Move various SigningProviders to signingprovider.{cpp,h}
ClosedPublic

Authored by majcosta on Jun 12 2020, 19:07.

Details

Summary

Moves all of the various SigningProviders out of sign.{cpp,h} and
keystore.{cpp,h}. As such, keystore.{cpp,h} is also removed.

Includes and the Makefile are updated to reflect this. Includes were largely
changed using:
git grep -l "keystore.h" | xargs sed -i -e 's;keystore.h;script/signingprovider.h;g'

https://github.com/bitcoin/bitcoin/pull/16227/commits/37a79a4fccbf6cd65a933594e24e59d36e674653


Depends on D6557

Partial backport of Core PR16227

Test Plan

In CMake build dir:

ninja check-all

In autotools build dir:

make check-recursive
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito requested changes to this revision.Jun 12 2020, 20:29
nakihito added a subscriber: nakihito.

Test plan doesn't cover autotools and some small nits.

src/script/signingprovider.h
17 ↗(On Diff #21338)

Relayout comment.

71 ↗(On Diff #21338)

Ditto.

111–112 ↗(On Diff #21338)

Ditto.

This revision now requires changes to proceed.Jun 12 2020, 20:29
majcosta edited the test plan for this revision. (Show Details)
majcosta edited the test plan for this revision. (Show Details)

updated test plan and addressed comments

This revision is now accepted and ready to land.Jun 12 2020, 21:51