HomePhabricator

[backport#16227 6/8] Move various SigningProviders to signingprovider.{cpp,h}

Description

[backport#16227 6/8] Move various SigningProviders to signingprovider.{cpp,h}

Summary:
Moves all of the various SigningProviders out of sign.{cpp,h} and
keystore.{cpp,h}. As such, keystore.{cpp,h} is also removed.

Includes and the Makefile are updated to reflect this. Includes were largely
changed using:
git grep -l "keystore.h" | xargs sed -i -e 's;keystore.h;script/signingprovider.h;g'

https://github.com/bitcoin/bitcoin/pull/16227/commits/37a79a4fccbf6cd65a933594e24e59d36e674653


Depends on D6557

Partial backport of Core PR16227

Test Plan:
In CMake build dir:

ninja check-all

In autotools build dir:

make check-recursive
./test/functional/test_runner.py

Reviewers: #bitcoin_abc, nakihito

Reviewed By: nakihito

Subscribers: nakihito

Differential Revision: https://reviews.bitcoinabc.org/D6558

Details

Provenance
Andrew Chow <achow101-github@achow101.com>Authored on Jun 6 2019, 20:52
majcostaCommitted on Jun 13 2020, 20:15
majcostaPushed on Jun 13 2020, 20:15
Reviewer
nakihito
Differential Revision
D6558: [backport#16227 6/8] Move various SigningProviders to signingprovider.{cpp,h}
Parents
rABC8a6ea7a8fe73: [backport#16227 5/8] Move KeyOriginInfo to its own header file
Branches
Unknown
Tags
Unknown