Add a lock on cs_main while modifying the config in setexcessiveblock
ClosedPublic
Actions

Authored by jasonbcox on Jun 11 2020, 22:10.

Details

Reviewers

nakihito
Fabien

Group Reviewers

Restricted Project

Commits

rABC4ec14900ef1b: Add a lock on cs_main while modifying the config in setexcessiveblock

Summary

Modifying the config in one thread while validation may be occurring
in another can lead to unexpected behavior. Other calls to config.Set*() calls only
exist in init.cpp so no other locks should be necessary.

Revealed by this TSAN failure: https://build.bitcoinabc.org/repository/download/BitcoinABC_ResourceIntensiveBuilds_BitcoinAbcMasterTsan/76935:id/sanitizer_logs.tar.gz%21/ubsan.log.8739

Test Plan

ninja check check-functional
TSAN still fails though. It appears that there is a locking issue in the wallet.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jun 11 2020, 22:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 11 2020, 22:10

jasonbcox requested review of this revision.Jun 11 2020, 22:10

Harbormaster completed remote builds in B11435: Diff 21307.Jun 11 2020, 22:24

This is actually necessary to fix WSL too.

This revision is now accepted and ready to land.Jun 12 2020, 01:27

Fabien accepted this revision.Jun 12 2020, 07:46

Closed by commit rABC4ec14900ef1b: Add a lock on cs_main while modifying the config in setexcessiveblock (authored by jasonbcox). · Explain WhyJun 12 2020, 14:48

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC4ec14900ef1b: Add a lock on cs_main while modifying the config in setexcessiveblock.

Revision Contents
Changeset List

Path

Size

src/

rpc/

abc.cpp

8 lines

Diff 21320

View Options

Add a lock on cs_main while modifying the config in setexcessiveblockClosedPublicActions