Page MenuHomePhabricator
Differential D6603

Use fewer blocks in abc-miner-fund.py
AbandonedPublic
Actions

Authored by nakihito on Jun 16 2020, 01:40.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

This test uses almost 600 blocks at once. This causes problems when
activating BIP34 for regtest according to
https://github.com/bitcoin/bitcoin/pull/15059 without diverging.

Test Plan
test_runner.py abc-miner-fund

Diff Detail

Event Timeline

nakihito created this revision.Jun 16 2020, 01:40
Owners added a reviewer: Restricted Owners Package.Jun 16 2020, 01:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 16 2020, 01:40
nakihito requested review of this revision.Jun 16 2020, 01:40
nakihito mentioned this in D6597: Merge #15059: test: Add basic test for BIP34.Jun 16 2020, 01:45
nakihito added a child revision: D6597: Merge #15059: test: Add basic test for BIP34.Jun 16 2020, 01:46
Harbormaster completed remote builds in B11518: Diff 21451.Jun 16 2020, 01:54
jasonbcox requested changes to this revision.Jun 16 2020, 16:24
jasonbcox added a subscriber: jasonbcox.

This doesn't actually fix the test. From the PR you linked, it's pretty clear that block versioning is the issue, not the number of blocks.

This revision now requires changes to proceed.Jun 16 2020, 16:24
nakihito abandoned this revision.Jun 23 2020, 22:13

Revision Contents
Changeset List

PathSize
test/
functional/
12 lines

Diff 21451

View Options

test/functional/abc-miner-fund.py

Loading...