Page MenuHomePhabricator
Feed Advanced Search

Today

nakihito planned changes to D3882: Merge #12920: test: Fix sign for expected values.

Going to separate the merkleblock_tests.cpp code from the rest since only that part is dependent on another change.

Wed, Sep 18, 15:57

Yesterday

nakihito requested review of D4102: Merge #13431: validation: count blocks correctly for check level < 3.
Tue, Sep 17, 23:32
nakihito requested review of D4103: Merge #13428: validation: check the specified number of blocks (off-by-one).
Tue, Sep 17, 23:32
nakihito updated the summary of D4102: Merge #13431: validation: count blocks correctly for check level < 3.
Tue, Sep 17, 23:07
nakihito planned changes to D4102: Merge #13431: validation: count blocks correctly for check level < 3.
Tue, Sep 17, 23:06
nakihito updated the diff for D4102: Merge #13431: validation: count blocks correctly for check level < 3.

Rebase off D4103 to fix off by one error.

Tue, Sep 17, 23:06
nakihito planned changes to D4103: Merge #13428: validation: check the specified number of blocks (off-by-one).
Tue, Sep 17, 23:05
nakihito created D4103: Merge #13428: validation: check the specified number of blocks (off-by-one).
Tue, Sep 17, 23:05
nakihito planned changes to D4102: Merge #13431: validation: count blocks correctly for check level < 3.
Tue, Sep 17, 23:03
nakihito created D4102: Merge #13431: validation: count blocks correctly for check level < 3.
Tue, Sep 17, 23:03
nakihito requested review of D3464: [rpc] Add logging RPC.
Tue, Sep 17, 18:45
nakihito updated the diff for D3968: Merge #12885: Reduce implementation code inside CScript.

Changed location of FindandDelete() and restored newline.

Tue, Sep 17, 18:40
nakihito planned changes to D3464: [rpc] Add logging RPC.
Tue, Sep 17, 00:40
nakihito updated the diff for D3464: [rpc] Add logging RPC.

Fix comment, removed unnecessary #include, and fixed libevent filter.

Tue, Sep 17, 00:40

Fri, Sep 13

nakihito accepted D4061: [CI] Fix missing parameters transfer from ibd.sh to bitcoind.
Fri, Sep 13, 00:38

Thu, Sep 12

nakihito updated the diff for D3805: Merge #12716: Fix typos and cleanup in various files.

Fixed nit.

Thu, Sep 12, 21:53

Wed, Sep 11

nakihito updated the diff for D4045: Revert change to ActivateBestChain() comments made in D1182.

Removed punctuation at end of comment.

Wed, Sep 11, 23:50
nakihito planned changes to D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Wed, Sep 11, 21:43
nakihito planned changes to D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
Wed, Sep 11, 20:56
nakihito updated the diff for D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.

Rebased off D4045.

Wed, Sep 11, 20:56
nakihito planned changes to D3935: Merge #11411: script: Change SignatureHash input index check to an assert..
Wed, Sep 11, 20:43
nakihito updated the summary of D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
Wed, Sep 11, 20:42
nakihito created D4045: Revert change to ActivateBestChain() comments made in D1182.
Wed, Sep 11, 20:40
nakihito updated the diff for D3750: Merge #12159: Use the character based overload for std::string::find..

Fixed nit.

Wed, Sep 11, 20:40
nakihito planned changes to D3689: Merge #11293: Deduplicate CMerkleBlock construction code, add test coverage.
Wed, Sep 11, 20:12
nakihito updated the diff for D3750: Merge #12159: Use the character based overload for std::string::find..

Fixed remaining instance in wallet.h.

Wed, Sep 11, 18:27
nakihito updated the diff for D4042: Merge #11220: Check specific validation error in miner tests.

Fixed comment.

Wed, Sep 11, 18:10
nakihito requested review of D4042: Merge #11220: Check specific validation error in miner tests.
Wed, Sep 11, 17:50
nakihito updated the summary of D4042: Merge #11220: Check specific validation error in miner tests.
Wed, Sep 11, 17:37
nakihito planned changes to D4042: Merge #11220: Check specific validation error in miner tests.
Wed, Sep 11, 17:36
nakihito created D4042: Merge #11220: Check specific validation error in miner tests.
Wed, Sep 11, 17:36

Tue, Sep 10

nakihito requested review of D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
Tue, Sep 10, 21:26
nakihito accepted D3914: Merge #12853: qa: Match full plain text by default.
Tue, Sep 10, 20:26
nakihito added inline comments to D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
Tue, Sep 10, 20:18
nakihito updated the summary of D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Tue, Sep 10, 19:21
nakihito updated the diff for D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.

Rebased off D4029 and added comment changes.

Tue, Sep 10, 19:20
nakihito created D4029: Merge #13012: [doc] Add comments for chainparams.h, validation.cpp.
Tue, Sep 10, 19:17
nakihito planned changes to D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.
Tue, Sep 10, 01:21
nakihito added a comment to D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.

Will rebase off D4026 soon.

Tue, Sep 10, 01:14
nakihito updated the summary of D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.
Tue, Sep 10, 00:27
nakihito created D4026: Merge #13481: doc: Rewrite some validation docs as lock annotations.
Tue, Sep 10, 00:26

Mon, Sep 9

nakihito requested review of D3750: Merge #12159: Use the character based overload for std::string::find..
Mon, Sep 9, 18:25
nakihito updated the test plan for D3937: Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor.
Mon, Sep 9, 17:28
nakihito requested review of D4021: Merge #13149: Handle unsuccessful fseek(...):s.
Mon, Sep 9, 17:06
nakihito updated the summary of D4021: Merge #13149: Handle unsuccessful fseek(...):s.
Mon, Sep 9, 17:06

Fri, Sep 6

nakihito added a comment to D4022: Merge #12503: [RPC] createmultisig no longer takes addresses.

using addresses in createmultisig was deprecated in D2002 and the deprecated code was removed in D3978.

Fri, Sep 6, 18:35
nakihito created D4022: Merge #12503: [RPC] createmultisig no longer takes addresses.
Fri, Sep 6, 18:33
nakihito created D4021: Merge #13149: Handle unsuccessful fseek(...):s.
Fri, Sep 6, 18:22
nakihito updated the diff for D3934: Merge #11338: qt: Backup former GUI settings on `-resetguisettings`.

Fixed comment formatting and removed extra new line.

Fri, Sep 6, 17:57
nakihito created D4020: Merge #13658: [moveonly] Extract RescanWallet to handle a simple rescan.
Fri, Sep 6, 17:55
nakihito requested review of D3542: Merge #10537: Few Minor per-utxo assert-semantics re-adds and tweak.
Fri, Sep 6, 17:16
nakihito requested review of D3937: Merge #12928: qt: Initialize non-static class members that were previously neither initialized where defined nor in constructor.
Fri, Sep 6, 17:14

Thu, Sep 5

nakihito updated the summary of D3950: Merge #12953: Deprecate accounts.
Thu, Sep 5, 22:48
nakihito added inline comments to D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.
Thu, Sep 5, 19:20
nakihito updated the summary of D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.
Thu, Sep 5, 19:16
nakihito updated the diff for D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.

Corrected nits, rebased off D3464, and added changes to logging().

Thu, Sep 5, 19:15

Wed, Sep 4

nakihito updated the summary of D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.
Wed, Sep 4, 22:09
nakihito updated the diff for D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

Rebased off D3998.

Wed, Sep 4, 22:08
nakihito created D3998: Merge #11044: [wallet] Keypool topup cleanups.
Wed, Sep 4, 21:50
nakihito planned changes to D3950: Merge #12953: Deprecate accounts.

Nits fixed. Will rebase after D3997 is greened.

Wed, Sep 4, 21:44
nakihito added a comment to D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.

rpc/blockchain.cpp changes were made here: D954
rpc/mining.cpp changes were excluded because we did not backport much of Core's fee code.
Changes to rpc/misc.cpp that were excluded were to outdated logging code.
signrawtransaction() was removed after being deprecated: D3978

Wed, Sep 4, 21:36
nakihito created D3997: Merge #11050: Avoid treating null RPC arguments different from missing arguments.
Wed, Sep 4, 21:17

Tue, Sep 3

nakihito updated the diff for D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.

Rebased and added missing EXCLUSIVE_LOCKS_REQUIRED() to validation.cpp

Tue, Sep 3, 19:51
nakihito updated the diff for D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

Added an instance of EXCLUSIVE_LOCKS_REQUIRED() to wallet/wallet.cpp.

Tue, Sep 3, 19:47
nakihito updated the diff for D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.

Rebased.

Tue, Sep 3, 19:16
nakihito updated the test plan for D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.
Tue, Sep 3, 19:10
nakihito updated the test plan for D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.
Tue, Sep 3, 19:06
nakihito requested review of D3980: Merge #13077: Add compile time checking for all cs_KeyStore runtime locking assertions.

Fixed test method.

Tue, Sep 3, 19:06
nakihito updated the test plan for D3980: Merge #13077: Add compile time checking for all cs_KeyStore runtime locking assertions.
Tue, Sep 3, 19:06

Sat, Aug 31

nakihito updated the summary of D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.
Sat, Aug 31, 00:39
nakihito updated the summary of D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.
Sat, Aug 31, 00:38
nakihito created D3982: Merge #13083: Add compile time checking for cs_main runtime locking assertions.
Sat, Aug 31, 00:38
nakihito created D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.
Sat, Aug 31, 00:37
nakihito created D3980: Merge #13077: Add compile time checking for all cs_KeyStore runtime locking assertions.
Sat, Aug 31, 00:34

Fri, Aug 30

nakihito requested review of D3976: Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...).

Fix completed by D3979.

Fri, Aug 30, 20:54
nakihito updated the summary of D3979: Merge #13159: Don't close old debug log file handle prematurely when trying to re-open (on SIGHUP).
Fri, Aug 30, 20:53
nakihito created D3979: Merge #13159: Don't close old debug log file handle prematurely when trying to re-open (on SIGHUP).
Fri, Aug 30, 20:53
nakihito updated the diff for D3968: Merge #12885: Reduce implementation code inside CScript.

Fixed variable type comparison warning.

Fri, Aug 30, 18:47
nakihito updated the diff for D3950: Merge #12953: Deprecate accounts.

Rebased.

Fri, Aug 30, 18:10
nakihito updated the diff for D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Rebased and moved label and account function blocks inline with Core's placement.

Fri, Aug 30, 17:51
nakihito planned changes to D3976: Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...).

Not a complete fix. https://github.com/bitcoin/bitcoin/pull/13159 fixes remaining issues.

Fri, Aug 30, 01:44
nakihito created D3976: Merge #13148: logging: Fix potential use-after-free in LogPrintStr(...).
Fri, Aug 30, 01:32

Thu, Aug 29

nakihito created D3975: Merge #12507: Interrupt rescan on shutdown request.
Thu, Aug 29, 23:04
nakihito updated the diff for D3949: Merge #12892: [wallet] [rpc] introduce 'label' API for wallet.

Addressed nits and reverted timing.json change.

Thu, Aug 29, 20:52
nakihito updated the diff for D3968: Merge #12885: Reduce implementation code inside CScript.

Fixed variable typing and added braces.

Thu, Aug 29, 20:40

Wed, Aug 28

nakihito added inline comments to D3968: Merge #12885: Reduce implementation code inside CScript.
Wed, Aug 28, 23:19
nakihito updated the diff for D3968: Merge #12885: Reduce implementation code inside CScript.

Removed typo.

Wed, Aug 28, 23:19
nakihito created D3968: Merge #12885: Reduce implementation code inside CScript.
Wed, Aug 28, 23:16
nakihito updated the diff for D3954: Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0.

Rebase.

Wed, Aug 28, 19:16
nakihito updated the diff for D3953: Merge #12618: Set SCHED_BATCH priority on the loadblk thread..

Rebase.

Wed, Aug 28, 19:13
nakihito updated the diff for D3953: Merge #12618: Set SCHED_BATCH priority on the loadblk thread..

function(void) -> function().

Wed, Aug 28, 19:12
nakihito updated the diff for D3954: Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0.

Rebased.

Wed, Aug 28, 19:10
nakihito updated the diff for D3953: Merge #12618: Set SCHED_BATCH priority on the loadblk thread..

Fixed function(void) -> function().

Wed, Aug 28, 18:35
nakihito abandoned D3696: Merge #10036: Fix init README format to render correctly on github.

I guess this was landed as D3843 while this was waiting for review.

Wed, Aug 28, 18:02
nakihito requested review of D3897: Merge #12709: [wallet] shuffle sendmany recipients ordering.
Wed, Aug 28, 00:57
nakihito added a comment to D3953: Merge #12618: Set SCHED_BATCH priority on the loadblk thread..

https://github.com/bitcoin/bitcoin/issues/12915
This is supposed to introduce the above bug, but I could not build with the same configure options to test. The fix is made in D3954.

Wed, Aug 28, 00:54
nakihito updated the summary of D3954: Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0.
Wed, Aug 28, 00:52
nakihito created D3954: Merge #12923: util: Pass pthread_self() to pthread_setschedparam instead of 0.
Wed, Aug 28, 00:52
nakihito created D3953: Merge #12618: Set SCHED_BATCH priority on the loadblk thread..
Wed, Aug 28, 00:50

Tue, Aug 27

nakihito created D3952: Merge #12702: [wallet] [rpc] [doc] importprivkey: hint about importmulti.
Tue, Aug 27, 20:31