Page MenuHomePhabricator
Feed Advanced Search

Today

nakihito committed rABC6dd46aa22018: Rename Seeder's CAddrInfo -> CSeederAddrInfo (authored by nakihito).
Rename Seeder's CAddrInfo -> CSeederAddrInfo
Thu, Jun 4, 00:20
nakihito closed D6355: Rename Seeder's CAddrInfo -> CSeederAddrInfo.
Thu, Jun 4, 00:20
nakihito updated the diff for D6355: Rename Seeder's CAddrInfo -> CSeederAddrInfo.

Removed C prefix.

Thu, Jun 4, 00:07
nakihito accepted D6353: Merge #12856: Tests: Add Metaclass for BitcoinTestFramework.
Thu, Jun 4, 00:05
nakihito accepted D6347: [backport#15780] wallet: add cachable amounts for caching credit/debit values.
Thu, Jun 4, 00:03

Yesterday

nakihito accepted D6354: Merge #13047: [trivial] Tidy blocktools.py.
Wed, Jun 3, 23:56
nakihito requested review of D6355: Rename Seeder's CAddrInfo -> CSeederAddrInfo.
Wed, Jun 3, 23:19
nakihito requested review of D6357: Refactor seeder to use CNetMsgMaker to write its messages.
Wed, Jun 3, 23:18
nakihito planned changes to D6357: Refactor seeder to use CNetMsgMaker to write its messages.
Wed, Jun 3, 23:18
nakihito updated the diff for D6357: Refactor seeder to use CNetMsgMaker to write its messages.

Fixed copyrights and removed some debug code.

Wed, Jun 3, 23:18
nakihito planned changes to D6357: Refactor seeder to use CNetMsgMaker to write its messages.
Wed, Jun 3, 22:56
nakihito requested review of D6357: Refactor seeder to use CNetMsgMaker to write its messages.
Wed, Jun 3, 22:56
nakihito planned changes to D6355: Rename Seeder's CAddrInfo -> CSeederAddrInfo.
Wed, Jun 3, 22:46
nakihito requested review of D6355: Rename Seeder's CAddrInfo -> CSeederAddrInfo.
Wed, Jun 3, 22:46

Tue, Jun 2

nakihito planned changes to D5380: Seeder requires good seeds to have block after most recent checkpoint in its chain and bans those that don't.
Tue, Jun 2, 18:59
nakihito planned changes to D6283: Seeder sends GETHEADERS message.
Tue, Jun 2, 18:59
nakihito committed rABC388b66620b94: Merge #13160: wallet: Unlock spent outputs (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13160: wallet: Unlock spent outputs
Tue, Jun 2, 00:42
nakihito closed D6321: Merge #13160: wallet: Unlock spent outputs.
Tue, Jun 2, 00:42

Mon, Jun 1

nakihito committed rABC55beeca040c1: Merge #13507: RPC: Fix parameter count check for importpubkey (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #13507: RPC: Fix parameter count check for importpubkey
Mon, Jun 1, 22:46
nakihito closed D6318: Merge #13507: RPC: Fix parameter count check for importpubkey.
Mon, Jun 1, 22:46
nakihito committed rABCecbe61b28994: Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent
Mon, Jun 1, 22:42
nakihito closed D6319: Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent.
Mon, Jun 1, 22:42
nakihito committed rABC037e7d71bfa7: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost…
Mon, Jun 1, 22:41
nakihito closed D6320: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency..
Mon, Jun 1, 22:40
nakihito requested review of D6321: Merge #13160: wallet: Unlock spent outputs.
Mon, Jun 1, 22:37
nakihito closed D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.
Mon, Jun 1, 22:10
nakihito committed rABC2286545cb467: Merge #13116: Add Clang thread safety annotations for variables guarded by… (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #13116: Add Clang thread safety annotations for variables guarded by…
Mon, Jun 1, 22:10
nakihito requested review of D6320: Merge #13545: tests: Fix test case streams_serializedata_xor. Remove Boost dependency..
Mon, Jun 1, 22:07
nakihito requested review of D6319: Merge #13535: [qa] wallet_basic: Specify minimum required amount for listunspent.
Mon, Jun 1, 21:53
nakihito requested review of D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.
Mon, Jun 1, 21:51
nakihito requested review of D6318: Merge #13507: RPC: Fix parameter count check for importpubkey.
Mon, Jun 1, 21:31
nakihito planned changes to D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.
Mon, Jun 1, 20:59
nakihito requested review of D6317: Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}.
Mon, Jun 1, 20:59
nakihito committed rABC9e6bebaac242: Merge #16481: Trivial: add missing space (authored by fanquake <fanquake@gmail.com>).
Merge #16481: Trivial: add missing space
Mon, Jun 1, 17:46
nakihito closed D6316: Merge #16481: Trivial: add missing space.
Mon, Jun 1, 17:46
nakihito updated the diff for D6283: Seeder sends GETHEADERS message.

Added function.

Mon, Jun 1, 17:36
nakihito requested review of D6316: Merge #16481: Trivial: add missing space.
Mon, Jun 1, 17:16
nakihito committed rABC4b993b82a11c: Merge #12330: Reduce scope of cs_wallet locks in listtransactions (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #12330: Reduce scope of cs_wallet locks in listtransactions
Mon, Jun 1, 17:00
nakihito closed D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.
Mon, Jun 1, 17:00

Sat, May 30

nakihito accepted D6297: [backport#15932] rpc: Serialize in getblock without cs_main.
Sat, May 30, 05:26
nakihito accepted D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.
Sat, May 30, 00:57
nakihito added inline comments to D5956: Add -datadir option to allow specification of seeder's data directory.
Sat, May 30, 00:10
nakihito updated the diff for D5956: Add -datadir option to allow specification of seeder's data directory.

Added some output that specifies the default directory and the directory in use on start up.

Sat, May 30, 00:10

Fri, May 29

nakihito updated the summary of D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.
Fri, May 29, 23:29
nakihito requested review of D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.
Fri, May 29, 23:28
nakihito retitled D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions from Merge #12330: Reduce scope of cs_main and cs_wallet locks in listtransactions to Merge #12330: Reduce scope of cs_wallet locks in listtransactions.
Fri, May 29, 22:42
nakihito planned changes to D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.
Fri, May 29, 22:39
nakihito requested review of D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.
Fri, May 29, 22:38
nakihito committed rABC5cf3c08e993d: Fix WSL file locking by using flock instead of fcntl (authored by Samuel Dobson <dobsonsa68@gmail.com>).
Fix WSL file locking by using flock instead of fcntl
Fri, May 29, 20:39
nakihito closed D6299: Fix WSL file locking by using flock instead of fcntl.
Fri, May 29, 20:39
nakihito requested changes to D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.

Test plan is insufficient.

Fri, May 29, 20:04
nakihito requested changes to D6297: [backport#15932] rpc: Serialize in getblock without cs_main.

Test plan doesn't test lock changes.

Fri, May 29, 20:04
nakihito accepted D6300: [backport#15932] rpc: Add lock annotations to block{,header}ToJSON.
Fri, May 29, 20:01
nakihito accepted D6297: [backport#15932] rpc: Serialize in getblock without cs_main.
Fri, May 29, 19:59
nakihito accepted D6296: [backport#15932] rpc: Use IsValidNumArgs in getblock.
Fri, May 29, 19:57
nakihito accepted D6298: Bump version to 0.21.9.

Should probably start including checking the seeder version?

Fri, May 29, 19:49
nakihito updated the test plan for D6299: Fix WSL file locking by using flock instead of fcntl.
Fri, May 29, 19:41
nakihito requested review of D6299: Fix WSL file locking by using flock instead of fcntl.
Fri, May 29, 19:36
nakihito requested review of D6283: Seeder sends GETHEADERS message.
Fri, May 29, 01:43
nakihito requested review of D5380: Seeder requires good seeds to have block after most recent checkpoint in its chain and bans those that don't.
Fri, May 29, 01:43

Thu, May 28

nakihito updated the summary of D5380: Seeder requires good seeds to have block after most recent checkpoint in its chain and bans those that don't.
Thu, May 28, 21:56
nakihito added reviewers for D6283: Seeder sends GETHEADERS message: deadalnix, jasonbcox.
Thu, May 28, 21:48
nakihito planned changes to D5380: Seeder requires good seeds to have block after most recent checkpoint in its chain and bans those that don't.
Thu, May 28, 21:38
nakihito updated the diff for D5380: Seeder requires good seeds to have block after most recent checkpoint in its chain and bans those that don't.

Rebased off D6283. Restored message request order to version -> verack -> addr -> header because the state transitions are simpler when a node is IBD. Added server module when building to make use of MAX_HEADERS_RESULTS.

Thu, May 28, 21:37
nakihito planned changes to D6283: Seeder sends GETHEADERS message.
Thu, May 28, 19:31
nakihito requested review of D6283: Seeder sends GETHEADERS message.
Thu, May 28, 19:31
nakihito added inline comments to D6271: [backport#15492] [rpc] remove deprecated generate method.
Thu, May 28, 01:35
nakihito added a comment to D6272: [backport#16452] refactor : use RelayTransaction in BroadcastTransaction utility.

Not sure what D6262 has to do with this patch?

Thu, May 28, 00:41
nakihito requested changes to D6271: [backport#15492] [rpc] remove deprecated generate method.

The summary makes it seem like these are two unrelated commits when they're actually from the same PR. Since they are from the same PR, you don't need to link the individual commits.

Thu, May 28, 00:32

Tue, May 26

nakihito retitled D5956: Add -datadir option to allow specification of seeder's data directory from Add -seederdir option to allow specification of seeder's data directory to Add -datadir option to allow specification of seeder's data directory.
Tue, May 26, 17:38

Sat, May 23

nakihito committed rABC41e68443f008: Fix up release notes (authored by nakihito).
Fix up release notes
Sat, May 23, 00:49
nakihito closed D6238: Fix up release notes.
Sat, May 23, 00:49
nakihito requested review of D6238: Fix up release notes.
Sat, May 23, 00:33

Fri, May 22

nakihito committed rABC54e7526f0bfe: Test importing descriptors with key origin information and add release notes (authored by Andrew Chow <achow101-github@achow101.com>).
Test importing descriptors with key origin information and add release notes
Fri, May 22, 23:48
nakihito closed D6215: Test importing descriptors with key origin information and add release notes.
Fri, May 22, 23:48
nakihito committed rABC5dd2d94fb93d: Import KeyOriginData when importing descriptors (authored by nakihito).
Import KeyOriginData when importing descriptors
Fri, May 22, 23:35
nakihito closed D6230: Import KeyOriginData when importing descriptors.
Fri, May 22, 23:35
nakihito committed rABCed9768d52cfc: Implement a function to add KeyOriginInfo to a wallet (authored by nakihito).
Implement a function to add KeyOriginInfo to a wallet
Fri, May 22, 23:26
nakihito closed D6229: Implement a function to add KeyOriginInfo to a wallet.
Fri, May 22, 23:25
nakihito committed rABCc4f1a7bf5d73: Store key origin info in key metadata (authored by Andrew Chow <achow101-github@achow101.com>).
Store key origin info in key metadata
Fri, May 22, 23:20
nakihito closed D6228: Store key origin info in key metadata.
Fri, May 22, 23:20
nakihito committed rABC600f5a86a202: Add a method to CWallet to write just CKeyMetadata (authored by nakihito).
Add a method to CWallet to write just CKeyMetadata
Fri, May 22, 23:07
nakihito closed D6227: Add a method to CWallet to write just CKeyMetadata.
Fri, May 22, 23:07
nakihito committed rABC63a0aeceba57: Remove hdmasterkeyid (authored by nakihito).
Remove hdmasterkeyid
Fri, May 22, 22:58
nakihito closed D5933: Remove hdmasterkeyid.
Fri, May 22, 22:58
nakihito committed rABC179223f0b843: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp} (authored by Andrew Chow <achow101-github@achow101.com>).
Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}
Fri, May 22, 22:47
nakihito closed D6204: Add WriteHDKeypath function and move *HDKeypath to util/bip32.{h,cpp}.
Fri, May 22, 22:47
nakihito committed rABCeb725bf601e3: Refactor keymetadata writing to a separate method (authored by Andrew Chow <achow101-github@achow101.com>).
Refactor keymetadata writing to a separate method
Fri, May 22, 22:28
nakihito closed D6004: Refactor keymetadata writing to a separate method.
Fri, May 22, 22:27
nakihito committed rABC2429c346e2ed: Merge #15746: rpc: RPCHelpMan: Always name dictionary keys (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #15746: rpc: RPCHelpMan: Always name dictionary keys
Fri, May 22, 21:34
nakihito closed D6231: Merge #15746: rpc: RPCHelpMan: Always name dictionary keys.
Fri, May 22, 21:33
nakihito committed rABC76d7d0212718: Merge #14417: Fix listreceivedbyaddress not taking address as a string (authored by MarcoFalke <falke.marco@gmail.com>).
Merge #14417: Fix listreceivedbyaddress not taking address as a string
Fri, May 22, 21:27
nakihito closed D6232: Merge #14417: Fix listreceivedbyaddress not taking address as a string.
Fri, May 22, 21:27
nakihito requested review of D6232: Merge #14417: Fix listreceivedbyaddress not taking address as a string.
Fri, May 22, 20:52
nakihito requested review of D6231: Merge #15746: rpc: RPCHelpMan: Always name dictionary keys.
Fri, May 22, 20:48
nakihito updated the summary of D6231: Merge #15746: rpc: RPCHelpMan: Always name dictionary keys.
Fri, May 22, 20:48
nakihito planned changes to D6231: Merge #15746: rpc: RPCHelpMan: Always name dictionary keys.
Fri, May 22, 20:46
nakihito requested review of D6231: Merge #15746: rpc: RPCHelpMan: Always name dictionary keys.
Fri, May 22, 20:46
nakihito committed rABCe057440b5892: Merge #14129: Trivial: update clang thread-safety docs url (authored by Wladimir J. van der Laan <laanwj@gmail.com>).
Merge #14129: Trivial: update clang thread-safety docs url
Fri, May 22, 19:59
nakihito closed D6226: Merge #14129: Trivial: update clang thread-safety docs url.
Fri, May 22, 19:59