Page MenuHomePhabricator

Revert "OP_REVERSEBYTES activation logic"
ClosedPublic

Authored by deadalnix on Wed, Feb 12, 22:23.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCadaa9fe22fbc: Revert "OP_REVERSEBYTES activation logic"
Summary

This reverts commit fcf22e8fcc94ebd7554bf4345608f86cdf54b7fb.

This is breaking the nowallet build and @tobias_ruck do not seem to be reachable

Test Plan

Build without wallet and run the integration test suite.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Wed, Feb 12, 22:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Feb 12, 22:24
Fabien accepted this revision.Wed, Feb 12, 22:49
This revision is now accepted and ready to land.Wed, Feb 12, 22:49
This revision was automatically updated to reflect the committed changes.

I am guessing this is due to D5184, and we are going to see this happen over and over until nowallet build is added to the Diff testing CI

For the record in future (as this is going to happen again and again) the required change to fix this kind of thing is not hard, you just need to change the generate rpc to generatetoaddress rpc, see D5267.