Page MenuHomePhabricator

Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet
ClosedPublic

Authored by nakihito on Tue, Feb 11, 21:40.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCd2436be68d5e: Merge #14236: qa: generate --> generatetoaddress change to allow tests run…
Summary

0ca4c8b3c6 Changed functional tests which do not require wallets to run without (sanket1729)

Pull request description:

Addresses #14216 . Changed Changed `get_deterministic_priv_key()` to return named tuple`(address, key)`
I have tried to be exhaustive as possible in maximum coverage for non-wallet mode without affecting any coverage for wallet mode.

However, I could not check the tests in wallet mode because of timeout issues. Hopefully, travis job checks those.

Tests `feature_block.py`, `feature_logging.py` and `feature_reindex.py` were skipping despite having no direct dependency on any wallet functions. So, I have also disabled the `skip_test_no_wallet()` for those files too.

Tree-SHA512: 8f84bd8400a732d4266c7518d5cbcf1eb761f623a64a74849e0470142c8ef22cb75364474ddae75d9213c3d16659a52917b5ed979a313695da6abd16c4fd7445

Backport of Core PR14236
https://github.com/bitcoin/bitcoin/pull/14236/

Test Plan
cmake -GNinja .. -DBUILD_BITCOIN_WALLET=OFF
ninja check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Tue, Feb 11, 21:40
Owners added a reviewer: Restricted Owners Package.Tue, Feb 11, 21:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Feb 11, 21:40
teamcity edited the summary of this revision. (Show Details)Tue, Feb 11, 21:40

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Tue, Feb 11, 23:08
This revision is now accepted and ready to land.Tue, Feb 11, 23:08

The code looks correct, but the test plan is inadequate.

nakihito edited the test plan for this revision. (Show Details)Tue, Feb 11, 23:11

The code looks correct, but the test plan is inadequate.

Sorry. Copy paste accident that i didn't catch. Updated test plan.