HomePhabricator

Merge #14236: qa: generate --> generatetoaddress change to allow tests run…

Authored by MarcoFalke <falke.marco@gmail.com> on Sep 17 2018, 18:00.

Description

Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet

Summary:
0ca4c8b3c6 Changed functional tests which do not require wallets to run without (sanket1729)

Pull request description:

Addresses #14216 . Changed Changed `get_deterministic_priv_key()` to return named tuple`(address, key)`
I have tried to be exhaustive as possible in maximum coverage for non-wallet mode without affecting any coverage for wallet mode.

However, I could not check the tests in wallet mode because of timeout issues. Hopefully, travis job checks those.

Tests `feature_block.py`, `feature_logging.py` and `feature_reindex.py` were skipping despite having no direct dependency on any wallet functions. So, I have also disabled the `skip_test_no_wallet()` for those files too.

Tree-SHA512: 8f84bd8400a732d4266c7518d5cbcf1eb761f623a64a74849e0470142c8ef22cb75364474ddae75d9213c3d16659a52917b5ed979a313695da6abd16c4fd7445

Backport of Core PR14236
https://github.com/bitcoin/bitcoin/pull/14236/

Test Plan:

cmake -GNinja .. -DBUILD_BITCOIN_WALLET=OFF
ninja check-functional-extended

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5267

Details

Committed
nakihitoFeb 11 2020, 23:26
Pushed
nakihitoFeb 11 2020, 23:26
Reviewer
Restricted Owners Package
Differential Revision
D5267: Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet
Parents
rABC5b6f369672e7: Use a temporary datadir and non-default RPC port when testing seeds
Branches
Unknown
Tags
Unknown