Page MenuHomePhabricator
Differential D5267

Merge #14236: qa: generate --> generatetoaddress change to allow tests run without wallet
ClosedPublic
Actions

Authored by nakihito on Feb 11 2020, 21:40.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGd2436be68d5e: Merge #14236: qa: generate --> generatetoaddress change to allow tests run…
rABCd2436be68d5e: Merge #14236: qa: generate --> generatetoaddress change to allow tests run…
Summary

0ca4c8b3c6 Changed functional tests which do not require wallets to run without (sanket1729)

Pull request description:

Addresses #14216 . Changed Changed `get_deterministic_priv_key()` to return named tuple`(address, key)`
I have tried to be exhaustive as possible in maximum coverage for non-wallet mode without affecting any coverage for wallet mode.

However, I could not check the tests in wallet mode because of timeout issues. Hopefully, travis job checks those.

Tests `feature_block.py`, `feature_logging.py` and `feature_reindex.py` were skipping despite having no direct dependency on any wallet functions. So, I have also disabled the `skip_test_no_wallet()` for those files too.

Tree-SHA512: 8f84bd8400a732d4266c7518d5cbcf1eb761f623a64a74849e0470142c8ef22cb75364474ddae75d9213c3d16659a52917b5ed979a313695da6abd16c4fd7445

Backport of Core PR14236
https://github.com/bitcoin/bitcoin/pull/14236/

Test Plan
cmake -GNinja .. -DBUILD_BITCOIN_WALLET=OFF
ninja check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14236
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9448
Build 16817: Default Diff Build & Tests
Build 16816: arc lint + arc unit

Event Timeline

nakihito created this revision.Feb 11 2020, 21:40
Owners added a reviewer: Restricted Owners Package.Feb 11 2020, 21:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 11 2020, 21:40
teamcity added a comment.Feb 11 2020, 21:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity edited the summary of this revision. (Show Details)Feb 11 2020, 21:40

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 11 2020, 21:49

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9448: Diff 16306.Feb 11 2020, 21:49
deadalnix accepted this revision.Feb 11 2020, 23:08
This revision is now accepted and ready to land.Feb 11 2020, 23:08
deadalnix added a comment.Feb 11 2020, 23:08

The code looks correct, but the test plan is inadequate.

nakihito edited the test plan for this revision. (Show Details)Feb 11 2020, 23:11
nakihito added a comment.Feb 11 2020, 23:13
In D5267#127241, @deadalnix wrote:

The code looks correct, but the test plan is inadequate.

Sorry. Copy paste accident that i didn't catch. Updated test plan.

Closed by commit rABCd2436be68d5e: Merge #14236: qa: generate --> generatetoaddress change to allow tests run… (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyFeb 11 2020, 23:26
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCd2436be68d5e: Merge #14236: qa: generate --> generatetoaddress change to allow tests run….
markblundeberg mentioned this in D5278: Revert "OP_REVERSEBYTES activation logic".Feb 13 2020, 03:51
nakihito added a commit: rSTAGINGd2436be68d5e: Merge #14236: qa: generate --> generatetoaddress change to allow tests run….Apr 7 2020, 22:58

Revision Contents
Changeset List

Diff 16306

View Options

test/functional/abc-finalize-block.py

Loading...
View Options

test/functional/abc-get-invalid-block.py

Loading...
View Options

test/functional/abc-minimaldata.py

Loading...
View Options

test/functional/abc-schnorr.py

Loading...
View Options

test/functional/abc-schnorrmultisig.py

Loading...
View Options

test/functional/example_test.py

Loading...
View Options

test/functional/feature_block.py

Loading...
View Options

test/functional/feature_blocksdir.py

Loading...
View Options

test/functional/feature_logging.py

Loading...
View Options

test/functional/feature_minchainwork.py

Loading...
View Options

test/functional/feature_reindex.py

Loading...
View Options

test/functional/mining_basic.py

Loading...
View Options

test/functional/p2p_fingerprint.py

Loading...
View Options

test/functional/p2p_invalid_block.py

Loading...
View Options

test/functional/p2p_invalid_locator.py

Loading...
View Options

test/functional/p2p_invalid_tx.py

Loading...
View Options

test/functional/p2p_leak.py

Loading...
View Options

test/functional/p2p_node_network_limited.py

Loading...
View Options

test/functional/p2p_sendheaders.py

Loading...
View Options

test/functional/p2p_unrequested_blocks.py

Loading...
View Options

test/functional/rpc_blockchain.py

Loading...
View Options

test/functional/rpc_getchaintips.py

Loading...
View Options

test/functional/rpc_invalidateblock.py

Loading...
View Options

test/functional/rpc_preciousblock.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...