Page MenuHomePhabricator
Differential D5278

Revert "OP_REVERSEBYTES activation logic"
ClosedPublic
Actions

Authored by deadalnix on Feb 12 2020, 22:23.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGadaa9fe22fbc: Revert "OP_REVERSEBYTES activation logic"
rABCadaa9fe22fbc: Revert "OP_REVERSEBYTES activation logic"
Summary

This reverts commit fcf22e8fcc94ebd7554bf4345608f86cdf54b7fb.

This is breaking the nowallet build and @tobias_ruck do not seem to be reachable

Test Plan

Build without wallet and run the integration test suite.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
revertnowallet
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9466
Build 16848: Default Diff Build & Tests
Build 16847: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 12 2020, 22:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 12 2020, 22:24
teamcity added a comment.Feb 12 2020, 22:24

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 12 2020, 22:33

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9466: Diff 16332.Feb 12 2020, 22:33
Fabien accepted this revision.Feb 12 2020, 22:49
This revision is now accepted and ready to land.Feb 12 2020, 22:49
Closed by commit rABCadaa9fe22fbc: Revert "OP_REVERSEBYTES activation logic" (authored by deadalnix). · Explain WhyFeb 12 2020, 22:52
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCadaa9fe22fbc: Revert "OP_REVERSEBYTES activation logic".
markblundeberg added a subscriber: markblundeberg.Feb 13 2020, 03:17

I am guessing this is due to D5184, and we are going to see this happen over and over until nowallet build is added to the Diff testing CI

markblundeberg added a comment.Feb 13 2020, 03:51

For the record in future (as this is going to happen again and again) the required change to fix this kind of thing is not hard, you just need to change the generate rpc to generatetoaddress rpc, see D5267.

deadalnix added a commit: rSTAGINGadaa9fe22fbc: Revert "OP_REVERSEBYTES activation logic".Apr 7 2020, 22:59

Revision Contents
Changeset List

PathSize
src/
20 lines
test/
functional/

Diff 16332

View Options

src/validation.cpp

Loading...
View Options

test/functional/abc-op-reversebytes-activation.py

Loading...