Page MenuHomePhabricator

Revert "OP_REVERSEBYTES activation logic"
ClosedPublic

Authored by deadalnix on Feb 12 2020, 22:23.

Details

Summary

This reverts commit fcf22e8fcc94ebd7554bf4345608f86cdf54b7fb.

This is breaking the nowallet build and @tobias_ruck do not seem to be reachable

Test Plan

Build without wallet and run the integration test suite.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
revertnowallet
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9466
Build 16848: Default Diff Build & Tests
Build 16847: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 12 2020, 22:49
This revision was automatically updated to reflect the committed changes.

I am guessing this is due to D5184, and we are going to see this happen over and over until nowallet build is added to the Diff testing CI

For the record in future (as this is going to happen again and again) the required change to fix this kind of thing is not hard, you just need to change the generate rpc to generatetoaddress rpc, see D5267.