Page MenuHomePhabricator

Merge #14180: qa: Run all tests even if wallet is not compiled
ClosedPublic

Authored by nakihito on Feb 6 2020, 21:48.

Details

Summary

fac95398366f644911b58f1605e6bc37fb76782d qa: Run all tests even if wallet is not compiled (MarcoFalke)
faa669cbcd1fc799517b523b0f850e01b11bf40a qa: Premine to deterministic address with -disablewallet (MarcoFalke)

Pull request description:

Currently the test_runner would exit if the wallet was not compiled into the Bitcoin Core executable. However, a lot of the tests run without the wallet just fine and there is no need to globally require the wallet to run the tests.

Tree-SHA512: 63177260aa29126fd20f0be217a82b10b62288ab846f96f1cbcc3bd2c52702437703475d91eae3f8d821a3149fc62b725a4c5b2a7b3657b67ffcbc81532a03bb

Backport of Core PR14180

Test Plan
cmake -GNinja .. -DBUILD_BITCOIN_WALLET=OFF
ninja check
ninja check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Feb 6 2020, 21:48
Owners added a reviewer: Restricted Owners Package.Feb 6 2020, 21:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2020, 21:48
nakihito planned changes to this revision.Feb 6 2020, 21:48
teamcity edited the summary of this revision. (Show Details)Feb 6 2020, 21:49

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

nakihito requested review of this revision.Feb 6 2020, 22:34
nakihito added inline comments.
test/functional/feature_pruning.py
109 ↗(On Diff #16085)

Other than this addition, the changes to this file were all formatting.

test/functional/wallet_dump.py
34 ↗(On Diff #16085)

Changes made previously in D4450.

81 ↗(On Diff #16085)

This change is mostly formatting changes.

test/functional/wallet_import_rescan.py
149 ↗(On Diff #16085)

Changes made previously in D4450.

test/functional/wallet_listreceivedby.py
27 ↗(On Diff #16085)

Changes made previously in D4450.

deadalnix accepted this revision.Feb 7 2020, 02:05
This revision is now accepted and ready to land.Feb 7 2020, 02:05