HomePhabricator

Merge #14180: qa: Run all tests even if wallet is not compiled

Authored by Wladimir J. van der Laan <laanwj@gmail.com> on Sep 13 2018, 10:33.

Description

Merge #14180: qa: Run all tests even if wallet is not compiled

Summary:
fac95398366f644911b58f1605e6bc37fb76782d qa: Run all tests even if wallet is not compiled (MarcoFalke)
faa669cbcd1fc799517b523b0f850e01b11bf40a qa: Premine to deterministic address with -disablewallet (MarcoFalke)

Pull request description:

Currently the test_runner would exit if the wallet was not compiled into the Bitcoin Core executable. However, a lot of the tests run without the wallet just fine and there is no need to globally require the wallet to run the tests.

Tree-SHA512: 63177260aa29126fd20f0be217a82b10b62288ab846f96f1cbcc3bd2c52702437703475d91eae3f8d821a3149fc62b725a4c5b2a7b3657b67ffcbc81532a03bb

Backport of Core PR14180

Test Plan:

cmake -GNinja .. -DBUILD_BITCOIN_WALLET=OFF
ninja check
ninja check-functional-extended

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5184

Details

Committed
nakihitoFeb 7 2020, 18:33
Pushed
nakihitoFeb 7 2020, 18:33
Reviewer
Restricted Owners Package
Differential Revision
D5184: Merge #14180: qa: Run all tests even if wallet is not compiled
Parents
rABC651157d3ffa6: Update copyright_header.py to not duplicate parts of the header
Branches
Unknown
Tags
Unknown