Differential D5184

Merge #14180: qa: Run all tests even if wallet is not compiled
ClosedPublic
Actions

Authored by nakihito on Feb 6 2020, 21:48.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING4dfa4724abcf: Merge #14180: qa: Run all tests even if wallet is not compiled
rABC4dfa4724abcf: Merge #14180: qa: Run all tests even if wallet is not compiled

Summary

fac95398366f644911b58f1605e6bc37fb76782d qa: Run all tests even if wallet is not compiled (MarcoFalke)
faa669cbcd1fc799517b523b0f850e01b11bf40a qa: Premine to deterministic address with -disablewallet (MarcoFalke)

Pull request description:

Currently the test_runner would exit if the wallet was not compiled into the Bitcoin Core executable. However, a lot of the tests run without the wallet just fine and there is no need to globally require the wallet to run the tests.

Tree-SHA512: 63177260aa29126fd20f0be217a82b10b62288ab846f96f1cbcc3bd2c52702437703475d91eae3f8d821a3149fc62b725a4c5b2a7b3657b67ffcbc81532a03bb

Backport of Core PR14180

Test Plan

cmake -GNinja .. -DBUILD_BITCOIN_WALLET=OFF
ninja check
ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Feb 6 2020, 21:48

Owners added a reviewer: Restricted Owners Package.Feb 6 2020, 21:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2020, 21:48

nakihito planned changes to this revision.Feb 6 2020, 21:48

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito added a child revision: D5185: Merge #14179: qa: Fixups to "Run all tests even if wallet is not compiled".Feb 6 2020, 21:50

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9309: Diff 16085.Feb 6 2020, 22:02

nakihito requested review of this revision.Feb 6 2020, 22:34

nakihito added inline comments.

test/functional/feature_pruning.py
109 ↗	(On Diff #16085)	Other than this addition, the changes to this file were all formatting.
test/functional/wallet_dump.py
34 ↗	(On Diff #16085)	Changes made previously in D4450.
81 ↗	(On Diff #16085)	This change is mostly formatting changes.
test/functional/wallet_import_rescan.py
149 ↗	(On Diff #16085)	Changes made previously in D4450.
test/functional/wallet_listreceivedby.py
27 ↗	(On Diff #16085)	Changes made previously in D4450.

deadalnix accepted this revision.Feb 7 2020, 02:05

This revision is now accepted and ready to land.Feb 7 2020, 02:05

Closed by commit rABC4dfa4724abcf: Merge #14180: qa: Run all tests even if wallet is not compiled (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyFeb 7 2020, 18:33

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC4dfa4724abcf: Merge #14180: qa: Run all tests even if wallet is not compiled.

Fabien mentioned this in D5279: [CI] Run the functional tests when wallet is disable.Feb 12 2020, 22:43

markblundeberg mentioned this in D5278: Revert "OP_REVERSEBYTES activation logic".Feb 13 2020, 03:17

Fabien mentioned this in rABC2177ccfbe208: [CI] Run the functional tests when wallet is disable.Feb 13 2020, 07:30

nakihito added a commit: rSTAGING4dfa4724abcf: Merge #14180: qa: Run all tests even if wallet is not compiled.Apr 7 2020, 22:54

Fabien mentioned this in rSTAGING2177ccfbe208: [CI] Run the functional tests when wallet is disable.Apr 7 2020, 22:59

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-finalize-block.py

3 lines

abc-get-invalid-block.py

3 lines

abc-magnetic-anomaly-mining.py

3 lines

abc-minimaldata.py

3 lines

abc-parkedchain.py

3 lines

3 lines

abc-schnorrmultisig.py

3 lines

abc-sigops-mempool-mining.py

3 lines

abc-wallet-standardness.py

3 lines

example_test.py

5 lines

feature_bip68_sequence.py

3 lines

feature_block.py

3 lines

feature_blocksdir.py

3 lines

feature_cltv.py

3 lines

feature_config_args.py

3 lines

feature_csv_activation.py

3 lines

feature_dbcrash.py

3 lines

feature_dersig.py

3 lines

feature_logging.py

3 lines

feature_maxuploadtarget.py

3 lines

feature_minchainwork.py

3 lines

feature_notifications.py

3 lines

feature_pruning.py

3 lines

feature_reindex.py

3 lines

interface_bitcoin_cli.py

3 lines

interface_rest.py

3 lines

interface_zmq.py

14 lines

mempool_accept.py

3 lines

mempool_limit.py

3 lines

mempool_packages.py

3 lines

mempool_persist.py

3 lines

mempool_reorg.py

3 lines

mempool_resurrect.py

3 lines

mempool_spend_coinbase.py

3 lines

mining_basic.py

3 lines

mining_getblocktemplate_longpoll.py

3 lines

mining_prioritisetransaction.py

3 lines

p2p_compactblocks.py

3 lines

p2p_feefilter.py

3 lines

p2p_fingerprint.py

3 lines

p2p_invalid_block.py

3 lines

p2p_invalid_locator.py

3 lines

p2p_invalid_tx.py

3 lines

3 lines

p2p_node_network_limited.py

3 lines

p2p_sendheaders.py

3 lines

p2p_unrequested_blocks.py

3 lines

rpc_blockchain.py

3 lines

rpc_createmultisig.py

3 lines

rpc_deprecated.py

3 lines

rpc_estimatefee.py

3 lines

rpc_fundrawtransaction.py

3 lines

rpc_getchaintips.py

3 lines

9 lines

rpc_invalidateblock.py

3 lines

rpc_preciousblock.py

3 lines

3 lines

rpc_rawtransaction.py

3 lines

rpc_scantxoutset.py

3 lines

rpc_signmessage.py

3 lines

rpc_signrawtransaction.py

3 lines

rpc_txoutproof.py

3 lines

12 lines

test_framework/

test_framework.py

72 lines

10 lines

wallet_abandonconflict.py

3 lines

wallet_backup.py

3 lines

wallet_basic.py

3 lines

3 lines

wallet_encryption.py

3 lines

wallet_groups.py

3 lines

3 lines

wallet_import_rescan.py

3 lines

wallet_importmulti.py

3 lines

wallet_importprunedfunds.py

3 lines

wallet_keypool.py

3 lines

wallet_keypool_topup.py

3 lines

wallet_labels.py

3 lines

wallet_listreceivedby.py

3 lines

wallet_listsinceblock.py

3 lines

wallet_listtransactions.py

3 lines

wallet_multiwallet.py

3 lines

wallet_resendwallettransactions.py

3 lines

wallet_txn_clone.py

3 lines

wallet_txn_doublespend.py

3 lines

wallet_zapwallettxes.py

3 lines

Diff 16143

test/functional/abc-finalize-block.py

Loading...

test/functional/abc-get-invalid-block.py

Loading...

test/functional/abc-magnetic-anomaly-mining.py

Loading...

test/functional/abc-minimaldata.py

Loading...

test/functional/abc-parkedchain.py

Loading...

test/functional/abc-schnorr.py

Loading...

test/functional/abc-schnorrmultisig.py

Loading...

test/functional/abc-sigops-mempool-mining.py

Loading...

test/functional/abc-wallet-standardness.py

Loading...

test/functional/example_test.py

Loading...

test/functional/feature_bip68_sequence.py

Loading...

test/functional/feature_block.py

Loading...

test/functional/feature_blocksdir.py

Loading...

test/functional/feature_cltv.py

Loading...

test/functional/feature_config_args.py

Loading...

test/functional/feature_csv_activation.py

Loading...

test/functional/feature_dbcrash.py

Loading...

test/functional/feature_dersig.py

Loading...

test/functional/feature_logging.py

Loading...

test/functional/feature_maxuploadtarget.py

Loading...

test/functional/feature_minchainwork.py

Loading...

test/functional/feature_notifications.py

Loading...

test/functional/feature_pruning.py

Loading...

test/functional/feature_reindex.py

Loading...

test/functional/interface_bitcoin_cli.py

Loading...

test/functional/interface_rest.py

Loading...

test/functional/interface_zmq.py

Loading...

test/functional/mempool_accept.py

Loading...

test/functional/mempool_limit.py

Loading...

test/functional/mempool_packages.py

Loading...

test/functional/mempool_persist.py

Loading...

test/functional/mempool_reorg.py

Loading...

test/functional/mempool_resurrect.py

Loading...

test/functional/mempool_spend_coinbase.py

Loading...

test/functional/mining_basic.py

Loading...

test/functional/mining_getblocktemplate_longpoll.py

Loading...

test/functional/mining_prioritisetransaction.py

Loading...

test/functional/p2p_compactblocks.py

Loading...

test/functional/p2p_feefilter.py

Loading...

test/functional/p2p_fingerprint.py

Loading...

test/functional/p2p_invalid_block.py

Loading...

test/functional/p2p_invalid_locator.py

Loading...

test/functional/p2p_invalid_tx.py

Loading...

test/functional/p2p_leak.py

Loading...

test/functional/p2p_node_network_limited.py

Loading...

test/functional/p2p_sendheaders.py

Loading...

test/functional/p2p_unrequested_blocks.py

Loading...

test/functional/rpc_blockchain.py

Loading...

test/functional/rpc_createmultisig.py

Loading...

test/functional/rpc_deprecated.py

Loading...

test/functional/rpc_estimatefee.py

Loading...

test/functional/rpc_fundrawtransaction.py

Loading...

test/functional/rpc_getchaintips.py

Loading...

test/functional/rpc_help.py

Loading...

test/functional/rpc_invalidateblock.py

Loading...

test/functional/rpc_preciousblock.py

Loading...

test/functional/rpc_psbt.py

Loading...

test/functional/rpc_rawtransaction.py

Loading...

test/functional/rpc_scantxoutset.py

Loading...

test/functional/rpc_signmessage.py

Loading...

test/functional/rpc_signrawtransaction.py

Loading...

test/functional/rpc_txoutproof.py

Loading...

test/functional/rpc_zmq.py

Loading...

test/functional/test_framework/test_framework.py

Loading...

test/functional/test_runner.py

Loading...

test/functional/wallet_abandonconflict.py

Loading...

test/functional/wallet_backup.py

Loading...

test/functional/wallet_basic.py

Loading...

test/functional/wallet_dump.py

Loading...

test/functional/wallet_encryption.py

Loading...

test/functional/wallet_groups.py

Loading...

test/functional/wallet_hd.py

Loading...

test/functional/wallet_import_rescan.py

Loading...

test/functional/wallet_importmulti.py

Loading...

test/functional/wallet_importprunedfunds.py

Loading...

test/functional/wallet_keypool.py

Loading...

test/functional/wallet_keypool_topup.py

Loading...

test/functional/wallet_labels.py

Loading...

test/functional/wallet_listreceivedby.py

Loading...

test/functional/wallet_listsinceblock.py

Loading...

test/functional/wallet_listtransactions.py

Loading...

test/functional/wallet_multiwallet.py

Loading...

test/functional/wallet_resendwallettransactions.py

Loading...

test/functional/wallet_txn_clone.py

Loading...

test/functional/wallet_txn_doublespend.py

Loading...

test/functional/wallet_zapwallettxes.py

Loading...