Page MenuHomePhabricator

Merge #14822: bench: Destroy wallet txs instead of leaking their memory
ClosedPublic

Authored by markblundeberg on Tue, Feb 11, 05:23.

Details

Summary

PR14822 backport

fa5cef0f78 bench: Destroy wallet txs instead of leaking their memory (MarcoFalke)

Pull request description:

This should destroy the wallet txs when the benchmark ends to avoid having to hold them when the following benchmarks run.

Depends on D5251 (only for having updated valgrind suppressions, besides this it is landable anytime)

Test Plan

ninja bench-bitcoin

Run the following and observe there are no more leaks--

ninja src/bench/bitcoin-bench
valgrind --suppressions=../contrib/valgrind.supp src/bench/bitcoin-bench -evals=1 -scaling=0.0

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Tue, Feb 11, 05:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Feb 11, 05:23
teamcity edited the summary of this revision. (Show Details)Tue, Feb 11, 05:23

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

markblundeberg edited the test plan for this revision. (Show Details)Tue, Feb 11, 05:42
markblundeberg edited the summary of this revision. (Show Details)Tue, Feb 11, 07:40
markblundeberg edited the summary of this revision. (Show Details)
markblundeberg edited the test plan for this revision. (Show Details)Tue, Feb 11, 09:48
Fabien accepted this revision.Tue, Feb 11, 10:52
This revision is now accepted and ready to land.Tue, Feb 11, 10:52