Paths

Table of Contentst

Differential D5252

Merge #14822: bench: Destroy wallet txs instead of leaking their memory
ClosedPublic
Actions

Authored by markblundeberg on Feb 11 2020, 05:23.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGf4f3364e9f9b: Merge #14822: bench: Destroy wallet txs instead of leaking their memory
rABCf4f3364e9f9b: Merge #14822: bench: Destroy wallet txs instead of leaking their memory

Summary

PR14822 backport

fa5cef0f78 bench: Destroy wallet txs instead of leaking their memory (MarcoFalke)

Pull request description:

This should destroy the wallet txs when the benchmark ends to avoid having to hold them when the following benchmarks run.

Depends on D5251 (only for having updated valgrind suppressions, besides this it is landable anytime)

Test Plan

ninja bench-bitcoin

Run the following and observe there are no more leaks--

ninja src/bench/bitcoin-bench
valgrind --suppressions=../contrib/valgrind.supp src/bench/bitcoin-bench -evals=1 -scaling=0.0

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14822

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9414
Build 16757: Default Diff Build & Tests
Build 16756: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 11 2020, 05:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 11 2020, 05:23

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B9414: Diff 16253.Feb 11 2020, 05:32

Build Bitcoin-ABC / Diffs / Diff Testing passed.

markblundeberg edited the test plan for this revision. (Show Details)Feb 11 2020, 05:42

markblundeberg edited the summary of this revision. (Show Details)Feb 11 2020, 07:40

markblundeberg edited the summary of this revision. (Show Details)

markblundeberg edited the test plan for this revision. (Show Details)Feb 11 2020, 09:48

Fabien accepted this revision.Feb 11 2020, 10:52

This revision is now accepted and ready to land.Feb 11 2020, 10:52

Closed by commit rABCf4f3364e9f9b: Merge #14822: bench: Destroy wallet txs instead of leaking their memory (authored by MarcoFalke <falke.marco@gmail.com>, committed by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 11 2020, 11:52

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABCf4f3364e9f9b: Merge #14822: bench: Destroy wallet txs instead of leaking their memory.

Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGINGf4f3364e9f9b: Merge #14822: bench: Destroy wallet txs instead of leaking their memory.Apr 7 2020, 22:57

Revision Contents
Changeset List

Path

Size

src/

bench/

coin_selection.cpp

32 lines

Diff 16253

View Options

src/bench/coin_selection.cpp

Merge #14822: bench: Destroy wallet txs instead of leaking their memoryClosedPublicActions