HomePhabricator

Merge #14822: bench: Destroy wallet txs instead of leaking their memory

Description

Merge #14822: bench: Destroy wallet txs instead of leaking their memory

Summary:
PR14822 backport

fa5cef0f78 bench: Destroy wallet txs instead of leaking their memory (MarcoFalke)

Pull request description:

This should destroy the wallet txs when the benchmark ends to avoid having to hold them when the following benchmarks run.

Depends on D5251 (only for having updated valgrind suppressions, besides this it is landable anytime)

Test Plan:
ninja bench-bitcoin

Run the following and observe there are no more leaks--

ninja src/bench/bitcoin-bench
valgrind --suppressions=../contrib/valgrind.supp src/bench/bitcoin-bench -evals=1 -scaling=0.0

Reviewers: Fabien, #bitcoin_abc

Reviewed By: Fabien, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D5252

Details

Provenance
MarcoFalke <falke.marco@gmail.com>Authored on Nov 28 2018, 16:13
Mark Lundeberg <markblundeberg@users.noreply.github.com>Committed on Feb 11 2020, 11:52
markblundebergPushed on Feb 11 2020, 11:52
Reviewer
Restricted Project
Differential Revision
D5252: Merge #14822: bench: Destroy wallet txs instead of leaking their memory
Parents
rABC686b53ce4188: Merge #17455: tests: Update valgrind suppressions
Branches
Unknown
Tags
Unknown