Page MenuHomePhabricator

[CMAKE] Use the new FindPython module
ClosedPublic

Authored by Fabien on Thu, Feb 13, 13:23.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rABCd15280fe013d: [CMAKE] Use the new FindPython module
Summary

The FindPythonInterp is replaced by FindPython since cmake 3.12.
This also solves a conflict with some pyenv installed versions (thanks @markblundeberg for reporting the issue !).

Test Plan
ninja all bitcoin-bench check check-security check-functional

Run the OSX Gitian build.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Thu, Feb 13, 13:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Feb 13, 13:23

Thanks! I'm going to give this a whirl... (I was the one having pyenv issues 😊 )

Fabien edited the summary of this revision. (Show Details)Thu, Feb 13, 13:38
markblundeberg accepted this revision.Thu, Feb 13, 13:51

All good!

(TIL about check-security)

This revision is now accepted and ready to land.Thu, Feb 13, 13:51
This revision was automatically updated to reflect the committed changes.