HomePhabricator

Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC

Authored by MarcoFalke <falke.marco@gmail.com> on Nov 4 2018, 22:22.

Description

Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC

Summary:
14a06525b2 tests: add test for 'getaddressinfo' RPC result 'ischange' field (whythat)
93d1aa9abc rpcwallet: add 'ischange' field to 'getaddressinfo' response (whythat)

Pull request description:

Implementation of proposal in #14396.

This introduces `CWallet::IsChange(CScript&)` method and replaces original `CWallet::IsChange(CTxOut&)` method with overloaded version that delegates to the new method with *txout*'s `scriptPubKey`. In this way `TODO` note from the original method can still be addressed in a single place.

Tree-SHA512: ef5dbc82d76b4b9b2fa6a70abc3385a677c55021f79e187ee2f392ee32bc6b406191f4129acae5c17b0206e72b6712e7e0cad574a4bbd966871c2e656c45e041

Backport of Core PR14410
https://github.com/bitcoin/bitcoin/pull/14410/

Test Plan:

ninja check
ninja check-functional

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D5280

Details

Committed
nakihitoThu, Feb 13, 19:44
Pushed
nakihitoThu, Feb 13, 19:44
Reviewer
Restricted Owners Package
Differential Revision
D5280: Merge #14410: rpcwallet: 'ischange' field for 'getaddressinfo' RPC
Parents
rABC7f63be6a4ba6: Fix a race condition with rpc ports in check-seeds
Branches
Unknown
Tags
Unknown