HomePhabricator

Fix a race condition with rpc ports in check-seeds

Authored by jasonbcox on Tue, Feb 11, 21:45.

Description

Fix a race condition with rpc ports in check-seeds

Summary:
The RPC port from the first run of test-seeds is not guaranteed to be closed/cleaned up
by the OS by the time the second run on test-seeds occurs. Without this patch, check-seeds is flaky
and fails at random.

Test Plan:

ABC_BUILD_NAME=check-seeds ./build-configuration.sh

Run this a few times on CI too

Reviewers: #bitcoin_abc, Fabien

Reviewed By: #bitcoin_abc, Fabien

Differential Revision: https://reviews.bitcoinabc.org/D5268

Details

Committed
jasonbcoxThu, Feb 13, 16:49
Pushed
jasonbcoxThu, Feb 13, 16:49
Reviewer
Restricted Project
Differential Revision
D5268: Fix a race condition with rpc ports in check-seeds
Parents
rABC65e1afb8a6c2: [standardness] activate SCRIPT_VERIFY_INPUT_SIGCHECKS in next upgrade
Branches
Unknown
Tags
Unknown