Page MenuHomePhabricator

Fix a race condition with rpc ports in check-seeds
ClosedPublic

Authored by jasonbcox on Tue, Feb 11, 22:13.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC7f63be6a4ba6: Fix a race condition with rpc ports in check-seeds
Summary

The RPC port from the first run of test-seeds is not guaranteed to be closed/cleaned up
by the OS by the time the second run on test-seeds occurs. Without this patch, check-seeds is flaky
and fails at random.

Test Plan
ABC_BUILD_NAME=check-seeds ./build-configuration.sh

Run this a few times on CI too

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Tue, Feb 11, 22:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Feb 11, 22:13
jasonbcox planned changes to this revision.Tue, Feb 11, 22:13
jasonbcox requested review of this revision.Tue, Feb 11, 22:35
Fabien accepted this revision.Thu, Feb 13, 09:48
This revision is now accepted and ready to land.Thu, Feb 13, 09:48
This revision was automatically updated to reflect the committed changes.