- User Since
- Jul 5 2017, 08:50 (84 w, 6 d)
Fri, Feb 15
New approach. Instead of modifing the existing nulldummy test, create a new test following deadalnix's test plan above.
Wed, Feb 13
According to telegram discussion, this change is controversial and needs to be split into 7 diffs.
Tue, Feb 12
Fri, Feb 8
Rename class LastBlock -> BlockHeader
Rename method tip -> hash_as_int
removed unneeded block generation, replace bytes_to_hex_str with ToHex, re-added block version
ftr, this was abandoned because other devs found it more or equally important to test for incompatibilites without 'great wall' upgrades enforced.
What's the plan for this test after NULLDUMMY consensus activation, I'm curious? Obviously it won't accept that last block anymore ...
lastblockhash -> lastblock.hash
Thu, Feb 7
Wed, Jan 30
This conflicts with D2341
Tue, Jan 29
What changes do you want @jasonbcox?
Turns out the failure in D2431 was unrelated to this. I'm happy to close this unlanded.
Add missing newline
This fixes test failure for me in D2431. The symptom locally was that bitcoind was unable to get a lock on a file in my ~/.bitcoin folder.
Fix abc-replay-protection + nits
Fix name error in parameter to bitcoind
Update after prerequisite todo items have landed. Cleanup and rebase.
Wed, Jan 23
Tue, Jan 22
MTP in test
Check that MTP is used, not nTime
Some nits addressed
Mon, Jan 21
Sun, Jan 20
Jan 19 2019
Jan 18 2019
Jan 17 2019
Port over missing comment
Jan 16 2019
Mar 2 2018
LGTM. The equivalent in XT is in PR https://github.com/bitcoinxt/bitcoinxt/pull/344.
Jan 16 2018
Jan 15 2018
LGTM. A couple of nits. You forgot attribution.
Jan 7 2018
Dec 19 2017
Dec 15 2017
Don't use pair
Added a warning if two (or more) addresses from incompatible networks are parsed.
Moved network selection to bitcoin.cpp
removed dummy object, cfg -> config
Dec 14 2017
Dec 13 2017
Dec 12 2017
Dec 8 2017
Looks good. You need a test to ensure PackCashAddrContent throws when it should.
Dec 7 2017
back to first proposal, with some nits
No code repitition