Page MenuHomePhabricator

dagurval (dagurval)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 5 2017, 08:50 (123 w, 3 d)

Recent Activity

Sep 18 2019

dagurval committed rSTAGING1fcc2a0a4cb0: Add function 'IsGreatWallEnabled' (authored by dagurval).
Add function 'IsGreatWallEnabled'
Sep 18 2019, 22:02
dagurval committed rSTAGING07fa32b405c2: [tests] Fix tx padding (authored by dagurval).
[tests] Fix tx padding
Sep 18 2019, 21:59

Feb 24 2019

dagurval abandoned D2341: Enforce NULLDUMMY.
Feb 24 2019, 21:33

Feb 15 2019

dagurval updated the diff for D2341: Enforce NULLDUMMY.

New approach. Instead of modifing the existing nulldummy test, create a new test following deadalnix's test plan above.

Feb 15 2019, 13:14

Feb 13 2019

dagurval abandoned D2508: [tests] nulldummy cleanup.

According to telegram discussion, this change is controversial and needs to be split into 7 diffs.

Feb 13 2019, 07:07

Feb 12 2019

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC31427f585a5c: Bump automatic replay protection to Nov 2019 upgrade (authored by dagurval).
Bump automatic replay protection to Nov 2019 upgrade
Feb 12 2019, 00:10
dagurval closed D2376: Bump automatic replay protection to Nov 2019 upgrade.
Feb 12 2019, 00:09

Feb 8 2019

dagurval updated the diff for D2508: [tests] nulldummy cleanup.

Rename class LastBlock -> BlockHeader
Rename method tip -> hash_as_int

Feb 8 2019, 22:02
dagurval added a comment to D2508: [tests] nulldummy cleanup.

This diff suffer from the classic syndrome of doing several things at once, causing discussion about one of these things to delay progress and all the others and everybody getting frustrated.

Feb 8 2019, 21:58
dagurval added inline comments to D2508: [tests] nulldummy cleanup.
Feb 8 2019, 13:28
dagurval updated the diff for D2508: [tests] nulldummy cleanup.

removed unneeded block generation, replace bytes_to_hex_str with ToHex, re-added block version

Feb 8 2019, 11:48
dagurval added a comment to D2431: [tests] Activate 'great wall' in the past.

ftr, this was abandoned because other devs found it more or equally important to test for incompatibilites without 'great wall' upgrades enforced.

Feb 8 2019, 10:06
dagurval added a comment to D2508: [tests] nulldummy cleanup.

What's the plan for this test after NULLDUMMY consensus activation, I'm curious? Obviously it won't accept that last block anymore ...

Feb 8 2019, 09:37
dagurval updated the diff for D2508: [tests] nulldummy cleanup.

lastblockhash -> lastblock.hash

Feb 8 2019, 09:36

Feb 7 2019

Herald added a reviewer for D2508: [tests] nulldummy cleanup: deadalnix.
Feb 7 2019, 14:02
dagurval added inline comments to D2341: Enforce NULLDUMMY.
Feb 7 2019, 13:41
dagurval added inline comments to D2341: Enforce NULLDUMMY.
Feb 7 2019, 13:40
dagurval abandoned D2431: [tests] Activate 'great wall' in the past.
Feb 7 2019, 12:49

Jan 30 2019

dagurval added a comment to D2444: Refactor comments in feature_nulldummy.py.

This conflicts with D2341

Jan 30 2019, 13:20

Jan 29 2019

dagurval added inline comments to D2341: Enforce NULLDUMMY.
Jan 29 2019, 23:31
dagurval abandoned D2437: qa: Temporarily disable test that reads the default datadir location.
Jan 29 2019, 23:25
dagurval added a comment to D2431: [tests] Activate 'great wall' in the past.

What changes do you want @jasonbcox?

Jan 29 2019, 23:24
dagurval added a comment to D2437: qa: Temporarily disable test that reads the default datadir location.

Turns out the failure in D2431 was unrelated to this. I'm happy to close this unlanded.

Jan 29 2019, 23:21
dagurval updated the diff for D2431: [tests] Activate 'great wall' in the past.

Add missing newline

Jan 29 2019, 23:20
dagurval added a comment to D2437: qa: Temporarily disable test that reads the default datadir location.

This fixes test failure for me in D2431. The symptom locally was that bitcoind was unable to get a lock on a file in my ~/.bitcoin folder.

Jan 29 2019, 23:13
Herald added a reviewer for D2437: qa: Temporarily disable test that reads the default datadir location: deadalnix.
Jan 29 2019, 23:10
dagurval updated the diff for D2341: Enforce NULLDUMMY.

Fix abc-replay-protection + nits

Jan 29 2019, 22:41
Herald added a reviewer for D2431: [tests] Activate 'great wall' in the past: deadalnix.
Jan 29 2019, 10:43
dagurval updated the diff for D2341: Enforce NULLDUMMY.

Fix name error in parameter to bitcoind

Jan 29 2019, 09:50
dagurval updated the summary of D2341: Enforce NULLDUMMY.
Jan 29 2019, 09:33
dagurval updated the diff for D2341: Enforce NULLDUMMY.

Update after prerequisite todo items have landed. Cleanup and rebase.

Jan 29 2019, 09:32

Jan 23 2019

dagurval committed rABC1fcc2a0a4cb0: Add function 'IsGreatWallEnabled' (authored by dagurval).
Add function 'IsGreatWallEnabled'
Jan 23 2019, 07:16
dagurval closed D2375: Add function 'IsGreatWallEnabled'.
Jan 23 2019, 07:15

Jan 22 2019

dagurval updated the diff for D2375: Add function 'IsGreatWallEnabled'.

MTP in test

Jan 22 2019, 21:01
dagurval updated the diff for D2375: Add function 'IsGreatWallEnabled'.

Check that MTP is used, not nTime

Jan 22 2019, 13:11
dagurval added inline comments to D2375: Add function 'IsGreatWallEnabled'.
Jan 22 2019, 11:38
dagurval committed rABC07fa32b405c2: [tests] Fix tx padding (authored by dagurval).
[tests] Fix tx padding
Jan 22 2019, 10:01
dagurval closed D2374: [tests] Fix tx padding.
Jan 22 2019, 10:01
dagurval updated the diff for D2375: Add function 'IsGreatWallEnabled'.

Some nits addressed

Jan 22 2019, 09:58

Jan 21 2019

Herald added a reviewer for D2376: Bump automatic replay protection to Nov 2019 upgrade: deadalnix.
Jan 21 2019, 22:21
Herald added a reviewer for D2375: Add function 'IsGreatWallEnabled': deadalnix.
Jan 21 2019, 21:48
dagurval added a comment to D2374: [tests] Fix tx padding.
#!/usr/bin/env python3
Jan 21 2019, 21:19
Herald added a reviewer for D2374: [tests] Fix tx padding: deadalnix.
Jan 21 2019, 21:02

Jan 20 2019

dagurval committed rSTAGINGf6c8a4ef792e: Do not make it trivial for inbound peers to generate log entries (authored by Matt Corallo <git@bluematt.me>).
Do not make it trivial for inbound peers to generate log entries
Jan 20 2019, 23:56

Jan 19 2019

dagurval updated the summary of D2341: Enforce NULLDUMMY.
Jan 19 2019, 00:36
Herald added a reviewer for D2341: Enforce NULLDUMMY: deadalnix.
Jan 19 2019, 00:33

Jan 18 2019

dagurval committed rABCf6c8a4ef792e: Do not make it trivial for inbound peers to generate log entries (authored by Matt Corallo <git@bluematt.me>).
Do not make it trivial for inbound peers to generate log entries
Jan 18 2019, 23:18
dagurval closed D2323: Do not make it trivial for inbound peers to generate log entries.
Jan 18 2019, 23:17
dagurval updated the diff for D2323: Do not make it trivial for inbound peers to generate log entries.

Nit addressed

Jan 18 2019, 07:57

Jan 17 2019

dagurval updated the diff for D2323: Do not make it trivial for inbound peers to generate log entries.

Port over missing comment

Jan 17 2019, 11:35

Jan 16 2019

dagurval updated the summary of D2323: Do not make it trivial for inbound peers to generate log entries.
Jan 16 2019, 08:47
Herald added a reviewer for D2323: Do not make it trivial for inbound peers to generate log entries: deadalnix.
Jan 16 2019, 08:46

Mar 2 2018

dagurval accepted D1148: Make dates explicit and fix erroneous comments.
Mar 2 2018, 14:02
dagurval accepted D1146: Make sure compact blocks work when there are more than 65536 transactions in a block.

LGTM. The equivalent in XT is in PR https://github.com/bitcoinxt/bitcoinxt/pull/344.

Mar 2 2018, 11:00

Jan 16 2018

dagurval accepted D967: Allow test cases to be skipped.
Jan 16 2018, 20:29
dagurval accepted D964: Control mempool persistence using a command line parameter..
Jan 16 2018, 11:37
dagurval accepted D966: Python functional tests should log in UTC.
Jan 16 2018, 11:34
dagurval added inline comments to D967: Allow test cases to be skipped.
Jan 16 2018, 11:28

Jan 15 2018

dagurval accepted D954: Backport the getchaintxstatsrpc RPC.

LGTM. A couple of nits. You forgot attribution.

Jan 15 2018, 11:24
dagurval accepted D947: [qt] Stop treating coinbase outputs differently: show them at 1conf.
Jan 15 2018, 10:57
dagurval accepted D945: Fix importwallet edge case rescan bug.
Jan 15 2018, 10:51
dagurval accepted D948: Remove redundant parameter params of EncodeDestination.
Jan 15 2018, 10:43

Jan 7 2018

dagurval accepted D903: test: Report InitBlockIndex result.
Jan 7 2018, 22:25

Dec 19 2017

dagurval accepted D801: Use user configured encoding in receive request.
Dec 19 2017, 18:31

Dec 15 2017

dagurval updated the diff for D583: Support parsing cashaddr from command line.

Don't use pair

Dec 15 2017, 20:02
dagurval committed rABCa38bff37c337: Introduce bitcoinUriScheme (authored by dagurval).
Introduce bitcoinUriScheme
Dec 15 2017, 19:37
dagurval closed D797: Introduce bitcoinUriScheme.
Dec 15 2017, 19:37
dagurval updated the diff for D583: Support parsing cashaddr from command line.

Added a warning if two (or more) addresses from incompatible networks are parsed.

Dec 15 2017, 13:26
dagurval updated the diff for D583: Support parsing cashaddr from command line.

Moved network selection to bitcoin.cpp

Dec 15 2017, 13:13
dagurval requested review of D801: Use user configured encoding in receive request.
Dec 15 2017, 12:14
dagurval updated the diff for D797: Introduce bitcoinUriScheme.

removed dummy object, cfg -> config

Dec 15 2017, 12:07

Dec 14 2017

dagurval added inline comments to D797: Introduce bitcoinUriScheme.
Dec 14 2017, 07:27

Dec 13 2017

dagurval committed rABCe52fa6d72dd2: Add missing include in receiverequestdialog (authored by dagurval).
Add missing include in receiverequestdialog
Dec 13 2017, 19:38
dagurval closed D806: Add missing include in receiverequestdialog.
Dec 13 2017, 19:38
dagurval closed T130: Revision D802 broke builds as Resolved by committing rABCe52fa6d72dd2: Add missing include in receiverequestdialog.
Dec 13 2017, 19:38
dagurval created D806: Add missing include in receiverequestdialog.
Dec 13 2017, 19:33
dagurval added a revision to T130: Revision D802 broke builds: D806: Add missing include in receiverequestdialog.
Dec 13 2017, 19:33
dagurval committed rABC87b604444cc5: Modify QR code to fit cashaddr (authored by dagurval).
Modify QR code to fit cashaddr
Dec 13 2017, 18:41
dagurval closed D802: Modify QR code to fit cashaddr.
Dec 13 2017, 18:41
dagurval added inline comments to D797: Introduce bitcoinUriScheme.
Dec 13 2017, 16:28
dagurval requested review of D797: Introduce bitcoinUriScheme.
Dec 13 2017, 16:27
dagurval added a reviewer for D802: Modify QR code to fit cashaddr: Restricted Project.
Dec 13 2017, 13:40
dagurval added a reviewer for D801: Use user configured encoding in receive request: Restricted Project.
Dec 13 2017, 13:39
dagurval added a comment to D802: Modify QR code to fit cashaddr.

Dec 13 2017, 12:44
dagurval created D802: Modify QR code to fit cashaddr.
Dec 13 2017, 12:44
dagurval created D801: Use user configured encoding in receive request.
Dec 13 2017, 11:48
dagurval added inline comments to D797: Introduce bitcoinUriScheme.
Dec 13 2017, 08:26

Dec 12 2017

dagurval updated the test plan for D583: Support parsing cashaddr from command line.
Dec 12 2017, 12:14
dagurval updated the diff for D583: Support parsing cashaddr from command line.

Parts of this were split out into D797 and D769. Rebased on top.

Dec 12 2017, 12:13
dagurval created D797: Introduce bitcoinUriScheme.
Dec 12 2017, 11:05

Dec 8 2017

dagurval committed rABCa492b58df9f5: Accept multiple schemes in parseBitcoinURI (authored by dagurval).
Accept multiple schemes in parseBitcoinURI
Dec 8 2017, 11:06
dagurval closed D769: Accept multiple schemes in parseBitcoinURI.
Dec 8 2017, 11:06
dagurval added a comment to D761: Encode cashaddr size properly in version bit..

Looks good. You need a test to ensure PackCashAddrContent throws when it should.

Dec 8 2017, 10:18
Herald added a reviewer for D769: Accept multiple schemes in parseBitcoinURI: Restricted Project.
Dec 8 2017, 09:41
dagurval committed rABC68daecd4edba: Encode destination using Base58 in WalletDB (authored by dagurval).
Encode destination using Base58 in WalletDB
Dec 8 2017, 08:21
dagurval closed D745: Encode destination using Base58 in WalletDB.
Dec 8 2017, 08:21

Dec 7 2017

dagurval updated the diff for D745: Encode destination using Base58 in WalletDB.

back to first proposal, with some nits

Dec 7 2017, 23:49
dagurval updated the diff for D745: Encode destination using Base58 in WalletDB.

No code repitition

Dec 7 2017, 12:48
dagurval added inline comments to D745: Encode destination using Base58 in WalletDB.
Dec 7 2017, 12:08

Dec 6 2017

dagurval accepted D764: Remove needless import.
Dec 6 2017, 22:03