Page MenuHomePhabricator

dagurval (dagurval)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 5 2017, 08:50 (144 w, 9 h)

Recent Activity

Yesterday

dagurval committed rSTAGING3a535f346e0b: Enable new ancestor/descendants chains limit at fork (authored by dagurval).
Enable new ancestor/descendants chains limit at fork
Tue, Apr 7, 23:01
dagurval committed rSTAGING20ecb768b0d6: Add new post-fork ancestor and descendants limit. (authored by dagurval).
Add new post-fork ancestor and descendants limit.
Tue, Apr 7, 22:59
dagurval committed rSTAGING65fa46b73131: Move mempool policy constants to policy/mempool.h (authored by dagurval).
Move mempool policy constants to policy/mempool.h
Tue, Apr 7, 22:57

Feb 14 2020

dagurval committed rABC3a535f346e0b: Enable new ancestor/descendants chains limit at fork (authored by dagurval).
Enable new ancestor/descendants chains limit at fork
Feb 14 2020, 21:16
dagurval closed D5244: Enable new ancestor/descendants chains limit at fork.
Feb 14 2020, 21:16
dagurval updated the diff for D5244: Enable new ancestor/descendants chains limit at fork.

Added full activation test

Feb 14 2020, 20:51
dagurval abandoned D5245: [qa] Test that mempool reverts to pre-phonon policies.

I'll merge the test into D5244 as advised by @jasonbcox

Feb 14 2020, 19:54
dagurval updated the diff for D5244: Enable new ancestor/descendants chains limit at fork.

Remove pre-phonon testing of mempool packages. Instead the D5245 test will be improved to test activation.

Feb 14 2020, 16:23
dagurval updated the diff for D5245: [qa] Test that mempool reverts to pre-phonon policies.

typo, docstring fix

Feb 14 2020, 07:14
dagurval planned changes to D5245: [qa] Test that mempool reverts to pre-phonon policies.
Feb 14 2020, 07:12
dagurval requested review of D5244: Enable new ancestor/descendants chains limit at fork.

What @markblundeberg said.

Feb 14 2020, 06:49

Feb 13 2020

dagurval retitled D5245: [qa] Test that mempool reverts to pre-phonon policies from Remove longer ancestor/descendants chain in case of reorg to [qa] Test that mempool reverts to pre-phonon policies.
Feb 13 2020, 14:15
dagurval updated the diff for D5245: [qa] Test that mempool reverts to pre-phonon policies.

Remove redundant changes in validation.cpp

Feb 13 2020, 14:14
dagurval planned changes to D5245: [qa] Test that mempool reverts to pre-phonon policies.
Feb 13 2020, 09:35
dagurval updated the diff for D5244: Enable new ancestor/descendants chains limit at fork.

Rebase to fix merge conflict with release notes.

Feb 13 2020, 09:21
dagurval requested review of D5244: Enable new ancestor/descendants chains limit at fork.

There is already a facility to run test pre and post upgrade. Please use this unless you are specifically testing for the activation.

Feb 13 2020, 08:49
dagurval added a comment to D5244: Enable new ancestor/descendants chains limit at fork.

Is there any reason for not updating the wallet limit at the same time ? Not doing so would prevent creating a >25 tx chain after the upgrade if -walletrejectlongchains is set.

Feb 13 2020, 08:38
dagurval committed rABC20ecb768b0d6: Add new post-fork ancestor and descendants limit. (authored by dagurval).
Add new post-fork ancestor and descendants limit.
Feb 13 2020, 06:57
dagurval closed D5243: Add new post-fork ancestor and descendants limit..
Feb 13 2020, 06:57

Feb 12 2020

dagurval updated the diff for D5244: Enable new ancestor/descendants chains limit at fork.
  • Replace fork with ponon-upgrade in parameter description.
  • Move maxorphantx to common_params
  • Add a comment on why minimumAmount was added
  • Add release notes
Feb 12 2020, 07:48
dagurval planned changes to D5244: Enable new ancestor/descendants chains limit at fork.
Feb 12 2020, 07:13

Feb 11 2020

dagurval updated the diff for D5245: [qa] Test that mempool reverts to pre-phonon policies.

Rebase, rename test, some test cleanup

Feb 11 2020, 13:31
dagurval added inline comments to D5243: Add new post-fork ancestor and descendants limit..
Feb 11 2020, 11:39
dagurval updated the diff for D5244: Enable new ancestor/descendants chains limit at fork.

Ensure test selects inputs with enough coins during the second run

Feb 11 2020, 11:37
dagurval updated the diff for D5243: Add new post-fork ancestor and descendants limit..

typo

Feb 11 2020, 10:37
dagurval updated the diff for D5243: Add new post-fork ancestor and descendants limit..

test braino, add to cmake

Feb 11 2020, 10:29
dagurval added inline comments to D5244: Enable new ancestor/descendants chains limit at fork.
Feb 11 2020, 09:46
dagurval planned changes to D5243: Add new post-fork ancestor and descendants limit..
Feb 11 2020, 09:44

Feb 10 2020

dagurval updated the diff for D5243: Add new post-fork ancestor and descendants limit..

Header inclusion order, explicit SetMTP, rename test

Feb 10 2020, 23:24
dagurval committed rABC65fa46b73131: Move mempool policy constants to policy/mempool.h (authored by dagurval).
Move mempool policy constants to policy/mempool.h
Feb 10 2020, 22:35
dagurval closed D5242: Move mempool policy constants to policy/mempool.h.
Feb 10 2020, 22:35
dagurval planned changes to D5245: [qa] Test that mempool reverts to pre-phonon policies.

Marking as planned changes due to issues with parent diff

Feb 10 2020, 22:33
dagurval planned changes to D5244: Enable new ancestor/descendants chains limit at fork.
Feb 10 2020, 21:37
dagurval updated the diff for D5244: Enable new ancestor/descendants chains limit at fork.

Replaced whitespace with tab in CMakeList.txt (sorry for the noise)

Feb 10 2020, 21:17
dagurval updated the diff for D5244: Enable new ancestor/descendants chains limit at fork.

Added mempool.cpp to CMakeList.txt

Feb 10 2020, 21:14
dagurval updated the summary of D5245: [qa] Test that mempool reverts to pre-phonon policies.
Feb 10 2020, 21:01
dagurval created D5245: [qa] Test that mempool reverts to pre-phonon policies.
Feb 10 2020, 21:00
dagurval created D5244: Enable new ancestor/descendants chains limit at fork.
Feb 10 2020, 20:48
dagurval updated the summary of D5243: Add new post-fork ancestor and descendants limit..
Feb 10 2020, 20:40
dagurval created D5243: Add new post-fork ancestor and descendants limit..
Feb 10 2020, 20:30
dagurval created D5242: Move mempool policy constants to policy/mempool.h.
Feb 10 2020, 20:26

Sep 18 2019

dagurval committed rSTAGING1fcc2a0a4cb0: Add function 'IsGreatWallEnabled' (authored by dagurval).
Add function 'IsGreatWallEnabled'
Sep 18 2019, 22:02
dagurval committed rSTAGING07fa32b405c2: [tests] Fix tx padding (authored by dagurval).
[tests] Fix tx padding
Sep 18 2019, 21:59

Feb 24 2019

dagurval abandoned D2341: Enforce NULLDUMMY.
Feb 24 2019, 21:33

Feb 15 2019

dagurval updated the diff for D2341: Enforce NULLDUMMY.

New approach. Instead of modifing the existing nulldummy test, create a new test following deadalnix's test plan above.

Feb 15 2019, 13:14

Feb 13 2019

dagurval abandoned D2508: [tests] nulldummy cleanup.

According to telegram discussion, this change is controversial and needs to be split into 7 diffs.

Feb 13 2019, 07:07

Feb 12 2019

Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> committed rABC31427f585a5c: Bump automatic replay protection to Nov 2019 upgrade (authored by dagurval).
Bump automatic replay protection to Nov 2019 upgrade
Feb 12 2019, 00:10
dagurval closed D2376: Bump automatic replay protection to Nov 2019 upgrade.
Feb 12 2019, 00:09

Feb 8 2019

dagurval updated the diff for D2508: [tests] nulldummy cleanup.

Rename class LastBlock -> BlockHeader
Rename method tip -> hash_as_int

Feb 8 2019, 22:02
dagurval added a comment to D2508: [tests] nulldummy cleanup.

This diff suffer from the classic syndrome of doing several things at once, causing discussion about one of these things to delay progress and all the others and everybody getting frustrated.

Feb 8 2019, 21:58
dagurval added inline comments to D2508: [tests] nulldummy cleanup.
Feb 8 2019, 13:28
dagurval updated the diff for D2508: [tests] nulldummy cleanup.

removed unneeded block generation, replace bytes_to_hex_str with ToHex, re-added block version

Feb 8 2019, 11:48
dagurval added a comment to D2431: [tests] Activate 'great wall' in the past.

ftr, this was abandoned because other devs found it more or equally important to test for incompatibilites without 'great wall' upgrades enforced.

Feb 8 2019, 10:06
dagurval added a comment to D2508: [tests] nulldummy cleanup.

What's the plan for this test after NULLDUMMY consensus activation, I'm curious? Obviously it won't accept that last block anymore ...

Feb 8 2019, 09:37
dagurval updated the diff for D2508: [tests] nulldummy cleanup.

lastblockhash -> lastblock.hash

Feb 8 2019, 09:36

Feb 7 2019

Herald added a reviewer for D2508: [tests] nulldummy cleanup: deadalnix.
Feb 7 2019, 14:02
dagurval added inline comments to D2341: Enforce NULLDUMMY.
Feb 7 2019, 13:41
dagurval added inline comments to D2341: Enforce NULLDUMMY.
Feb 7 2019, 13:40
dagurval abandoned D2431: [tests] Activate 'great wall' in the past.
Feb 7 2019, 12:49

Jan 30 2019

dagurval added a comment to D2444: Refactor comments in feature_nulldummy.py.

This conflicts with D2341

Jan 30 2019, 13:20

Jan 29 2019

dagurval added inline comments to D2341: Enforce NULLDUMMY.
Jan 29 2019, 23:31
dagurval abandoned D2437: qa: Temporarily disable test that reads the default datadir location.
Jan 29 2019, 23:25
dagurval added a comment to D2431: [tests] Activate 'great wall' in the past.

What changes do you want @jasonbcox?

Jan 29 2019, 23:24
dagurval added a comment to D2437: qa: Temporarily disable test that reads the default datadir location.

Turns out the failure in D2431 was unrelated to this. I'm happy to close this unlanded.

Jan 29 2019, 23:21
dagurval updated the diff for D2431: [tests] Activate 'great wall' in the past.

Add missing newline

Jan 29 2019, 23:20
dagurval added a comment to D2437: qa: Temporarily disable test that reads the default datadir location.

This fixes test failure for me in D2431. The symptom locally was that bitcoind was unable to get a lock on a file in my ~/.bitcoin folder.

Jan 29 2019, 23:13
Herald added a reviewer for D2437: qa: Temporarily disable test that reads the default datadir location: deadalnix.
Jan 29 2019, 23:10
dagurval updated the diff for D2341: Enforce NULLDUMMY.

Fix abc-replay-protection + nits

Jan 29 2019, 22:41
Herald added a reviewer for D2431: [tests] Activate 'great wall' in the past: deadalnix.
Jan 29 2019, 10:43
dagurval updated the diff for D2341: Enforce NULLDUMMY.

Fix name error in parameter to bitcoind

Jan 29 2019, 09:50
dagurval updated the summary of D2341: Enforce NULLDUMMY.
Jan 29 2019, 09:33
dagurval updated the diff for D2341: Enforce NULLDUMMY.

Update after prerequisite todo items have landed. Cleanup and rebase.

Jan 29 2019, 09:32

Jan 23 2019

dagurval committed rABC1fcc2a0a4cb0: Add function 'IsGreatWallEnabled' (authored by dagurval).
Add function 'IsGreatWallEnabled'
Jan 23 2019, 07:16
dagurval closed D2375: Add function 'IsGreatWallEnabled'.
Jan 23 2019, 07:15

Jan 22 2019

dagurval updated the diff for D2375: Add function 'IsGreatWallEnabled'.

MTP in test

Jan 22 2019, 21:01
dagurval updated the diff for D2375: Add function 'IsGreatWallEnabled'.

Check that MTP is used, not nTime

Jan 22 2019, 13:11
dagurval added inline comments to D2375: Add function 'IsGreatWallEnabled'.
Jan 22 2019, 11:38
dagurval committed rABC07fa32b405c2: [tests] Fix tx padding (authored by dagurval).
[tests] Fix tx padding
Jan 22 2019, 10:01
dagurval closed D2374: [tests] Fix tx padding.
Jan 22 2019, 10:01
dagurval updated the diff for D2375: Add function 'IsGreatWallEnabled'.

Some nits addressed

Jan 22 2019, 09:58

Jan 21 2019

Herald added a reviewer for D2376: Bump automatic replay protection to Nov 2019 upgrade: deadalnix.
Jan 21 2019, 22:21
Herald added a reviewer for D2375: Add function 'IsGreatWallEnabled': deadalnix.
Jan 21 2019, 21:48
dagurval added a comment to D2374: [tests] Fix tx padding.
#!/usr/bin/env python3
Jan 21 2019, 21:19
Herald added a reviewer for D2374: [tests] Fix tx padding: deadalnix.
Jan 21 2019, 21:02

Jan 20 2019

dagurval committed rSTAGINGf6c8a4ef792e: Do not make it trivial for inbound peers to generate log entries (authored by Matt Corallo <git@bluematt.me>).
Do not make it trivial for inbound peers to generate log entries
Jan 20 2019, 23:56

Jan 19 2019

dagurval updated the summary of D2341: Enforce NULLDUMMY.
Jan 19 2019, 00:36
Herald added a reviewer for D2341: Enforce NULLDUMMY: deadalnix.
Jan 19 2019, 00:33

Jan 18 2019

dagurval committed rABCf6c8a4ef792e: Do not make it trivial for inbound peers to generate log entries (authored by Matt Corallo <git@bluematt.me>).
Do not make it trivial for inbound peers to generate log entries
Jan 18 2019, 23:18
dagurval closed D2323: Do not make it trivial for inbound peers to generate log entries.
Jan 18 2019, 23:17
dagurval updated the diff for D2323: Do not make it trivial for inbound peers to generate log entries.

Nit addressed

Jan 18 2019, 07:57

Jan 17 2019

dagurval updated the diff for D2323: Do not make it trivial for inbound peers to generate log entries.

Port over missing comment

Jan 17 2019, 11:35

Jan 16 2019

dagurval updated the summary of D2323: Do not make it trivial for inbound peers to generate log entries.
Jan 16 2019, 08:47
Herald added a reviewer for D2323: Do not make it trivial for inbound peers to generate log entries: deadalnix.
Jan 16 2019, 08:46

Mar 2 2018

dagurval accepted D1148: Make dates explicit and fix erroneous comments.
Mar 2 2018, 14:02
dagurval accepted D1146: Make sure compact blocks work when there are more than 65536 transactions in a block.

LGTM. The equivalent in XT is in PR https://github.com/bitcoinxt/bitcoinxt/pull/344.

Mar 2 2018, 11:00

Jan 16 2018

dagurval accepted D967: Allow test cases to be skipped.
Jan 16 2018, 20:29
dagurval accepted D964: Control mempool persistence using a command line parameter..
Jan 16 2018, 11:37
dagurval accepted D966: Python functional tests should log in UTC.
Jan 16 2018, 11:34
dagurval added inline comments to D967: Allow test cases to be skipped.
Jan 16 2018, 11:28

Jan 15 2018

dagurval accepted D954: Backport the getchaintxstatsrpc RPC.

LGTM. A couple of nits. You forgot attribution.

Jan 15 2018, 11:24