Allow test cases to be skipped
ClosedPublic
Actions

Authored by schancel on Jan 16 2018, 07:04.

Details

Reviewers

deadalnix
dagurval

Group Reviewers

Restricted Project

Commits

rSTAGINGf61fd9dc1ce3: Allow test cases to be skipped
rABCf61fd9dc1ce3: Allow test cases to be skipped

Summary

Currently, functional test cases can either pass or fail. There are
occasions when it is helpful to skip tests, for example if the
system they are running on does not meet the requirements for the test.
The rest of the test suite can run without being marked as a failure.

This commit adds framework for tests to skip if their requirements
aren't met.

Backport of Core PR10053

Test Plan

run functional tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

schancel created this revision.Jan 16 2018, 07:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 16 2018, 07:04

dagurval added a subscriber: dagurval.Jan 16 2018, 11:28

dagurval added inline comments.

test/functional/test_runner.py
39 ↗	(On Diff #2538)	Nit: Can't these be imported fro mthe test framework?
267 ↗	(On Diff #2538)	Nit: get_next could return the error code instead, so you don't have to do compare to the string translation of it
276 ↗	(On Diff #2538)	Nit: Use another color for skipped?

Please add a reference to where that code comes from.

@dagurval You're right about all your nits. This is just a backport though, so I dont' want to change it here. I have some plans about how I want to refactor this entire suite soon.

schancel edited the summary of this revision. (Show Details)Jan 16 2018, 18:12

dagurval accepted this revision.Jan 16 2018, 20:29

This revision is now accepted and ready to land.Jan 16 2018, 20:29

Closed by commit rABCf61fd9dc1ce3: Allow test cases to be skipped (authored by John Newbery <john@johnnewbery.com>, committed by schancel). · Explain WhyJan 16 2018, 22:03

This revision was automatically updated to reflect the committed changes.

schancel mentioned this in T142: Backport Core PR 10053: Allow functional test skipping.Jan 17 2018, 23:50