Page MenuHomePhabricator

Bump automatic replay protection to Nov 2019 upgrade
ClosedPublic

Authored by markblundeberg on Jan 21 2019, 22:21.

Details

Summary

This returns main chain to ForkID of 0 after the May 2019 upgrade and implements automatic replay protection for the Nov 2019 upgrade.

For reference see last bump in D1612

(original author of diff: dagurval)

Test Plan

Replay protection is covered by unit tests, however it is very important to manually double check that the timestamp for activation is set correctly.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dagurval created this revision.Jan 21 2019, 22:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2019, 22:21
Herald added a subscriber: schancel. · View Herald Transcript

This looks good to me but will need to wait for the release with the feature freeze.

deadalnix requested changes to this revision.Jan 22 2019, 01:13

Marking as request change, even though there is really no change to be made, just to clear the review queue.

This revision now requires changes to proceed.Jan 22 2019, 01:13
deadalnix edited the summary of this revision. (Show Details)Jan 22 2019, 01:13
Mengerian accepted this revision.Jan 22 2019, 06:31
Mengerian added a subscriber: Mengerian.

I double-checked the timestamps and everything looks good to me.

Will need to be rebased and release notes portion resolved if pushed to the next release.

markblundeberg accepted this revision.Feb 9 2019, 19:27
markblundeberg added a subscriber: markblundeberg.

Looks like this is ready to go -- just return it for review from the comment Action menu.

Mengerian added a comment.EditedFeb 9 2019, 19:41

Yeah, @dagurval you just need to rebase for the release notes, and then it should be ready to land

EDIT: Although in theory it may be best to land this Diff last, after all the other "activation" Diffs, so that no build will ever conflict with the Upgrade release without replay protection.

deadalnix accepted this revision.Feb 9 2019, 20:26
This revision is now accepted and ready to land.Feb 9 2019, 20:26
markblundeberg commandeered this revision.Feb 11 2019, 23:24
markblundeberg edited reviewers, added: dagurval; removed: markblundeberg.

I'm gonna grab this just to make sure it can get landed soon. Sorry for barging in!

rebased ; release notes now applied to 0.19.0

markblundeberg edited the summary of this revision. (Show Details)Feb 11 2019, 23:30
deadalnix accepted this revision.Feb 11 2019, 23:31
This revision was automatically updated to reflect the committed changes.

(make check and all functional tests passed on my local machine as well)