HomePhabricator

[tests] Tidy up mininode

Description

[tests] Tidy up mininode

Summary:
Add docstrings and renames some methods.
Also removes the redundant NodeConn.readable() method override.

Partial backport of core PR11712 (commit 4d50598)

Depend on D2357

Test Plan:

./test/functional/test_runner.py

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2358

Details

Provenance
John Newbery <john@johnnewbery.com>Authored on Nov 23 2017, 14:47
FabienCommitted on Jan 21 2019, 19:14
FabienPushed on Jan 21 2019, 19:14
Reviewer
Restricted Project
Differential Revision
D2358: [tests] Tidy up mininode
Parents
rABC9cc342a2441d: [tests] Remove mininode periodic (half-hour) ping messages
Branches
Unknown
Tags
Unknown

Event Timeline

Fabien committed rABCf3a7d2f8ef59: [tests] Tidy up mininode (authored by John Newbery <john@johnnewbery.com>).Jan 21 2019, 19:14