HomePhabricator

Do not make it trivial for inbound peers to generate log entries

Description

Do not make it trivial for inbound peers to generate log entries

Summary:
https://github.com/bitcoin/bitcoin/pull/11583

We should generally avoid writing to debug.log unconditionally for
inbound peers which misbehave (the peer being about to be banned
being an exception, since they cannot do this twice).

To avoid removing logs for outbound peers, a new log is added to
notify users when a new outbound peer is connected which mimics
the version print.

This is a backport of Core PR11583

Test Plan: CI

Reviewers: #bitcoin_abc, deadalnix, Fabien

Reviewed By: #bitcoin_abc, deadalnix, Fabien

Subscribers: Fabien, teamcity, schancel

Differential Revision: https://reviews.bitcoinabc.org/D2323

Details

Provenance
Matt Corallo <git@bluematt.me>Authored on Oct 30 2017, 22:56
dagurvalCommitted on Jan 18 2019, 23:17
MengerianPushed on Jan 19 2019, 04:38
Reviewer
Restricted Project
Differential Revision
D2323: Do not make it trivial for inbound peers to generate log entries
Parents
rSTAGING53a858a4808e: Merge #10165: [Wallet] Refactoring by using CInputCoin instead of std::pair
Branches
Unknown
Tags
Unknown
References
tag: phabricator/base/6797