Page MenuHomePhabricator

Merge #15321: doc: Add cs_main lock annotations for mapBlockIndex
ClosedPublic

Authored by markblundeberg on Feb 10 2020, 12:45.

Details

Summary

PR15321 backport, aside from one minor change which will be noticed
when the backport in question happens later on ( PR14957 ).

Depends on D5237

Test Plan

ninja check all using clang compiler

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Feb 10 2020, 12:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 10 2020, 12:45
teamcity edited the summary of this revision. (Show Details)Feb 10 2020, 12:45

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

deadalnix requested changes to this revision.Feb 10 2020, 14:15
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/wallet/test/wallet_tests.cpp
36 ↗(On Diff #16208)

Backporting in order would be much better. Alternatively, mentioning what actually needs to be seen and have a reference to the diff would be helpful rather than send the person who will backport on a wild chase.

This revision now requires changes to proceed.Feb 10 2020, 14:15
markblundeberg added inline comments.Feb 11 2020, 07:15
src/wallet/test/wallet_tests.cpp
36 ↗(On Diff #16208)

Yeah I looked into it, but those backports look a bit fragile to pull in just for this (the one in question is a bugfix and amusingly introduces arithmetic on null pointers -- https://github.com/bitcoin/bitcoin/pull/14957/files#diff-c0ec078346af03640b953e854ff6609aR344 -- which will be fixed eventually once T600 is done).

update comment

deadalnix accepted this revision.Feb 11 2020, 16:37
This revision is now accepted and ready to land.Feb 11 2020, 16:37