Page MenuHomePhabricator

wallet: Initialize stop_block to nullptr in ScanForWalletTransactions
ClosedPublic

Authored by Fabien on Wed, Mar 25, 17:16.

Details

Summary
Previously the argument would be untouched if the first block scan
failed. This makes the behavior predictable, and consistent with the
documentation.

Backport of core PR14957 and the remaining of PR15321 (see D5238).

Depends on D5563.

Test Plan

With Clang:

cmake -GNinja .. -DCMAKE_BUILD_TYPE=Debug -DENABLE_WERROR=ON
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Mar 25, 17:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Mar 25, 17:16

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Wed, Mar 25, 19:02
This revision is now accepted and ready to land.Wed, Mar 25, 19:02