Page MenuHomePhabricator

Add stop_block out arg to ScanForWalletTransactions
ClosedPublic

Authored by Fabien on Wed, Mar 25, 16:39.

Details

Summary
Accurately reports the last block successfully scanned, replacing a
return of the chain tip, which represented possibly inaccurated data in
a race condition.

Completes backport of core PR13076:
https://github.com/bitcoin/bitcoin/pull/13076/commits/bd3b0361d840bff95988a048abf70ade94d80524

Depends on D5562.

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Mar 25, 16:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Mar 25, 16:40
teamcity edited the summary of this revision. (Show Details)Wed, Mar 25, 16:40

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Wed, Mar 25, 18:58
This revision is now accepted and ready to land.Wed, Mar 25, 18:58
This revision was automatically updated to reflect the committed changes.