Page MenuHomePhabricator

Return a status enum from ScanForWalletTransactions
ClosedPublic

Authored by Fabien on Wed, Mar 25, 16:30.

Details

Summary
Return the failed block as an out var.

This clarifies the outcome as the prior return value could
be null due to user abort or failure.

Partial backport of core PR13076:
https://github.com/bitcoin/bitcoin/pull/13076/commits/3002d6cf31821622e9f21d51e536cafc5cfb10ae

Depends on D5561.

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Mar 25, 16:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Mar 25, 16:30
teamcity edited the summary of this revision. (Show Details)Wed, Mar 25, 16:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Wed, Mar 25, 18:56
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/test/setup_common.h
34 ↗(On Diff #17164)

This is calling for updates in the seeder's test.

src/wallet/wallet.cpp
1809 ↗(On Diff #17164)

OK because this is a backport, but yoda style is really meh.

1949 ↗(On Diff #17164)

If you are going to change this, use a ternary.

This revision is now accepted and ready to land.Wed, Mar 25, 18:56
deadalnix requested changes to this revision.Wed, Mar 25, 18:59
This revision now requires changes to proceed.Wed, Mar 25, 18:59
Fabien updated this revision to Diff 17175.Wed, Mar 25, 19:59

A ternary, I did use.

deadalnix accepted this revision.Wed, Mar 25, 23:58
This revision is now accepted and ready to land.Wed, Mar 25, 23:58
This revision was automatically updated to reflect the committed changes.