Page MenuHomePhabricator
Differential D5562

Return a status enum from ScanForWalletTransactions
ClosedPublic
Actions

Authored by Fabien on Mar 25 2020, 16:30.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING14fb21559761: Return a status enum from ScanForWalletTransactions
rABC14fb21559761: Return a status enum from ScanForWalletTransactions
Summary
Return the failed block as an out var.

This clarifies the outcome as the prior return value could
be null due to user abort or failure.

Partial backport of core PR13076:
https://github.com/bitcoin/bitcoin/pull/13076/commits/3002d6cf31821622e9f21d51e536cafc5cfb10ae

Depends on D5561.

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13076_part2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9974
Build 17798: Default Diff Build & Tests
Build 17797: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 25 2020, 16:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 25 2020, 16:30
teamcity added a comment.Mar 25 2020, 16:30

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity edited the summary of this revision. (Show Details)Mar 25 2020, 16:30

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien added a child revision: D5563: Add stop_block out arg to ScanForWalletTransactions.Mar 25 2020, 16:39
teamcity added a comment.Mar 25 2020, 16:52

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9964: Diff 17164.Mar 25 2020, 16:52
deadalnix accepted this revision.Mar 25 2020, 18:56
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/test/setup_common.h
34 ↗(On Diff #17164)

This is calling for updates in the seeder's test.

src/wallet/wallet.cpp
1809 ↗(On Diff #17164)

OK because this is a backport, but yoda style is really meh.

1949 ↗(On Diff #17164)

If you are going to change this, use a ternary.

This revision is now accepted and ready to land.Mar 25 2020, 18:56
deadalnix requested changes to this revision.Mar 25 2020, 18:59
This revision now requires changes to proceed.Mar 25 2020, 18:59
Fabien updated this revision to Diff 17175.Mar 25 2020, 19:59

A ternary, I did use.

teamcity added a comment.Mar 25 2020, 19:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 25 2020, 20:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9974: Diff 17175.Mar 25 2020, 20:10
deadalnix accepted this revision.Mar 25 2020, 23:58
This revision is now accepted and ready to land.Mar 25 2020, 23:58
Closed by commit rABC14fb21559761: Return a status enum from ScanForWalletTransactions (authored by Ben Woosley <ben.woosley@gmail.com>, committed by Fabien). · Explain WhyMar 26 2020, 12:33
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC14fb21559761: Return a status enum from ScanForWalletTransactions.
Fabien added a commit: rSTAGING14fb21559761: Return a status enum from ScanForWalletTransactions.Apr 7 2020, 23:28

Revision Contents
Changeset List

PathSize
src/
qt/
test/
9 lines
test/
10 lines
wallet/
24 lines
test/
25 lines
12 lines
56 lines

Diff 17175

View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/test/setup_common.h

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...