Page MenuHomePhabricator

Return a status enum from ScanForWalletTransactions
ClosedPublic

Authored by Fabien on Mar 25 2020, 16:30.

Details

Summary
Return the failed block as an out var.

This clarifies the outcome as the prior return value could
be null due to user abort or failure.

Partial backport of core PR13076:
https://github.com/bitcoin/bitcoin/pull/13076/commits/3002d6cf31821622e9f21d51e536cafc5cfb10ae

Depends on D5561.

Test Plan
ninja all check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13076_part2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9974
Build 17798: Default Diff Build & Tests
Build 17797: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/test/setup_common.h
34 ↗(On Diff #17164)

This is calling for updates in the seeder's test.

src/wallet/wallet.cpp
1809 ↗(On Diff #17164)

OK because this is a backport, but yoda style is really meh.

1949 ↗(On Diff #17164)

If you are going to change this, use a ternary.

This revision is now accepted and ready to land.Mar 25 2020, 18:56
deadalnix requested changes to this revision.Mar 25 2020, 18:59
This revision now requires changes to proceed.Mar 25 2020, 18:59
This revision is now accepted and ready to land.Mar 25 2020, 23:58