HomePhabricator

Return a status enum from ScanForWalletTransactions

Description

Return a status enum from ScanForWalletTransactions

Summary:

Return the failed block as an out var.

This clarifies the outcome as the prior return value could
be null due to user abort or failure.

Partial backport of core PR13076:
https://github.com/bitcoin/bitcoin/pull/13076/commits/3002d6cf31821622e9f21d51e536cafc5cfb10ae

Depends on D5561.

Test Plan:

ninja all check check-functional

Reviewers: #bitcoin_abc, deadalnix

Reviewed By: #bitcoin_abc, deadalnix

Subscribers: deadalnix

Differential Revision: https://reviews.bitcoinabc.org/D5562

Details

Provenance
Ben Woosley <ben.woosley@gmail.com>Authored on Apr 29 2018, 15:45
FabienCommitted on Mar 26 2020, 12:33
FabienPushed on Mar 26 2020, 13:37
Reviewer
Restricted Project
Differential Revision
D5562: Return a status enum from ScanForWalletTransactions
Parents
rSTAGING4e8e7bf6154d: Make CWallet::ScanForWalletTransactions args and return value const
Branches
Unknown
Tags
Unknown